* [PATCH v4] qapi/qom: Memory backend property prealloc-threads doc fix
@ 2022-11-14 3:24 Zhenyu Zhang
2022-11-14 5:19 ` Gavin Shan
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: Zhenyu Zhang @ 2022-11-14 3:24 UTC (permalink / raw)
To: qemu-devel; +Cc: gshan, imammedo, armbru, philmd, eric.auger, lijin
Commit ffac16fab3 "hostmem: introduce "prealloc-threads" property"
(v5.0.0) changed the default number of threads from number of CPUs
to 1. This was deemed a regression, and fixed in commit f8d426a685
"hostmem: default the amount of prealloc-threads to smp-cpus".
Except the documentation remained unchanged.
Update 'qapi/qom.json' to reflect the change in commit f8d426a6852c.
Signed-off-by: Zhenyu Zhang <zhenyzha@redhat.com>
---
v4: Fix the line exceeding 80 characters limitation issue (Gavin)
v3: Covers historical descriptions (Markus)
v2: The property is changed to smp-cpus since 5.0 (Phild)
---
qapi/qom.json | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/qapi/qom.json b/qapi/qom.json
index 30e76653ad..f4a7917f3d 100644
--- a/qapi/qom.json
+++ b/qapi/qom.json
@@ -576,7 +576,8 @@
#
# @prealloc: if true, preallocate memory (default: false)
#
-# @prealloc-threads: number of CPU threads to use for prealloc (default: 1)
+# @prealloc-threads: number of CPU threads to use for prealloc
+# (default: number of CPUs) (since 5.0)
#
# @prealloc-context: thread context to use for creation of preallocation threads
# (default: none) (since 7.2)
--
2.31.1
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH v4] qapi/qom: Memory backend property prealloc-threads doc fix
2022-11-14 3:24 [PATCH v4] qapi/qom: Memory backend property prealloc-threads doc fix Zhenyu Zhang
@ 2022-11-14 5:19 ` Gavin Shan
2022-11-14 7:42 ` Markus Armbruster
2022-11-14 8:33 ` Philippe Mathieu-Daudé
2 siblings, 0 replies; 4+ messages in thread
From: Gavin Shan @ 2022-11-14 5:19 UTC (permalink / raw)
To: Zhenyu Zhang, qemu-devel; +Cc: imammedo, armbru, philmd, eric.auger, lijin
On 11/14/22 11:24 AM, Zhenyu Zhang wrote:
> Commit ffac16fab3 "hostmem: introduce "prealloc-threads" property"
> (v5.0.0) changed the default number of threads from number of CPUs
> to 1. This was deemed a regression, and fixed in commit f8d426a685
> "hostmem: default the amount of prealloc-threads to smp-cpus".
> Except the documentation remained unchanged.
>
> Update 'qapi/qom.json' to reflect the change in commit f8d426a6852c.
>
> Signed-off-by: Zhenyu Zhang <zhenyzha@redhat.com>
> ---
>
> v4: Fix the line exceeding 80 characters limitation issue (Gavin)
> v3: Covers historical descriptions (Markus)
> v2: The property is changed to smp-cpus since 5.0 (Phild)
>
> ---
> qapi/qom.json | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
Reviewed-by: Gavin Shan <gshan@redhat.com>
> diff --git a/qapi/qom.json b/qapi/qom.json
> index 30e76653ad..f4a7917f3d 100644
> --- a/qapi/qom.json
> +++ b/qapi/qom.json
> @@ -576,7 +576,8 @@
> #
> # @prealloc: if true, preallocate memory (default: false)
> #
> -# @prealloc-threads: number of CPU threads to use for prealloc (default: 1)
> +# @prealloc-threads: number of CPU threads to use for prealloc
> +# (default: number of CPUs) (since 5.0)
> #
> # @prealloc-context: thread context to use for creation of preallocation threads
> # (default: none) (since 7.2)
>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH v4] qapi/qom: Memory backend property prealloc-threads doc fix
2022-11-14 3:24 [PATCH v4] qapi/qom: Memory backend property prealloc-threads doc fix Zhenyu Zhang
2022-11-14 5:19 ` Gavin Shan
@ 2022-11-14 7:42 ` Markus Armbruster
2022-11-14 8:33 ` Philippe Mathieu-Daudé
2 siblings, 0 replies; 4+ messages in thread
From: Markus Armbruster @ 2022-11-14 7:42 UTC (permalink / raw)
To: Zhenyu Zhang; +Cc: qemu-devel, gshan, imammedo
Zhenyu Zhang <zhenyzha@redhat.com> writes:
> Commit ffac16fab3 "hostmem: introduce "prealloc-threads" property"
> (v5.0.0) changed the default number of threads from number of CPUs
> to 1. This was deemed a regression, and fixed in commit f8d426a685
> "hostmem: default the amount of prealloc-threads to smp-cpus".
> Except the documentation remained unchanged.
>
> Update 'qapi/qom.json' to reflect the change in commit f8d426a6852c.
>
> Signed-off-by: Zhenyu Zhang <zhenyzha@redhat.com>
> ---
>
> v4: Fix the line exceeding 80 characters limitation issue (Gavin)
> v3: Covers historical descriptions (Markus)
> v2: The property is changed to smp-cpus since 5.0 (Phild)
>
> ---
> qapi/qom.json | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/qapi/qom.json b/qapi/qom.json
> index 30e76653ad..f4a7917f3d 100644
> --- a/qapi/qom.json
> +++ b/qapi/qom.json
> @@ -576,7 +576,8 @@
> #
> # @prealloc: if true, preallocate memory (default: false)
> #
> -# @prealloc-threads: number of CPU threads to use for prealloc (default: 1)
> +# @prealloc-threads: number of CPU threads to use for prealloc
Could drop "CPU" while there. Not worth a respin by itself, but perhaps
the maintainer can drop it for you.
> +# (default: number of CPUs) (since 5.0)
> #
> # @prealloc-context: thread context to use for creation of preallocation threads
> # (default: none) (since 7.2)
Reviewed-by: Markus Armbruster <armbru@redhat.com>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH v4] qapi/qom: Memory backend property prealloc-threads doc fix
2022-11-14 3:24 [PATCH v4] qapi/qom: Memory backend property prealloc-threads doc fix Zhenyu Zhang
2022-11-14 5:19 ` Gavin Shan
2022-11-14 7:42 ` Markus Armbruster
@ 2022-11-14 8:33 ` Philippe Mathieu-Daudé
2 siblings, 0 replies; 4+ messages in thread
From: Philippe Mathieu-Daudé @ 2022-11-14 8:33 UTC (permalink / raw)
To: Zhenyu Zhang, qemu-devel; +Cc: gshan, imammedo, armbru, eric.auger, lijin
On 14/11/22 04:24, Zhenyu Zhang wrote:
> Commit ffac16fab3 "hostmem: introduce "prealloc-threads" property"
> (v5.0.0) changed the default number of threads from number of CPUs
> to 1. This was deemed a regression, and fixed in commit f8d426a685
> "hostmem: default the amount of prealloc-threads to smp-cpus".
> Except the documentation remained unchanged.
>
> Update 'qapi/qom.json' to reflect the change in commit f8d426a6852c.
>
> Signed-off-by: Zhenyu Zhang <zhenyzha@redhat.com>
> ---
>
> v4: Fix the line exceeding 80 characters limitation issue (Gavin)
> v3: Covers historical descriptions (Markus)
> v2: The property is changed to smp-cpus since 5.0 (Phild)
>
> ---
> qapi/qom.json | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2022-11-15 0:16 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-11-14 3:24 [PATCH v4] qapi/qom: Memory backend property prealloc-threads doc fix Zhenyu Zhang
2022-11-14 5:19 ` Gavin Shan
2022-11-14 7:42 ` Markus Armbruster
2022-11-14 8:33 ` Philippe Mathieu-Daudé
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.