All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Dixit, Ashutosh" <ashutosh.dixit@intel.com>
To: Badal Nilawar <badal.nilawar@intel.com>
Cc: linux-hwmon@vger.kernel.org, andi.shyti@intel.com,
	intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org
Subject: Re: [Intel-gfx] [PATCH 6/7] drm/i915/hwmon: Expose power1_max_interval
Date: Fri, 23 Sep 2022 20:58:40 -0700	[thread overview]
Message-ID: <87o7v58lu7.wl-ashutosh.dixit@intel.com> (raw)
In-Reply-To: <20220923195643.2376927-7-badal.nilawar@intel.com>

On Fri, 23 Sep 2022 12:56:42 -0700, Badal Nilawar wrote:
>
> From: Ashutosh Dixit <ashutosh.dixit@intel.com>
>
> Expose power1_max_interval, that is the tau corresponding to PL1.

I think let's change the above sentence to: "Expose power1_max_interval,
that is the tau corresponding to PL1, as a custom hwmon attribute".

This is the only custom attribute we are exposing so better to mention this
in the commit message I think.

Thanks.
--
Ashutosh

WARNING: multiple messages have this Message-ID (diff)
From: "Dixit, Ashutosh" <ashutosh.dixit@intel.com>
To: Badal Nilawar <badal.nilawar@intel.com>
Cc: <intel-gfx@lists.freedesktop.org>, <riana.tauro@intel.com>,
	<anshuman.gupta@intel.com>, <jon.ewins@intel.com>,
	<linux-hwmon@vger.kernel.org>, <dri-devel@lists.freedesktop.org>,
	<andi.shyti@intel.com>, <tvrtko.ursulin@intel.com>
Subject: Re: [PATCH 6/7] drm/i915/hwmon: Expose power1_max_interval
Date: Fri, 23 Sep 2022 20:58:40 -0700	[thread overview]
Message-ID: <87o7v58lu7.wl-ashutosh.dixit@intel.com> (raw)
In-Reply-To: <20220923195643.2376927-7-badal.nilawar@intel.com>

On Fri, 23 Sep 2022 12:56:42 -0700, Badal Nilawar wrote:
>
> From: Ashutosh Dixit <ashutosh.dixit@intel.com>
>
> Expose power1_max_interval, that is the tau corresponding to PL1.

I think let's change the above sentence to: "Expose power1_max_interval,
that is the tau corresponding to PL1, as a custom hwmon attribute".

This is the only custom attribute we are exposing so better to mention this
in the commit message I think.

Thanks.
--
Ashutosh

WARNING: multiple messages have this Message-ID (diff)
From: "Dixit, Ashutosh" <ashutosh.dixit@intel.com>
To: Badal Nilawar <badal.nilawar@intel.com>
Cc: linux-hwmon@vger.kernel.org, andi.shyti@intel.com,
	tvrtko.ursulin@intel.com, anshuman.gupta@intel.com,
	intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org,
	jon.ewins@intel.com, riana.tauro@intel.com
Subject: Re: [PATCH 6/7] drm/i915/hwmon: Expose power1_max_interval
Date: Fri, 23 Sep 2022 20:58:40 -0700	[thread overview]
Message-ID: <87o7v58lu7.wl-ashutosh.dixit@intel.com> (raw)
In-Reply-To: <20220923195643.2376927-7-badal.nilawar@intel.com>

On Fri, 23 Sep 2022 12:56:42 -0700, Badal Nilawar wrote:
>
> From: Ashutosh Dixit <ashutosh.dixit@intel.com>
>
> Expose power1_max_interval, that is the tau corresponding to PL1.

I think let's change the above sentence to: "Expose power1_max_interval,
that is the tau corresponding to PL1, as a custom hwmon attribute".

This is the only custom attribute we are exposing so better to mention this
in the commit message I think.

Thanks.
--
Ashutosh

  reply	other threads:[~2022-09-24  3:58 UTC|newest]

Thread overview: 55+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-09-23 19:56 [Intel-gfx] [PATCH 0/7] drm/i915: Add HWMON support Badal Nilawar
2022-09-23 19:56 ` Badal Nilawar
2022-09-23 19:56 ` Badal Nilawar
2022-09-23 19:56 ` [Intel-gfx] [PATCH 1/7] drm/i915/hwmon: Add HWMON infrastructure Badal Nilawar
2022-09-23 19:56   ` Badal Nilawar
2022-09-23 19:56   ` Badal Nilawar
2022-09-24  3:54   ` [Intel-gfx] " Dixit, Ashutosh
2022-09-24  3:54     ` Dixit, Ashutosh
2022-09-24  3:54     ` Dixit, Ashutosh
2022-09-23 19:56 ` [Intel-gfx] [PATCH 2/7] drm/i915/hwmon: Add HWMON current voltage support Badal Nilawar
2022-09-23 19:56   ` Badal Nilawar
2022-09-23 19:56   ` Badal Nilawar
2022-09-23 19:56 ` [Intel-gfx] [PATCH 3/7] drm/i915/hwmon: Power PL1 limit and TDP setting Badal Nilawar
2022-09-23 19:56   ` Badal Nilawar
2022-09-23 19:56   ` Badal Nilawar
2022-09-23 19:56 ` [Intel-gfx] [PATCH 4/7] drm/i915/hwmon: Show device level energy usage Badal Nilawar
2022-09-23 19:56   ` Badal Nilawar
2022-09-23 19:56   ` Badal Nilawar
2022-09-24  3:55   ` [Intel-gfx] " Dixit, Ashutosh
2022-09-24  3:55     ` Dixit, Ashutosh
2022-09-24  3:55     ` Dixit, Ashutosh
2022-09-23 19:56 ` [Intel-gfx] [PATCH 5/7] drm/i915/hwmon: Expose card reactive critical power Badal Nilawar
2022-09-23 19:56   ` Badal Nilawar
2022-09-23 19:56   ` Badal Nilawar
2022-09-23 19:56 ` [Intel-gfx] [PATCH 6/7] drm/i915/hwmon: Expose power1_max_interval Badal Nilawar
2022-09-23 19:56   ` Badal Nilawar
2022-09-23 19:56   ` Badal Nilawar
2022-09-24  3:58   ` Dixit, Ashutosh [this message]
2022-09-24  3:58     ` Dixit, Ashutosh
2022-09-24  3:58     ` Dixit, Ashutosh
2022-09-23 19:56 ` [Intel-gfx] [PATCH 7/7] drm/i915/hwmon: Extend power/energy for XEHPSDV Badal Nilawar
2022-09-23 19:56   ` Badal Nilawar
2022-09-23 19:56   ` Badal Nilawar
2022-09-23 21:12 ` [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915: Add HWMON support (rev7) Patchwork
2022-09-23 21:12 ` [Intel-gfx] ✗ Fi.CI.SPARSE: " Patchwork
2022-09-23 21:34 ` [Intel-gfx] ✓ Fi.CI.BAT: success " Patchwork
2022-09-24 13:29 ` [Intel-gfx] ✗ Fi.CI.IGT: failure " Patchwork
  -- strict thread matches above, loose matches on Subject: below --
2022-10-13 15:45 [Intel-gfx] [PATCH 0/7] drm/i915: Add HWMON support Ashutosh Dixit
2022-10-13 15:45 ` [Intel-gfx] [PATCH 6/7] drm/i915/hwmon: Expose power1_max_interval Ashutosh Dixit
2022-09-27  5:50 [Intel-gfx] [PATCH 0/7] drm/i915: Add HWMON support Badal Nilawar
2022-09-27  5:50 ` [Intel-gfx] [PATCH 6/7] drm/i915/hwmon: Expose power1_max_interval Badal Nilawar
2022-09-28  7:09   ` Gupta, Anshuman
2022-10-03 21:32   ` Andi Shyti
2022-10-03 21:32     ` Andi Shyti
2022-10-13 15:55     ` Dixit, Ashutosh
2022-10-13 15:55       ` Dixit, Ashutosh
2022-10-13 15:55       ` Dixit, Ashutosh
2022-09-26 17:52 [Intel-gfx] [PATCH 0/7] Add HWMON support Badal Nilawar
2022-09-26 17:52 ` [Intel-gfx] [PATCH 6/7] drm/i915/hwmon: Expose power1_max_interval Badal Nilawar
2022-09-27 13:54   ` Gupta, Anshuman
2022-09-16 15:00 [Intel-gfx] [PATCH 0/7] drm/i915: Add HWMON support Badal Nilawar
2022-09-16 15:00 ` [Intel-gfx] [PATCH 6/7] drm/i915/hwmon: Expose power1_max_interval Badal Nilawar
2022-09-22  7:13   ` Gupta, Anshuman
2022-09-23  2:51     ` Dixit, Ashutosh
2022-09-23  4:23       ` Dixit, Ashutosh
2022-08-25 13:21 [Intel-gfx] [PATCH 0/7] drm/i915: Add HWMON support Badal Nilawar
2022-08-25 13:21 ` [Intel-gfx] [PATCH 6/7] drm/i915/hwmon: Expose power1_max_interval Badal Nilawar
2022-08-18 19:38 [Intel-gfx] [PATCH 0/7] drm/i915: Add HWMON support Badal Nilawar
2022-08-18 19:39 ` [Intel-gfx] [PATCH 6/7] drm/i915/hwmon: Expose power1_max_interval Badal Nilawar
2022-08-12 17:37 [Intel-gfx] [PATCH 0/7] drm/i915: Add HWMON support Badal Nilawar
2022-08-12 17:37 ` [Intel-gfx] [PATCH 6/7] drm/i915/hwmon: Expose power1_max_interval Badal Nilawar
2022-08-12 18:10   ` Guenter Roeck

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87o7v58lu7.wl-ashutosh.dixit@intel.com \
    --to=ashutosh.dixit@intel.com \
    --cc=andi.shyti@intel.com \
    --cc=badal.nilawar@intel.com \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=intel-gfx@lists.freedesktop.org \
    --cc=linux-hwmon@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.