From: Kalle Valo <kvalo@kernel.org>
To: Jakub Kicinski <kuba@kernel.org>
Cc: davem@davemloft.net, netdev@vger.kernel.org,
luciano.coelho@intel.com, nbd@nbd.name,
lorenzo.bianconi83@gmail.com, ryder.lee@mediatek.com,
shayne.chen@mediatek.com, sean.wang@mediatek.com,
johannes.berg@intel.com, emmanuel.grumbach@intel.com,
ath11k@lists.infradead.org, linux-wireless@vger.kernel.org
Subject: Re: [PATCH net-next 2/2] codel: remove unnecessary pkt_sched.h include
Date: Wed, 22 Dec 2021 07:58:26 +0200 [thread overview]
Message-ID: <87o8592nb1.fsf@kernel.org> (raw)
In-Reply-To: <20211221193941.3805147-2-kuba@kernel.org> (Jakub Kicinski's message of "Tue, 21 Dec 2021 11:39:41 -0800")
Jakub Kicinski <kuba@kernel.org> writes:
> Commit d068ca2ae2e6 ("codel: split into multiple files") moved all
> Qdisc-related code to codel_qdisc.h, move the include of pkt_sched.h
> as well.
>
> This is similar to the previous commit, although we don't care as
> much about incremental builds after pkt_sched.h was touched itself
> it is included by net/sch_generic.h which is modified ~20 times
> a year.
>
> This decreases the incremental build size after touching pkt_sched.h
> from 1592 to 617 objects.
>
> Fix unmasked missing includes in WiFi drivers.
>
> Signed-off-by: Jakub Kicinski <kuba@kernel.org>
> ---
> CC: kvalo@kernel.org
> CC: luciano.coelho@intel.com
> CC: nbd@nbd.name
> CC: lorenzo.bianconi83@gmail.com
> CC: ryder.lee@mediatek.com
> CC: shayne.chen@mediatek.com
> CC: sean.wang@mediatek.com
> CC: johannes.berg@intel.com
> CC: emmanuel.grumbach@intel.com
> CC: ath11k@lists.infradead.org
> CC: linux-wireless@vger.kernel.org
> ---
> drivers/net/wireless/ath/ath11k/reg.c | 2 ++
> drivers/net/wireless/intel/iwlwifi/mvm/ops.c | 1 +
> drivers/net/wireless/intel/iwlwifi/mvm/vendor-cmd.c | 1 +
> drivers/net/wireless/mediatek/mt76/testmode.h | 2 ++
Acked-by: Kalle Valo <kvalo@kernel.org>
--
https://patchwork.kernel.org/project/linux-wireless/list/
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
--
ath11k mailing list
ath11k@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/ath11k
WARNING: multiple messages have this Message-ID (diff)
From: Kalle Valo <kvalo@kernel.org>
To: Jakub Kicinski <kuba@kernel.org>
Cc: davem@davemloft.net, netdev@vger.kernel.org,
luciano.coelho@intel.com, nbd@nbd.name,
lorenzo.bianconi83@gmail.com, ryder.lee@mediatek.com,
shayne.chen@mediatek.com, sean.wang@mediatek.com,
johannes.berg@intel.com, emmanuel.grumbach@intel.com,
ath11k@lists.infradead.org, linux-wireless@vger.kernel.org
Subject: Re: [PATCH net-next 2/2] codel: remove unnecessary pkt_sched.h include
Date: Wed, 22 Dec 2021 07:58:26 +0200 [thread overview]
Message-ID: <87o8592nb1.fsf@kernel.org> (raw)
In-Reply-To: <20211221193941.3805147-2-kuba@kernel.org> (Jakub Kicinski's message of "Tue, 21 Dec 2021 11:39:41 -0800")
Jakub Kicinski <kuba@kernel.org> writes:
> Commit d068ca2ae2e6 ("codel: split into multiple files") moved all
> Qdisc-related code to codel_qdisc.h, move the include of pkt_sched.h
> as well.
>
> This is similar to the previous commit, although we don't care as
> much about incremental builds after pkt_sched.h was touched itself
> it is included by net/sch_generic.h which is modified ~20 times
> a year.
>
> This decreases the incremental build size after touching pkt_sched.h
> from 1592 to 617 objects.
>
> Fix unmasked missing includes in WiFi drivers.
>
> Signed-off-by: Jakub Kicinski <kuba@kernel.org>
> ---
> CC: kvalo@kernel.org
> CC: luciano.coelho@intel.com
> CC: nbd@nbd.name
> CC: lorenzo.bianconi83@gmail.com
> CC: ryder.lee@mediatek.com
> CC: shayne.chen@mediatek.com
> CC: sean.wang@mediatek.com
> CC: johannes.berg@intel.com
> CC: emmanuel.grumbach@intel.com
> CC: ath11k@lists.infradead.org
> CC: linux-wireless@vger.kernel.org
> ---
> drivers/net/wireless/ath/ath11k/reg.c | 2 ++
> drivers/net/wireless/intel/iwlwifi/mvm/ops.c | 1 +
> drivers/net/wireless/intel/iwlwifi/mvm/vendor-cmd.c | 1 +
> drivers/net/wireless/mediatek/mt76/testmode.h | 2 ++
Acked-by: Kalle Valo <kvalo@kernel.org>
--
https://patchwork.kernel.org/project/linux-wireless/list/
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
next prev parent reply other threads:[~2021-12-22 5:58 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-21 19:39 [PATCH net-next 1/2] codel: remove unnecessary sock.h include Jakub Kicinski
2021-12-21 19:39 ` Jakub Kicinski
2021-12-21 19:39 ` [PATCH net-next 2/2] codel: remove unnecessary pkt_sched.h include Jakub Kicinski
2021-12-21 19:39 ` Jakub Kicinski
2021-12-22 5:58 ` Kalle Valo [this message]
2021-12-22 5:58 ` Kalle Valo
2021-12-22 5:56 ` [PATCH net-next 1/2] codel: remove unnecessary sock.h include Kalle Valo
2021-12-22 5:56 ` Kalle Valo
2021-12-23 0:50 ` patchwork-bot+netdevbpf
2021-12-23 0:50 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87o8592nb1.fsf@kernel.org \
--to=kvalo@kernel.org \
--cc=ath11k@lists.infradead.org \
--cc=davem@davemloft.net \
--cc=emmanuel.grumbach@intel.com \
--cc=johannes.berg@intel.com \
--cc=kuba@kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=lorenzo.bianconi83@gmail.com \
--cc=luciano.coelho@intel.com \
--cc=nbd@nbd.name \
--cc=netdev@vger.kernel.org \
--cc=ryder.lee@mediatek.com \
--cc=sean.wang@mediatek.com \
--cc=shayne.chen@mediatek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.