* [PATCH] libselinux/semodule: Improve extracting message
@ 2021-10-04 12:57 Petr Lautrbach
2021-10-04 14:22 ` James Carter
0 siblings, 1 reply; 3+ messages in thread
From: Petr Lautrbach @ 2021-10-04 12:57 UTC (permalink / raw)
To: selinux; +Cc: Petr Lautrbach
The code doesn't check the default priority, it just looks for the
highest.
Fixes:
# semodule -E testmodule
Module 'testmodule' does not exist at the default priority '400'. Extracting at highest existing priority '400'.
Signed-off-by: Petr Lautrbach <plautrba@redhat.com>
---
policycoreutils/semodule/semodule.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/policycoreutils/semodule/semodule.c b/policycoreutils/semodule/semodule.c
index bf9eec02a050..66ea06624eda 100644
--- a/policycoreutils/semodule/semodule.c
+++ b/policycoreutils/semodule/semodule.c
@@ -672,8 +672,7 @@ int main(int argc, char *argv[])
}
semanage_module_info_get_priority(sh, extract_info, &curr_priority);
- printf("Module '%s' does not exist at the default priority '%d'. "
- "Extracting at highest existing priority '%d'.\n", mode_arg, priority, curr_priority);
+ printf("Extracting at highest existing priority '%d'.\n", curr_priority);
priority = curr_priority;
}
--
2.32.0
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] libselinux/semodule: Improve extracting message
2021-10-04 12:57 [PATCH] libselinux/semodule: Improve extracting message Petr Lautrbach
@ 2021-10-04 14:22 ` James Carter
2021-10-06 10:37 ` Petr Lautrbach
0 siblings, 1 reply; 3+ messages in thread
From: James Carter @ 2021-10-04 14:22 UTC (permalink / raw)
To: Petr Lautrbach; +Cc: SElinux list
On Mon, Oct 4, 2021 at 8:59 AM Petr Lautrbach <plautrba@redhat.com> wrote:
>
> The code doesn't check the default priority, it just looks for the
> highest.
>
> Fixes:
>
> # semodule -E testmodule
> Module 'testmodule' does not exist at the default priority '400'. Extracting at highest existing priority '400'.
>
> Signed-off-by: Petr Lautrbach <plautrba@redhat.com>
Acked-by: James Carter <jwcart2@gmail.com>
> ---
> policycoreutils/semodule/semodule.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/policycoreutils/semodule/semodule.c b/policycoreutils/semodule/semodule.c
> index bf9eec02a050..66ea06624eda 100644
> --- a/policycoreutils/semodule/semodule.c
> +++ b/policycoreutils/semodule/semodule.c
> @@ -672,8 +672,7 @@ int main(int argc, char *argv[])
> }
>
> semanage_module_info_get_priority(sh, extract_info, &curr_priority);
> - printf("Module '%s' does not exist at the default priority '%d'. "
> - "Extracting at highest existing priority '%d'.\n", mode_arg, priority, curr_priority);
> + printf("Extracting at highest existing priority '%d'.\n", curr_priority);
> priority = curr_priority;
> }
>
> --
> 2.32.0
>
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] libselinux/semodule: Improve extracting message
2021-10-04 14:22 ` James Carter
@ 2021-10-06 10:37 ` Petr Lautrbach
0 siblings, 0 replies; 3+ messages in thread
From: Petr Lautrbach @ 2021-10-06 10:37 UTC (permalink / raw)
To: SElinux list, James Carter
James Carter <jwcart2@gmail.com> writes:
> On Mon, Oct 4, 2021 at 8:59 AM Petr Lautrbach <plautrba@redhat.com> wrote:
>>
>> The code doesn't check the default priority, it just looks for the
>> highest.
>>
>> Fixes:
>>
>> # semodule -E testmodule
>> Module 'testmodule' does not exist at the default priority '400'. Extracting at highest existing priority '400'.
>>
>> Signed-off-by: Petr Lautrbach <plautrba@redhat.com>
>
> Acked-by: James Carter <jwcart2@gmail.com>
Merged. Thanks!
>> ---
>> policycoreutils/semodule/semodule.c | 3 +--
>> 1 file changed, 1 insertion(+), 2 deletions(-)
>>
>> diff --git a/policycoreutils/semodule/semodule.c b/policycoreutils/semodule/semodule.c
>> index bf9eec02a050..66ea06624eda 100644
>> --- a/policycoreutils/semodule/semodule.c
>> +++ b/policycoreutils/semodule/semodule.c
>> @@ -672,8 +672,7 @@ int main(int argc, char *argv[])
>> }
>>
>> semanage_module_info_get_priority(sh, extract_info, &curr_priority);
>> - printf("Module '%s' does not exist at the default priority '%d'. "
>> - "Extracting at highest existing priority '%d'.\n", mode_arg, priority, curr_priority);
>> + printf("Extracting at highest existing priority '%d'.\n", curr_priority);
>> priority = curr_priority;
>> }
>>
>> --
>> 2.32.0
>>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2021-10-06 10:37 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2021-10-04 12:57 [PATCH] libselinux/semodule: Improve extracting message Petr Lautrbach
2021-10-04 14:22 ` James Carter
2021-10-06 10:37 ` Petr Lautrbach
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.