All of lore.kernel.org
 help / color / mirror / Atom feed
From: Valentin Schneider <valentin.schneider@arm.com>
To: Barry Song <21cnbao@gmail.com>,
	dietmar.eggemann@arm.com, linux-kernel@vger.kernel.org,
	mingo@redhat.com, peterz@infradead.org,
	vincent.guittot@linaro.org
Cc: aubrey.li@linux.intel.com, bp@alien8.de, bristot@redhat.com,
	bsegall@google.com, catalin.marinas@arm.com,
	gregkh@linuxfoundation.org, guodong.xu@linaro.org, hpa@zytor.com,
	jonathan.cameron@huawei.com, juri.lelli@redhat.com,
	lenb@kernel.org, linux-acpi@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org, linuxarm@huawei.com,
	mark.rutland@arm.com, mgorman@suse.de, msys.mizuma@gmail.com,
	prime.zeng@hisilicon.com, rjw@rjwysocki.net, rostedt@goodmis.org,
	song.bao.hua@hisilicon.com, sudeep.holla@arm.com,
	tglx@linutronix.de, rafael@kernel.org,
	tim.c.chen@linux.intel.com, will@kernel.org, x86@kernel.org,
	yangyicong@huawei.com,
	Jonathan Cameron <Jonathan.Cameron@huawei.com>,
	Tian Tao <tiantao6@hisilicon.com>
Subject: Re: [PATCH RESEND 1/3] topology: Represent clusters of CPUs within a die
Date: Tue, 05 Oct 2021 17:33:59 +0100	[thread overview]
Message-ID: <87o883l9c8.mognet@arm.com> (raw)
In-Reply-To: <20210924085104.44806-2-21cnbao@gmail.com>

On 24/09/21 20:51, Barry Song wrote:
>  void update_siblings_masks(unsigned int cpuid)
>  {
>       struct cpu_topology *cpu_topo, *cpuid_topo = &cpu_topology[cpuid];
> @@ -617,6 +622,11 @@ void update_siblings_masks(unsigned int cpuid)
>               if (cpuid_topo->package_id != cpu_topo->package_id)
>                       continue;
>
> +		if (cpuid_topo->cluster_id == cpu_topo->cluster_id) {
> +			cpumask_set_cpu(cpu, &cpuid_topo->cluster_sibling);
> +			cpumask_set_cpu(cpuid, &cpu_topo->cluster_sibling);
> +		}
> +

Hm so without cluster information (e.g. DT system), we have
->cluster_id=-1, we'll essentially copy the package mask into the cluster
mask.

The exposed cluster mask is still <= package mask which is sensible. Are we
fine with that, or do we need/want the mask to be empty in the -1 case? I'm
guessing userspace tools should check for either id!=-1 or if the exclusive
disjucntion of cluster vs package masks is non-empty.

WARNING: multiple messages have this Message-ID (diff)
From: Valentin Schneider <valentin.schneider@arm.com>
To: Barry Song <21cnbao@gmail.com>,
	dietmar.eggemann@arm.com, linux-kernel@vger.kernel.org,
	mingo@redhat.com, peterz@infradead.org,
	vincent.guittot@linaro.org
Cc: aubrey.li@linux.intel.com, bp@alien8.de, bristot@redhat.com,
	bsegall@google.com, catalin.marinas@arm.com,
	gregkh@linuxfoundation.org, guodong.xu@linaro.org, hpa@zytor.com,
	jonathan.cameron@huawei.com, juri.lelli@redhat.com,
	lenb@kernel.org, linux-acpi@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org, linuxarm@huawei.com,
	mark.rutland@arm.com, mgorman@suse.de, msys.mizuma@gmail.com,
	prime.zeng@hisilicon.com, rjw@rjwysocki.net, rostedt@goodmis.org,
	song.bao.hua@hisilicon.com, sudeep.holla@arm.com,
	tglx@linutronix.de, rafael@kernel.org,
	tim.c.chen@linux.intel.com, will@kernel.org, x86@kernel.org,
	yangyicong@huawei.com,
	Jonathan Cameron <Jonathan.Cameron@huawei.com>,
	Tian Tao <tiantao6@hisilicon.com>
Subject: Re: [PATCH RESEND 1/3] topology: Represent clusters of CPUs within a die
Date: Tue, 05 Oct 2021 17:33:59 +0100	[thread overview]
Message-ID: <87o883l9c8.mognet@arm.com> (raw)
In-Reply-To: <20210924085104.44806-2-21cnbao@gmail.com>

On 24/09/21 20:51, Barry Song wrote:
>  void update_siblings_masks(unsigned int cpuid)
>  {
>       struct cpu_topology *cpu_topo, *cpuid_topo = &cpu_topology[cpuid];
> @@ -617,6 +622,11 @@ void update_siblings_masks(unsigned int cpuid)
>               if (cpuid_topo->package_id != cpu_topo->package_id)
>                       continue;
>
> +		if (cpuid_topo->cluster_id == cpu_topo->cluster_id) {
> +			cpumask_set_cpu(cpu, &cpuid_topo->cluster_sibling);
> +			cpumask_set_cpu(cpuid, &cpu_topo->cluster_sibling);
> +		}
> +

Hm so without cluster information (e.g. DT system), we have
->cluster_id=-1, we'll essentially copy the package mask into the cluster
mask.

The exposed cluster mask is still <= package mask which is sensible. Are we
fine with that, or do we need/want the mask to be empty in the -1 case? I'm
guessing userspace tools should check for either id!=-1 or if the exclusive
disjucntion of cluster vs package masks is non-empty.

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

  reply	other threads:[~2021-10-05 16:34 UTC|newest]

Thread overview: 76+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-09-24  8:51 [PATCH RESEND 0/3] Represent cluster topology and enable load balance between clusters Barry Song
2021-09-24  8:51 ` Barry Song
2021-09-24  8:51 ` [PATCH RESEND 1/3] topology: Represent clusters of CPUs within a die Barry Song
2021-09-24  8:51   ` Barry Song
2021-10-05 16:33   ` Valentin Schneider [this message]
2021-10-05 16:33     ` Valentin Schneider
2021-10-05 20:43     ` Barry Song
2021-10-05 20:43       ` Barry Song
2021-10-06 10:50       ` Barry Song
2021-10-06 10:50         ` Barry Song
2021-10-06 12:18         ` Peter Zijlstra
2021-10-06 12:18           ` Peter Zijlstra
2021-10-06 12:50           ` Barry Song
2021-10-06 12:50             ` Barry Song
2021-10-06 13:55             ` Peter Zijlstra
2021-10-06 13:55               ` Peter Zijlstra
2021-10-07 10:30               ` Barry Song
2021-10-07 10:30                 ` Barry Song
2021-10-07 10:35                 ` Peter Zijlstra
2021-10-07 10:35                   ` Peter Zijlstra
2021-10-06 13:49       ` Valentin Schneider
2021-10-06 13:49         ` Valentin Schneider
2021-10-15  9:44   ` [tip: sched/core] " tip-bot2 for Jonathan Cameron
2021-09-24  8:51 ` [PATCH RESEND 2/3] scheduler: Add cluster scheduler level in core and related Kconfig for ARM64 Barry Song
2021-09-24  8:51   ` Barry Song
2021-10-05  7:35   ` Peter Zijlstra
2021-10-05  7:35     ` Peter Zijlstra
2021-10-05  9:01     ` Barry Song
2021-10-05  9:01       ` Barry Song
2021-10-05 10:40       ` Peter Zijlstra
2021-10-05 10:40         ` Peter Zijlstra
2021-09-24  8:51 ` [PATCH RESEND 3/3] scheduler: Add cluster scheduler level for x86 Barry Song
2021-09-24  8:51   ` Barry Song
2021-10-15  9:44   ` [tip: sched/core] sched: " tip-bot2 for Tim Chen
2021-10-20 13:12     ` Tom Lendacky
2021-10-20 19:51       ` Peter Zijlstra
2021-10-20 20:08         ` Tom Lendacky
2021-10-20 20:25           ` Peter Zijlstra
2021-10-20 20:36             ` Peter Zijlstra
2021-10-20 20:40               ` Tom Lendacky
2021-10-20 20:40               ` Peter Zijlstra
2021-10-20 20:51                 ` Tom Lendacky
2021-10-21 10:32                 ` Barry Song
2021-10-21 10:54                   ` Barry Song
2021-10-21 13:22                   ` Peter Zijlstra
2021-10-21 22:23                     ` Song Bao Hua (Barry Song)
2021-10-22 13:31                 ` Tom Lendacky
2021-10-22 13:36                   ` Peter Zijlstra
2021-10-01 10:32 ` [PATCH RESEND 0/3] Represent cluster topology and enable load balance between clusters Barry Song
2021-10-01 10:32   ` Barry Song
2021-10-01 10:39   ` Vincent Guittot
2021-10-01 10:39     ` Vincent Guittot
2021-10-01 14:57     ` Peter Zijlstra
2021-10-01 14:57       ` Peter Zijlstra
2021-10-01 23:22       ` Tim Chen
2021-10-01 23:22         ` Tim Chen
2021-10-02  7:09         ` Barry Song
2021-10-02  7:09           ` Barry Song
2021-10-04 22:54           ` Tim Chen
2021-10-04 22:54             ` Tim Chen
2021-10-05  7:54             ` Peter Zijlstra
2021-10-05  7:54               ` Peter Zijlstra
2021-10-05  8:04           ` Peter Zijlstra
2021-10-05  8:04             ` Peter Zijlstra
2021-10-05  9:06             ` Barry Song
2021-10-05  9:06               ` Barry Song
2021-10-05  7:50         ` Peter Zijlstra
2021-10-05  7:50           ` Peter Zijlstra
2021-10-05  9:15           ` Barry Song
2021-10-05  9:15             ` Barry Song
2021-10-05 10:58             ` Peter Zijlstra
2021-10-05 10:58               ` Peter Zijlstra
2021-10-05 13:42           ` Valentin Schneider
2021-10-05 13:42             ` Valentin Schneider
2021-10-05 13:50             ` Valentin Schneider
2021-10-05 13:50               ` Valentin Schneider

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87o883l9c8.mognet@arm.com \
    --to=valentin.schneider@arm.com \
    --cc=21cnbao@gmail.com \
    --cc=aubrey.li@linux.intel.com \
    --cc=bp@alien8.de \
    --cc=bristot@redhat.com \
    --cc=bsegall@google.com \
    --cc=catalin.marinas@arm.com \
    --cc=dietmar.eggemann@arm.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=guodong.xu@linaro.org \
    --cc=hpa@zytor.com \
    --cc=jonathan.cameron@huawei.com \
    --cc=juri.lelli@redhat.com \
    --cc=lenb@kernel.org \
    --cc=linux-acpi@vger.kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linuxarm@huawei.com \
    --cc=mark.rutland@arm.com \
    --cc=mgorman@suse.de \
    --cc=mingo@redhat.com \
    --cc=msys.mizuma@gmail.com \
    --cc=peterz@infradead.org \
    --cc=prime.zeng@hisilicon.com \
    --cc=rafael@kernel.org \
    --cc=rjw@rjwysocki.net \
    --cc=rostedt@goodmis.org \
    --cc=song.bao.hua@hisilicon.com \
    --cc=sudeep.holla@arm.com \
    --cc=tglx@linutronix.de \
    --cc=tiantao6@hisilicon.com \
    --cc=tim.c.chen@linux.intel.com \
    --cc=vincent.guittot@linaro.org \
    --cc=will@kernel.org \
    --cc=x86@kernel.org \
    --cc=yangyicong@huawei.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.