All of lore.kernel.org
 help / color / mirror / Atom feed
From: Marc Zyngier <maz@kernel.org>
To: <yee.lee@mediatek.com>
Cc: <linux-kernel@vger.kernel.org>, <nicholas.Tang@mediatek.com>,
	<Kuan-Ying.lee@mediatek.com>, <chinwen.chang@mediatek.com>,
	Catalin Marinas <catalin.marinas@arm.com>,
	Will Deacon <will@kernel.org>,
	Matthias Brugger <matthias.bgg@gmail.com>,
	David Brazdil <dbrazdil@google.com>,
	Ard Biesheuvel <ardb@kernel.org>, Fuad Tabba <tabba@google.com>,
	"moderated list:ARM64 PORT (AARCH64 ARCHITECTURE)"
	<linux-arm-kernel@lists.infradead.org>,
	"moderated list:ARM/Mediatek SoC\ support"
	<linux-mediatek@lists.infradead.org>
Subject: Re: [PATCH v2 1/1] arm64/cpufeature: Add arm64.nomte to override id-reg
Date: Thu, 29 Jul 2021 09:47:40 +0100	[thread overview]
Message-ID: <87o8ala4lv.wl-maz@kernel.org> (raw)
In-Reply-To: <20210729020717.15142-2-yee.lee@mediatek.com>

On Thu, 29 Jul 2021 03:07:12 +0100,
<yee.lee@mediatek.com> wrote:
> 
> From: Yee Lee <yee.lee@mediatek.com>
> 
> Add an alias, "arm64.nomte", to override id-reg and

This isn't just an alias. This patch does two things:

- it allows the ID_AA64PFR1_EL1.MTE shadow capability to be set from
  the command line,
- it provides the arm64.nomte alias that sets the above to 0 to
  disable the MTE feature.

> suppress mte feature.

s/mte/MTE/

Maybe also worth indicating *why* this is needed. Possible
justifications include errata workarounds, performance issues... Pick
your own.

> 
> Suggested-by: Marc Zyngier <maz@kernel.org>
> Suggested-by: Suzuki K Poulose <suzuki.poulose@arm.com>
> Signed-off-by: Yee Lee <yee.lee@mediatek.com>
> ---
>  arch/arm64/kernel/idreg-override.c | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/arch/arm64/kernel/idreg-override.c b/arch/arm64/kernel/idreg-override.c
> index 53a381a7f65d..d8e606fe3c21 100644
> --- a/arch/arm64/kernel/idreg-override.c
> +++ b/arch/arm64/kernel/idreg-override.c
> @@ -54,6 +54,7 @@ static const struct ftr_set_desc pfr1 __initconst = {
>  	.override	= &id_aa64pfr1_override,
>  	.fields		= {
>  	        { "bt", ID_AA64PFR1_BT_SHIFT },
> +		{ "mte", ID_AA64PFR1_MTE_SHIFT},
>  		{}
>  	},
>  };
> @@ -100,6 +101,7 @@ static const struct {
>  	{ "arm64.nopauth",
>  	  "id_aa64isar1.gpi=0 id_aa64isar1.gpa=0 "
>  	  "id_aa64isar1.api=0 id_aa64isar1.apa=0"	   },
> +	{ "arm64.nomte",		"id_aa64pfr1.mte=0" },
>  	{ "nokaslr",			"kaslr.disabled=1" },
>  };
>  

This needs to be documented in kernel-parameters.txt. See the nobti
and nopauth options for guidance.

Thanks,

	M.

-- 
Without deviation from the norm, progress is not possible.

_______________________________________________
Linux-mediatek mailing list
Linux-mediatek@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-mediatek

WARNING: multiple messages have this Message-ID (diff)
From: Marc Zyngier <maz@kernel.org>
To: <yee.lee@mediatek.com>
Cc: <linux-kernel@vger.kernel.org>, <nicholas.Tang@mediatek.com>,
	<Kuan-Ying.lee@mediatek.com>, <chinwen.chang@mediatek.com>,
	Catalin Marinas <catalin.marinas@arm.com>,
	Will Deacon <will@kernel.org>,
	Matthias Brugger <matthias.bgg@gmail.com>,
	David Brazdil <dbrazdil@google.com>,
	Ard Biesheuvel <ardb@kernel.org>, Fuad Tabba <tabba@google.com>,
	"moderated list:ARM64 PORT (AARCH64 ARCHITECTURE)"
	<linux-arm-kernel@lists.infradead.org>,
	"moderated list:ARM/Mediatek SoC\ support"
	<linux-mediatek@lists.infradead.org>
Subject: Re: [PATCH v2 1/1] arm64/cpufeature: Add arm64.nomte to override id-reg
Date: Thu, 29 Jul 2021 09:47:40 +0100	[thread overview]
Message-ID: <87o8ala4lv.wl-maz@kernel.org> (raw)
In-Reply-To: <20210729020717.15142-2-yee.lee@mediatek.com>

On Thu, 29 Jul 2021 03:07:12 +0100,
<yee.lee@mediatek.com> wrote:
> 
> From: Yee Lee <yee.lee@mediatek.com>
> 
> Add an alias, "arm64.nomte", to override id-reg and

This isn't just an alias. This patch does two things:

- it allows the ID_AA64PFR1_EL1.MTE shadow capability to be set from
  the command line,
- it provides the arm64.nomte alias that sets the above to 0 to
  disable the MTE feature.

> suppress mte feature.

s/mte/MTE/

Maybe also worth indicating *why* this is needed. Possible
justifications include errata workarounds, performance issues... Pick
your own.

> 
> Suggested-by: Marc Zyngier <maz@kernel.org>
> Suggested-by: Suzuki K Poulose <suzuki.poulose@arm.com>
> Signed-off-by: Yee Lee <yee.lee@mediatek.com>
> ---
>  arch/arm64/kernel/idreg-override.c | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/arch/arm64/kernel/idreg-override.c b/arch/arm64/kernel/idreg-override.c
> index 53a381a7f65d..d8e606fe3c21 100644
> --- a/arch/arm64/kernel/idreg-override.c
> +++ b/arch/arm64/kernel/idreg-override.c
> @@ -54,6 +54,7 @@ static const struct ftr_set_desc pfr1 __initconst = {
>  	.override	= &id_aa64pfr1_override,
>  	.fields		= {
>  	        { "bt", ID_AA64PFR1_BT_SHIFT },
> +		{ "mte", ID_AA64PFR1_MTE_SHIFT},
>  		{}
>  	},
>  };
> @@ -100,6 +101,7 @@ static const struct {
>  	{ "arm64.nopauth",
>  	  "id_aa64isar1.gpi=0 id_aa64isar1.gpa=0 "
>  	  "id_aa64isar1.api=0 id_aa64isar1.apa=0"	   },
> +	{ "arm64.nomte",		"id_aa64pfr1.mte=0" },
>  	{ "nokaslr",			"kaslr.disabled=1" },
>  };
>  

This needs to be documented in kernel-parameters.txt. See the nobti
and nopauth options for guidance.

Thanks,

	M.

-- 
Without deviation from the norm, progress is not possible.

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

  reply	other threads:[~2021-07-29  8:48 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-07-29  2:07 [PATCH v2 0/1] Add option to disable mte support yee.lee
2021-07-29  2:07 ` yee.lee
2021-07-29  2:07 ` yee.lee
2021-07-29  2:07 ` [PATCH v2 1/1] arm64/cpufeature: Add arm64.nomte to override id-reg yee.lee
2021-07-29  2:07   ` yee.lee
2021-07-29  2:07   ` yee.lee
2021-07-29  8:47   ` Marc Zyngier [this message]
2021-07-29  8:47     ` Marc Zyngier

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87o8ala4lv.wl-maz@kernel.org \
    --to=maz@kernel.org \
    --cc=Kuan-Ying.lee@mediatek.com \
    --cc=ardb@kernel.org \
    --cc=catalin.marinas@arm.com \
    --cc=chinwen.chang@mediatek.com \
    --cc=dbrazdil@google.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mediatek@lists.infradead.org \
    --cc=matthias.bgg@gmail.com \
    --cc=nicholas.Tang@mediatek.com \
    --cc=tabba@google.com \
    --cc=will@kernel.org \
    --cc=yee.lee@mediatek.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.