All of lore.kernel.org
 help / color / mirror / Atom feed
* [Intel-gfx] [PATCH CI] drm/i915: Initialize err in remap_io_sg()
@ 2021-05-17 20:21 José Roberto de Souza
  2021-05-17 20:20 ` Souza, Jose
                   ` (2 more replies)
  0 siblings, 3 replies; 7+ messages in thread
From: José Roberto de Souza @ 2021-05-17 20:21 UTC (permalink / raw)
  To: intel-gfx; +Cc: Christoph Hellwig

If the do while loop breaks in 'if (!sg_dma_len(sgl))' in the first
iteration, err is uninitialized causing a wrong call to zap_vma_ptes().

But that is impossible to happen as a scatterlist must have at least
one valid segment.
Anyways to avoid more reports from static checkers initializing ret
here.

Fixes: b12d691ea5e0 ("i915: fix remap_io_sg to verify the pgprot")
Reviewed-by: Christoph Hellwig <hch@lst.de>
Cc: Christoph Hellwig <hch@lst.de>
Signed-off-by: James Ausmus <james.ausmus@intel.com>
Signed-off-by: José Roberto de Souza <jose.souza@intel.com>
---
 drivers/gpu/drm/i915/i915_mm.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/i915/i915_mm.c b/drivers/gpu/drm/i915/i915_mm.c
index 4c8cd08c672d..25576fa73ff0 100644
--- a/drivers/gpu/drm/i915/i915_mm.c
+++ b/drivers/gpu/drm/i915/i915_mm.c
@@ -47,7 +47,7 @@ int remap_io_sg(struct vm_area_struct *vma,
 		struct scatterlist *sgl, resource_size_t iobase)
 {
 	unsigned long pfn, len, remapped = 0;
-	int err;
+	int err = 0;
 
 	/* We rely on prevalidation of the io-mapping to skip track_pfn(). */
 	GEM_BUG_ON((vma->vm_flags & EXPECTED_FLAGS) != EXPECTED_FLAGS);
-- 
2.31.1

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

^ permalink raw reply related	[flat|nested] 7+ messages in thread

end of thread, other threads:[~2021-05-18 18:00 UTC | newest]

Thread overview: 7+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2021-05-17 20:21 [Intel-gfx] [PATCH CI] drm/i915: Initialize err in remap_io_sg() José Roberto de Souza
2021-05-17 20:20 ` Souza, Jose
2021-05-17 20:31   ` Jani Nikula
2021-05-17 21:51     ` Vivi, Rodrigo
2021-05-17 21:42 ` [Intel-gfx] ✓ Fi.CI.BAT: success for " Patchwork
2021-05-18  5:56 ` [Intel-gfx] ✗ Fi.CI.IGT: failure " Patchwork
2021-05-18 18:00   ` Souza, Jose

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.