All of lore.kernel.org
 help / color / mirror / Atom feed
From: Kurt Kanzenbach <kurt@linutronix.de>
To: Florian Fainelli <f.fainelli@gmail.com>,
	Kurt Kanzenbach <kurt@kmk-computers.de>,
	Andrew Lunn <andrew@lunn.ch>,
	Vivien Didelot <vivien.didelot@gmail.com>,
	Vladimir Oltean <olteanv@gmail.com>
Cc: "David S. Miller" <davem@davemloft.net>,
	Jakub Kicinski <kuba@kernel.org>,
	Rob Herring <robh+dt@kernel.org>,
	netdev@vger.kernel.org, devicetree@vger.kernel.org
Subject: Re: [PATCH net-next 1/2] dt-bindings: net: dsa: b53: Add YAML bindings
Date: Mon, 12 Oct 2020 07:45:10 +0200	[thread overview]
Message-ID: <87o8l8f15l.fsf@kurt> (raw)
In-Reply-To: <08c1a0f5-84e1-1c92-2c57-466a28d0346a@gmail.com>

[-- Attachment #1: Type: text/plain, Size: 1063 bytes --]

On Sun Oct 11 2020, Florian Fainelli wrote:
> On 10/11/2020 1:32 AM, Kurt Kanzenbach wrote:
>> How should we proceed? Adding the missing compatible strings and ports
>> to the DTS files? Or adjusting the include files?
>
> The include is correct as it provides the fallback family string which 
> is what the driver will be looking for unless we do not provide a chip 
> compatible. The various DTS should be updated to contain both the chip 
> compatible and the fallback family (brcm,bcm5301x-srab) string, I will 
> update the various DTS and submit these for review later next week.

OK. It's not just the compatible strings, there are other issues as
well. You can check with `make dtbs_check DT_SCHEMA_FILES=path/to/b53.yaml'.

>
> Then we could imagine me taking this YAML change through the Broadcom 
> ARM SoC pull requests that way no new regressions are introduced.
>
> Sounds good?

Sounds like a plan. But, Rob or other device tree maintainers should
have a look at the YAML file to spot issues in there first.

Thanks,
Kurt

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 832 bytes --]

  reply	other threads:[~2020-10-12  5:45 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-10-10 16:46 [PATCH net-next 0/2] dt-bindings: net: dsa: b53: Add YAML bindings Kurt Kanzenbach
2020-10-10 16:46 ` [PATCH net-next 1/2] " Kurt Kanzenbach
2020-10-11  2:28   ` Florian Fainelli
2020-10-11  8:32     ` Kurt Kanzenbach
2020-10-11 15:46       ` Florian Fainelli
2020-10-12  5:45         ` Kurt Kanzenbach [this message]
2020-10-12 18:48           ` Rob Herring
2020-10-10 16:46 ` [PATCH net-next 2/2] dt-bindings: net: dsa: b53: Drop old bindings Kurt Kanzenbach
2020-10-12 18:47   ` Rob Herring
2020-10-15  7:05     ` Kurt Kanzenbach
2020-10-16  2:43       ` Florian Fainelli

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87o8l8f15l.fsf@kurt \
    --to=kurt@linutronix.de \
    --cc=andrew@lunn.ch \
    --cc=davem@davemloft.net \
    --cc=devicetree@vger.kernel.org \
    --cc=f.fainelli@gmail.com \
    --cc=kuba@kernel.org \
    --cc=kurt@kmk-computers.de \
    --cc=netdev@vger.kernel.org \
    --cc=olteanv@gmail.com \
    --cc=robh+dt@kernel.org \
    --cc=vivien.didelot@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.