From: Markus Armbruster <armbru@redhat.com>
To: "Philippe Mathieu-Daudé" <f4bug@amsat.org>
Cc: "Cornelia Huck" <cohuck@redhat.com>,
qemu-devel@nongnu.org, "Cédric Le Goater" <clg@kaod.org>
Subject: Re: [PATCH-for-5.1 v3 2/7] various: Use &error_abort in instance_init()
Date: Wed, 29 Apr 2020 08:12:03 +0200 [thread overview]
Message-ID: <87o8ravn0s.fsf@dusky.pond.sub.org> (raw)
In-Reply-To: <20200413213825.15584-1-f4bug@amsat.org> ("Philippe Mathieu-Daudé"'s message of "Mon, 13 Apr 2020 23:38:25 +0200")
Philippe Mathieu-Daudé <f4bug@amsat.org> writes:
> Patch created mechanically by running:
>
> $ spatch \
> --macro-file scripts/cocci-macro-file.h \
> --include-headers --keep-comments --in-place \
> --sp-file \
> scripts/coccinelle/use-error_abort-in-instance_init.cocci
>
> Reviewed-by: Cédric Le Goater <clg@kaod.org>
> Acked-by: Cornelia Huck <cohuck@redhat.com>
> Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
This one clashes with my "[PATCH 00/17] qom: Spring cleaning". Where
your patch replaces
object_property_add_FOO(..., NULL);
by
object_property_add_FOO(..., &error_abort);
mine drops the parameter outright.
Does not fully replace your patch, which touches other functions, too.
prev parent reply other threads:[~2020-04-29 6:17 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-13 21:38 [PATCH-for-5.1 v3 2/7] various: Use &error_abort in instance_init() Philippe Mathieu-Daudé
2020-04-29 6:12 ` Markus Armbruster [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87o8ravn0s.fsf@dusky.pond.sub.org \
--to=armbru@redhat.com \
--cc=clg@kaod.org \
--cc=cohuck@redhat.com \
--cc=f4bug@amsat.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.