All of lore.kernel.org
 help / color / mirror / Atom feed
From: Juan Quintela <quintela@redhat.com>
To: Keqian Zhu <zhukeqian1@huawei.com>
Cc: qemu-devel@nongnu.org, Markus Armbruster <armbru@redhat.com>,
	qemu-arm@nongnu.org, wanghaibin.wang@huawei.com,
	Eric Blake <eblake@redhat.com>,
	"Dr. David Alan Gilbert" <dgilbert@redhat.com>
Subject: Re: [PATCH] migration/throttle: Make throttle slower at tail stage
Date: Fri, 14 Feb 2020 13:37:53 +0100	[thread overview]
Message-ID: <87o8u1gx9a.fsf@secure.laptop> (raw)
In-Reply-To: <20200214032700.25011-1-zhukeqian1@huawei.com> (Keqian Zhu's message of "Fri, 14 Feb 2020 11:27:00 +0800")

Keqian Zhu <zhukeqian1@huawei.com> wrote:
> At the tail stage of throttle, VM is very sensitive to
> CPU percentage. We just throttle 30% of remaining CPU
> when throttle is more than 80 percentage.

Why?

If we really think that this is better that current approarch, just do
this _always_.  And throothre 30% of remaining CPU.  So we go:

30%
30% + 0.3(70%)
...

Or anything else.

My experience is:
- you really need to go to very high throothle to make migration happens
  (more than 70% or so usually).
- The way that we throotle is not completely exact.

> This doesn't conflict with cpu_throttle_increment.
>
> This may make migration time longer, and is disabled
> by default.


What do you think?
I think that it is better to change method and improve documentation
that yet adding another parameter.

Later, Juan.


WARNING: multiple messages have this Message-ID (diff)
From: Juan Quintela <quintela@redhat.com>
To: Keqian Zhu <zhukeqian1@huawei.com>
Cc: qemu-devel@nongnu.org, Markus Armbruster <armbru@redhat.com>,
	qemu-arm@nongnu.org, wanghaibin.wang@huawei.com,
	"Dr. David Alan Gilbert" <dgilbert@redhat.com>
Subject: Re: [PATCH] migration/throttle: Make throttle slower at tail stage
Date: Fri, 14 Feb 2020 13:37:53 +0100	[thread overview]
Message-ID: <87o8u1gx9a.fsf@secure.laptop> (raw)
In-Reply-To: <20200214032700.25011-1-zhukeqian1@huawei.com> (Keqian Zhu's message of "Fri, 14 Feb 2020 11:27:00 +0800")

Keqian Zhu <zhukeqian1@huawei.com> wrote:
> At the tail stage of throttle, VM is very sensitive to
> CPU percentage. We just throttle 30% of remaining CPU
> when throttle is more than 80 percentage.

Why?

If we really think that this is better that current approarch, just do
this _always_.  And throothre 30% of remaining CPU.  So we go:

30%
30% + 0.3(70%)
...

Or anything else.

My experience is:
- you really need to go to very high throothle to make migration happens
  (more than 70% or so usually).
- The way that we throotle is not completely exact.

> This doesn't conflict with cpu_throttle_increment.
>
> This may make migration time longer, and is disabled
> by default.


What do you think?
I think that it is better to change method and improve documentation
that yet adding another parameter.

Later, Juan.



  parent reply	other threads:[~2020-02-14 12:38 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-02-14  3:27 [PATCH] migration/throttle: Make throttle slower at tail stage Keqian Zhu
2020-02-14  3:27 ` Keqian Zhu
2020-02-14 11:46 ` Eric Blake
2020-02-19  5:34   ` zhukeqian
2020-02-14 12:28 ` Dr. David Alan Gilbert
2020-02-14 12:28   ` Dr. David Alan Gilbert
2020-02-19  5:39   ` zhukeqian
2020-02-19  5:39     ` zhukeqian
2020-02-14 12:37 ` Juan Quintela [this message]
2020-02-14 12:37   ` Juan Quintela
2020-02-19  5:30   ` zhukeqian
2020-02-19  5:30     ` zhukeqian

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87o8u1gx9a.fsf@secure.laptop \
    --to=quintela@redhat.com \
    --cc=armbru@redhat.com \
    --cc=dgilbert@redhat.com \
    --cc=eblake@redhat.com \
    --cc=qemu-arm@nongnu.org \
    --cc=qemu-devel@nongnu.org \
    --cc=wanghaibin.wang@huawei.com \
    --cc=zhukeqian1@huawei.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.