From: "Keith Packard" <keithp@keithp.com>
To: Alistair Francis <alistair23@gmail.com>
Cc: "qemu-devel\@nongnu.org Developers" <qemu-devel@nongnu.org>,
Palmer Dabbelt <palmer@dabbelt.com>,
Alistair Francis <Alistair.Francis@wdc.com>,
Sagar Karandikar <sagark@eecs.berkeley.edu>,
Bastian Koppelmann <kbastian@mail.uni-paderborn.de>,
"open list\:RISC-V" <qemu-riscv@nongnu.org>
Subject: Re: [PATCH] riscv: Separate FPU register size from core register size in gdbstub
Date: Tue, 28 Jan 2020 15:33:28 -0800 [thread overview]
Message-ID: <87o8unrwaf.fsf@keithp.org> (raw)
In-Reply-To: <CAKmqyKOpG1QYD_w1EHEUEs-8J1RAx=k8xMqxRZ5H0nD2N7q_+w@mail.gmail.com>
[-- Attachment #1: Type: text/plain, Size: 295 bytes --]
Alistair Francis <alistair23@gmail.com> writes:
> You need brackets around all if statements, besides that:
Sorry for the noise; I caught that and sent another version of this
patch.
> Reviewed-by: Alistair Francis <alistair.francis@wdc.com>
Thanks for your review!
--
-keith
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 832 bytes --]
WARNING: multiple messages have this Message-ID (diff)
From: "Keith Packard" via <qemu-devel@nongnu.org>
To: Alistair Francis <alistair23@gmail.com>
Cc: "qemu-devel\@nongnu.org Developers" <qemu-devel@nongnu.org>,
Palmer Dabbelt <palmer@dabbelt.com>,
Alistair Francis <Alistair.Francis@wdc.com>,
Sagar Karandikar <sagark@eecs.berkeley.edu>,
Bastian Koppelmann <kbastian@mail.uni-paderborn.de>,
"open list\:RISC-V" <qemu-riscv@nongnu.org>
Subject: Re: [PATCH] riscv: Separate FPU register size from core register size in gdbstub
Date: Tue, 28 Jan 2020 15:33:28 -0800 [thread overview]
Message-ID: <87o8unrwaf.fsf@keithp.org> (raw)
In-Reply-To: <CAKmqyKOpG1QYD_w1EHEUEs-8J1RAx=k8xMqxRZ5H0nD2N7q_+w@mail.gmail.com>
[-- Attachment #1: Type: text/plain, Size: 295 bytes --]
Alistair Francis <alistair23@gmail.com> writes:
> You need brackets around all if statements, besides that:
Sorry for the noise; I caught that and sent another version of this
patch.
> Reviewed-by: Alistair Francis <alistair.francis@wdc.com>
Thanks for your review!
--
-keith
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 832 bytes --]
next prev parent reply other threads:[~2020-01-28 23:47 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-28 22:39 [PATCH] riscv: Separate FPU register size from core register size in gdbstub Keith Packard
2020-01-28 22:39 ` Keith Packard via
2020-01-28 22:46 ` no-reply
2020-01-28 22:46 ` no-reply
2020-01-28 23:27 ` Alistair Francis
2020-01-28 23:27 ` Alistair Francis
2020-01-28 23:33 ` Keith Packard [this message]
2020-01-28 23:33 ` Keith Packard via
2020-01-28 23:37 ` no-reply
2020-01-28 23:37 ` no-reply
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87o8unrwaf.fsf@keithp.org \
--to=keithp@keithp.com \
--cc=Alistair.Francis@wdc.com \
--cc=alistair23@gmail.com \
--cc=kbastian@mail.uni-paderborn.de \
--cc=palmer@dabbelt.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-riscv@nongnu.org \
--cc=sagark@eecs.berkeley.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.