All of lore.kernel.org
 help / color / mirror / Atom feed
From: Eric Anholt <eric@anholt.net>
To: dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org
Cc: Eben Upton <eben@raspberrypi.org>,
	Maxime Ripard <maxime.ripard@bootlin.com>,
	Paul Kocialkowski <paul.kocialkowski@bootlin.com>,
	David Airlie <airlied@linux.ie>,
	Thomas Petazzoni <thomas.petazzoni@bootlin.com>,
	Sean Paul <sean@poorly.run>
Subject: Re: [PATCH 3/3] drm/vc4: Don't liberate the binner BO at runtime suspend
Date: Sat, 16 Mar 2019 11:58:55 -0700	[thread overview]
Message-ID: <87o96alk7k.fsf@anholt.net> (raw)
In-Reply-To: <20190315162538.4120-3-paul.kocialkowski@bootlin.com>


[-- Attachment #1.1: Type: text/plain, Size: 770 bytes --]

Paul Kocialkowski <paul.kocialkowski@bootlin.com> writes:

> The binner BO is a pre-requisite to GPU operations, so we must ensure
> that it is always allocated when the GPU is in use.
>
> Because the buffer is allocated from the same pool as other GPU buffers,
> we might run into a situation where we are out of memory at runtime
> resume. This causes the binner BO allocation to fail and results in all
> subsequent operations to fail, resulting in a major hang in userspace.
>
> Now that we allocate the buffer at firstopen and liberate it at
> lastclose, we can just keep it alive during runtime suspend.

I think this needs to be squashed into the previous patch, as otherwise
coming from suspended, a firstopen -> resume -> render will leak a copy
of the bin BO.

[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 832 bytes --]

[-- Attachment #2: Type: text/plain, Size: 159 bytes --]

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

WARNING: multiple messages have this Message-ID (diff)
From: Eric Anholt <eric@anholt.net>
To: Paul Kocialkowski <paul.kocialkowski@bootlin.com>,
	dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org
Cc: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>,
	Maxime Ripard <maxime.ripard@bootlin.com>,
	Sean Paul <sean@poorly.run>, David Airlie <airlied@linux.ie>,
	Daniel Vetter <daniel@ffwll.ch>,
	Thomas Petazzoni <thomas.petazzoni@bootlin.com>,
	Eben Upton <eben@raspberrypi.org>,
	Paul Kocialkowski <paul.kocialkowski@bootlin.com>
Subject: Re: [PATCH 3/3] drm/vc4: Don't liberate the binner BO at runtime suspend
Date: Sat, 16 Mar 2019 11:58:55 -0700	[thread overview]
Message-ID: <87o96alk7k.fsf@anholt.net> (raw)
In-Reply-To: <20190315162538.4120-3-paul.kocialkowski@bootlin.com>

[-- Attachment #1: Type: text/plain, Size: 770 bytes --]

Paul Kocialkowski <paul.kocialkowski@bootlin.com> writes:

> The binner BO is a pre-requisite to GPU operations, so we must ensure
> that it is always allocated when the GPU is in use.
>
> Because the buffer is allocated from the same pool as other GPU buffers,
> we might run into a situation where we are out of memory at runtime
> resume. This causes the binner BO allocation to fail and results in all
> subsequent operations to fail, resulting in a major hang in userspace.
>
> Now that we allocate the buffer at firstopen and liberate it at
> lastclose, we can just keep it alive during runtime suspend.

I think this needs to be squashed into the previous patch, as otherwise
coming from suspended, a firstopen -> resume -> render will leak a copy
of the bin BO.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 832 bytes --]

  reply	other threads:[~2019-03-16 18:58 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-03-15 16:25 [PATCH 1/3] drm/file: Rehabilitate the firstopen hook for non-legacy drivers Paul Kocialkowski
2019-03-15 16:25 ` [PATCH 2/3] drm/vc4: Allocate/liberate the binner BO at firstopen/lastclose Paul Kocialkowski
2019-03-15 16:25 ` [PATCH 3/3] drm/vc4: Don't liberate the binner BO at runtime suspend Paul Kocialkowski
2019-03-16 18:58   ` Eric Anholt [this message]
2019-03-16 18:58     ` Eric Anholt
2019-03-20 15:17     ` Paul Kocialkowski
2019-03-20 15:17       ` Paul Kocialkowski

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87o96alk7k.fsf@anholt.net \
    --to=eric@anholt.net \
    --cc=airlied@linux.ie \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=eben@raspberrypi.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=maxime.ripard@bootlin.com \
    --cc=paul.kocialkowski@bootlin.com \
    --cc=sean@poorly.run \
    --cc=thomas.petazzoni@bootlin.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.