Re: [PATCH] drm/i915/execlists: Add a GEM_TRACE to show when the context is completed

From: Mika Kuoppala <mika.kuoppala@linux.intel.com>
To: Chris Wilson <chris@chris-wilson.co.uk>, intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH] drm/i915/execlists: Add a GEM_TRACE to show when the context is completed
Date: Wed, 21 Feb 2018 17:21:04 +0200	[thread overview]
Message-ID: <87o9kis71b.fsf@gaia.fi.intel.com> (raw)
In-Reply-To: <20180221151553.9054-1-chris@chris-wilson.co.uk>

Chris Wilson <chris@chris-wilson.co.uk> writes:

> Include a GEM_TRACE to show when the context is complete and we advance
> the ELSP port.
>
> Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
> Cc: Mika Kuoppala <mika.kuoppala@linux.intel.com>
> ---
>  drivers/gpu/drm/i915/intel_lrc.c | 3 +++
>  1 file changed, 3 insertions(+)
>
> diff --git a/drivers/gpu/drm/i915/intel_lrc.c b/drivers/gpu/drm/i915/intel_lrc.c
> index 9b6d781b22ec..fe5a0fa3f3b6 100644
> --- a/drivers/gpu/drm/i915/intel_lrc.c
> +++ b/drivers/gpu/drm/i915/intel_lrc.c
> @@ -890,6 +890,9 @@ static void execlists_submission_tasklet(unsigned long data)
>  				trace_i915_gem_request_out(rq);
>  				i915_gem_request_put(rq);
>  
> +				GEM_TRACE("%s completed ctx=%d\n",
> +					  engine->name, port->context_id);
> +

There is a trace above with a count so info is already there,
and could be amended to output completion if count == 1.

But the code is correct so if you really need it,
Reviewed-by: Mika Kuoppala <mika.kuoppala@linux.intel.com>

>  				execlists_port_complete(execlists, port);
>  			} else {
>  				port_set(port, port_pack(rq, count));
> -- 
> 2.16.1
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx