* [PATCH] drm/i915/execlists: Add a GEM_TRACE to show when the context is completed
@ 2018-02-21 15:15 Chris Wilson
2018-02-21 15:21 ` Mika Kuoppala
` (2 more replies)
0 siblings, 3 replies; 6+ messages in thread
From: Chris Wilson @ 2018-02-21 15:15 UTC (permalink / raw)
To: intel-gfx
Include a GEM_TRACE to show when the context is complete and we advance
the ELSP port.
Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
Cc: Mika Kuoppala <mika.kuoppala@linux.intel.com>
---
drivers/gpu/drm/i915/intel_lrc.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/drivers/gpu/drm/i915/intel_lrc.c b/drivers/gpu/drm/i915/intel_lrc.c
index 9b6d781b22ec..fe5a0fa3f3b6 100644
--- a/drivers/gpu/drm/i915/intel_lrc.c
+++ b/drivers/gpu/drm/i915/intel_lrc.c
@@ -890,6 +890,9 @@ static void execlists_submission_tasklet(unsigned long data)
trace_i915_gem_request_out(rq);
i915_gem_request_put(rq);
+ GEM_TRACE("%s completed ctx=%d\n",
+ engine->name, port->context_id);
+
execlists_port_complete(execlists, port);
} else {
port_set(port, port_pack(rq, count));
--
2.16.1
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH] drm/i915/execlists: Add a GEM_TRACE to show when the context is completed
2018-02-21 15:15 [PATCH] drm/i915/execlists: Add a GEM_TRACE to show when the context is completed Chris Wilson
@ 2018-02-21 15:21 ` Mika Kuoppala
2018-02-21 15:36 ` Chris Wilson
2018-02-21 15:47 ` ✓ Fi.CI.BAT: success for " Patchwork
2018-02-21 19:44 ` ✓ Fi.CI.IGT: " Patchwork
2 siblings, 1 reply; 6+ messages in thread
From: Mika Kuoppala @ 2018-02-21 15:21 UTC (permalink / raw)
To: Chris Wilson, intel-gfx
Chris Wilson <chris@chris-wilson.co.uk> writes:
> Include a GEM_TRACE to show when the context is complete and we advance
> the ELSP port.
>
> Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
> Cc: Mika Kuoppala <mika.kuoppala@linux.intel.com>
> ---
> drivers/gpu/drm/i915/intel_lrc.c | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/drivers/gpu/drm/i915/intel_lrc.c b/drivers/gpu/drm/i915/intel_lrc.c
> index 9b6d781b22ec..fe5a0fa3f3b6 100644
> --- a/drivers/gpu/drm/i915/intel_lrc.c
> +++ b/drivers/gpu/drm/i915/intel_lrc.c
> @@ -890,6 +890,9 @@ static void execlists_submission_tasklet(unsigned long data)
> trace_i915_gem_request_out(rq);
> i915_gem_request_put(rq);
>
> + GEM_TRACE("%s completed ctx=%d\n",
> + engine->name, port->context_id);
> +
There is a trace above with a count so info is already there,
and could be amended to output completion if count == 1.
But the code is correct so if you really need it,
Reviewed-by: Mika Kuoppala <mika.kuoppala@linux.intel.com>
> execlists_port_complete(execlists, port);
> } else {
> port_set(port, port_pack(rq, count));
> --
> 2.16.1
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] drm/i915/execlists: Add a GEM_TRACE to show when the context is completed
2018-02-21 15:21 ` Mika Kuoppala
@ 2018-02-21 15:36 ` Chris Wilson
2018-02-22 8:50 ` Mika Kuoppala
0 siblings, 1 reply; 6+ messages in thread
From: Chris Wilson @ 2018-02-21 15:36 UTC (permalink / raw)
To: Mika Kuoppala, intel-gfx
Quoting Mika Kuoppala (2018-02-21 15:21:04)
> Chris Wilson <chris@chris-wilson.co.uk> writes:
>
> > Include a GEM_TRACE to show when the context is complete and we advance
> > the ELSP port.
> >
> > Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
> > Cc: Mika Kuoppala <mika.kuoppala@linux.intel.com>
> > ---
> > drivers/gpu/drm/i915/intel_lrc.c | 3 +++
> > 1 file changed, 3 insertions(+)
> >
> > diff --git a/drivers/gpu/drm/i915/intel_lrc.c b/drivers/gpu/drm/i915/intel_lrc.c
> > index 9b6d781b22ec..fe5a0fa3f3b6 100644
> > --- a/drivers/gpu/drm/i915/intel_lrc.c
> > +++ b/drivers/gpu/drm/i915/intel_lrc.c
> > @@ -890,6 +890,9 @@ static void execlists_submission_tasklet(unsigned long data)
> > trace_i915_gem_request_out(rq);
> > i915_gem_request_put(rq);
> >
> > + GEM_TRACE("%s completed ctx=%d\n",
> > + engine->name, port->context_id);
> > +
>
> There is a trace above with a count so info is already there,
> and could be amended to output completion if count == 1.
But that assumes we don't add a bug in between. :)
What I was thinking was that we really wanted to show the port
advancement here, but not quite sure what to show. This gives us a clear
marker for something to search for that doesn't require us to know that
when count==1 we expect it to complete. Sometimes I like going easy on
myself.
-Chris
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 6+ messages in thread
* ✓ Fi.CI.BAT: success for drm/i915/execlists: Add a GEM_TRACE to show when the context is completed
2018-02-21 15:15 [PATCH] drm/i915/execlists: Add a GEM_TRACE to show when the context is completed Chris Wilson
2018-02-21 15:21 ` Mika Kuoppala
@ 2018-02-21 15:47 ` Patchwork
2018-02-21 19:44 ` ✓ Fi.CI.IGT: " Patchwork
2 siblings, 0 replies; 6+ messages in thread
From: Patchwork @ 2018-02-21 15:47 UTC (permalink / raw)
To: Chris Wilson; +Cc: intel-gfx
== Series Details ==
Series: drm/i915/execlists: Add a GEM_TRACE to show when the context is completed
URL : https://patchwork.freedesktop.org/series/38707/
State : success
== Summary ==
Series 38707v1 drm/i915/execlists: Add a GEM_TRACE to show when the context is completed
https://patchwork.freedesktop.org/api/1.0/series/38707/revisions/1/mbox/
Test gem_mmap_gtt:
Subgroup basic-small-bo-tiledx:
pass -> FAIL (fi-gdg-551) fdo#102575
Test kms_pipe_crc_basic:
Subgroup suspend-read-crc-pipe-a:
fail -> PASS (fi-ivb-3520m)
Subgroup suspend-read-crc-pipe-b:
incomplete -> PASS (fi-snb-2520m) fdo#103713
fail -> PASS (fi-ivb-3520m)
Subgroup suspend-read-crc-pipe-c:
fail -> PASS (fi-ivb-3520m)
fdo#102575 https://bugs.freedesktop.org/show_bug.cgi?id=102575
fdo#103713 https://bugs.freedesktop.org/show_bug.cgi?id=103713
fi-bdw-5557u total:288 pass:267 dwarn:0 dfail:0 fail:0 skip:21 time:415s
fi-bdw-gvtdvm total:288 pass:264 dwarn:0 dfail:0 fail:0 skip:24 time:424s
fi-blb-e6850 total:288 pass:223 dwarn:1 dfail:0 fail:0 skip:64 time:376s
fi-bsw-n3050 total:288 pass:242 dwarn:0 dfail:0 fail:0 skip:46 time:485s
fi-bwr-2160 total:288 pass:183 dwarn:0 dfail:0 fail:0 skip:105 time:286s
fi-bxt-dsi total:288 pass:258 dwarn:0 dfail:0 fail:0 skip:30 time:476s
fi-bxt-j4205 total:288 pass:259 dwarn:0 dfail:0 fail:0 skip:29 time:483s
fi-byt-j1900 total:288 pass:253 dwarn:0 dfail:0 fail:0 skip:35 time:469s
fi-byt-n2820 total:288 pass:249 dwarn:0 dfail:0 fail:0 skip:39 time:456s
fi-cfl-s2 total:288 pass:262 dwarn:0 dfail:0 fail:0 skip:26 time:567s
fi-elk-e7500 total:288 pass:229 dwarn:0 dfail:0 fail:0 skip:59 time:414s
fi-gdg-551 total:288 pass:179 dwarn:0 dfail:0 fail:1 skip:108 time:285s
fi-glk-1 total:288 pass:260 dwarn:0 dfail:0 fail:0 skip:28 time:508s
fi-hsw-4770 total:288 pass:261 dwarn:0 dfail:0 fail:0 skip:27 time:386s
fi-ilk-650 total:288 pass:228 dwarn:0 dfail:0 fail:0 skip:60 time:408s
fi-ivb-3520m total:288 pass:259 dwarn:0 dfail:0 fail:0 skip:29 time:455s
fi-ivb-3770 total:288 pass:255 dwarn:0 dfail:0 fail:0 skip:33 time:409s
fi-kbl-7500u total:288 pass:263 dwarn:1 dfail:0 fail:0 skip:24 time:453s
fi-kbl-7560u total:288 pass:269 dwarn:0 dfail:0 fail:0 skip:19 time:496s
fi-kbl-7567u total:288 pass:268 dwarn:0 dfail:0 fail:0 skip:20 time:448s
fi-kbl-r total:288 pass:261 dwarn:0 dfail:0 fail:0 skip:27 time:491s
fi-pnv-d510 total:288 pass:222 dwarn:1 dfail:0 fail:0 skip:65 time:589s
fi-skl-6260u total:288 pass:268 dwarn:0 dfail:0 fail:0 skip:20 time:428s
fi-skl-6600u total:288 pass:261 dwarn:0 dfail:0 fail:0 skip:27 time:502s
fi-skl-6700hq total:288 pass:262 dwarn:0 dfail:0 fail:0 skip:26 time:522s
fi-skl-6700k2 total:288 pass:264 dwarn:0 dfail:0 fail:0 skip:24 time:487s
fi-skl-6770hq total:288 pass:268 dwarn:0 dfail:0 fail:0 skip:20 time:481s
fi-skl-guc total:288 pass:260 dwarn:0 dfail:0 fail:0 skip:28 time:414s
fi-skl-gvtdvm total:288 pass:265 dwarn:0 dfail:0 fail:0 skip:23 time:429s
fi-snb-2520m total:288 pass:248 dwarn:0 dfail:0 fail:0 skip:40 time:528s
fi-snb-2600 total:288 pass:248 dwarn:0 dfail:0 fail:0 skip:40 time:391s
42d073db2a8593a8d1832037ffe0988403031568 drm-tip: 2018y-02m-21d-14h-03m-58s UTC integration manifest
3da4cebce364 drm/i915/execlists: Add a GEM_TRACE to show when the context is completed
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_8106/issues.html
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 6+ messages in thread
* ✓ Fi.CI.IGT: success for drm/i915/execlists: Add a GEM_TRACE to show when the context is completed
2018-02-21 15:15 [PATCH] drm/i915/execlists: Add a GEM_TRACE to show when the context is completed Chris Wilson
2018-02-21 15:21 ` Mika Kuoppala
2018-02-21 15:47 ` ✓ Fi.CI.BAT: success for " Patchwork
@ 2018-02-21 19:44 ` Patchwork
2 siblings, 0 replies; 6+ messages in thread
From: Patchwork @ 2018-02-21 19:44 UTC (permalink / raw)
To: Chris Wilson; +Cc: intel-gfx
== Series Details ==
Series: drm/i915/execlists: Add a GEM_TRACE to show when the context is completed
URL : https://patchwork.freedesktop.org/series/38707/
State : success
== Summary ==
Test kms_atomic_transition:
Subgroup 1x-modeset-transitions-nonblocking-fencing:
fail -> PASS (shard-apl) fdo#103207
Test kms_flip:
Subgroup plain-flip-ts-check-interruptible:
fail -> PASS (shard-hsw) fdo#100368 +2
Test kms_plane_multiple:
Subgroup legacy-pipe-b-tiling-none:
skip -> PASS (shard-snb)
Test kms_vblank:
Subgroup pipe-b-wait-busy-hang:
skip -> PASS (shard-snb)
Test kms_pipe_crc_basic:
Subgroup read-crc-pipe-c-frame-sequence:
fail -> PASS (shard-apl) fdo#103481
Test kms_sysfs_edid_timing:
pass -> WARN (shard-apl) fdo#100047
Test gem_eio:
Subgroup in-flight:
incomplete -> PASS (shard-apl)
fdo#103207 https://bugs.freedesktop.org/show_bug.cgi?id=103207
fdo#100368 https://bugs.freedesktop.org/show_bug.cgi?id=100368
fdo#103481 https://bugs.freedesktop.org/show_bug.cgi?id=103481
fdo#100047 https://bugs.freedesktop.org/show_bug.cgi?id=100047
shard-apl total:3369 pass:1764 dwarn:1 dfail:0 fail:13 skip:1589 time:12067s
shard-hsw total:3464 pass:1766 dwarn:1 dfail:0 fail:3 skip:1693 time:11853s
shard-snb total:3464 pass:1356 dwarn:1 dfail:0 fail:3 skip:2104 time:6699s
Blacklisted hosts:
shard-kbl total:3464 pass:1962 dwarn:1 dfail:0 fail:14 skip:1487 time:9662s
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_8106/shards.html
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] drm/i915/execlists: Add a GEM_TRACE to show when the context is completed
2018-02-21 15:36 ` Chris Wilson
@ 2018-02-22 8:50 ` Mika Kuoppala
0 siblings, 0 replies; 6+ messages in thread
From: Mika Kuoppala @ 2018-02-22 8:50 UTC (permalink / raw)
To: Chris Wilson, intel-gfx
Chris Wilson <chris@chris-wilson.co.uk> writes:
> Quoting Mika Kuoppala (2018-02-21 15:21:04)
>> Chris Wilson <chris@chris-wilson.co.uk> writes:
>>
>> > Include a GEM_TRACE to show when the context is complete and we advance
>> > the ELSP port.
>> >
>> > Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
>> > Cc: Mika Kuoppala <mika.kuoppala@linux.intel.com>
>> > ---
>> > drivers/gpu/drm/i915/intel_lrc.c | 3 +++
>> > 1 file changed, 3 insertions(+)
>> >
>> > diff --git a/drivers/gpu/drm/i915/intel_lrc.c b/drivers/gpu/drm/i915/intel_lrc.c
>> > index 9b6d781b22ec..fe5a0fa3f3b6 100644
>> > --- a/drivers/gpu/drm/i915/intel_lrc.c
>> > +++ b/drivers/gpu/drm/i915/intel_lrc.c
>> > @@ -890,6 +890,9 @@ static void execlists_submission_tasklet(unsigned long data)
>> > trace_i915_gem_request_out(rq);
>> > i915_gem_request_put(rq);
>> >
>> > + GEM_TRACE("%s completed ctx=%d\n",
>> > + engine->name, port->context_id);
>> > +
>>
>> There is a trace above with a count so info is already there,
>> and could be amended to output completion if count == 1.
>
> But that assumes we don't add a bug in between. :)
>
> What I was thinking was that we really wanted to show the port
> advancement here, but not quite sure what to show. This gives us a clear
> marker for something to search for that doesn't require us to know that
> when count==1 we expect it to complete. Sometimes I like going easy on
> myself.
Agreed on here. It is hard enough to decode interactions
in the logs so being explicit and clear always helps.
-Mika
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2018-02-22 8:53 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-02-21 15:15 [PATCH] drm/i915/execlists: Add a GEM_TRACE to show when the context is completed Chris Wilson
2018-02-21 15:21 ` Mika Kuoppala
2018-02-21 15:36 ` Chris Wilson
2018-02-22 8:50 ` Mika Kuoppala
2018-02-21 15:47 ` ✓ Fi.CI.BAT: success for " Patchwork
2018-02-21 19:44 ` ✓ Fi.CI.IGT: " Patchwork
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.