From: Markus Armbruster <armbru@redhat.com>
To: Paolo Bonzini <pbonzini@redhat.com>
Cc: Eduardo Habkost <ehabkost@redhat.com>, qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH v3 3/3] coccinelle: Remove unnecessary variables for function return value
Date: Tue, 14 Jun 2016 13:20:14 +0200 [thread overview]
Message-ID: <87oa74f24x.fsf@dusky.pond.sub.org> (raw)
In-Reply-To: <a9bac517-fc4a-1220-e05d-e9e0de512ef8@redhat.com> (Paolo Bonzini's message of "Tue, 14 Jun 2016 11:11:42 +0200")
Paolo Bonzini <pbonzini@redhat.com> writes:
> On 14/06/2016 10:57, Markus Armbruster wrote:
>>> diff --git a/scripts/coccinelle/return_directly.cocci b/scripts/coccinelle/return_directly.cocci
>>> > new file mode 100644
>>> > index 0000000..c52f4fc
>>> > --- /dev/null
>>> > +++ b/scripts/coccinelle/return_directly.cocci
>>> > @@ -0,0 +1,21 @@
>>> > +// replace 'R = X; return R;' with 'return R;'
>>> > +
>>> > +// remove assignment
>> Second comment feels redundant. Can drop on commit to error-next.
>>
>>> > +@ removal @
>> Rule name "removal" is not used. Can drop on commit to error-next.
>>
>
> I've seen rule names used as a comment. Feels a bit like COBOL, but it
> doesn't hurt. Perhaps rename it to "@ return_directly @"?
No objection. However, the existing semantic patches in
scripts/coccinelle/ don't do that. You guys tell me what to do with
this one.
next prev parent reply other threads:[~2016-06-14 11:20 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-13 21:57 [Qemu-devel] [PATCH v3 0/3] coccinelle: Clean up error checks and return value variables Eduardo Habkost
2016-06-13 21:57 ` [Qemu-devel] [PATCH v3 1/3] error: Remove NULL checks on error_propagate() calls Eduardo Habkost
2016-06-13 21:57 ` [Qemu-devel] [PATCH v3 2/3] error: Remove unnecessary local_err variables Eduardo Habkost
2016-06-13 23:06 ` Eric Blake
2016-06-14 8:49 ` Markus Armbruster
2016-06-13 21:57 ` [Qemu-devel] [PATCH v3 3/3] coccinelle: Remove unnecessary variables for function return value Eduardo Habkost
2016-06-14 8:57 ` Markus Armbruster
2016-06-14 9:11 ` Paolo Bonzini
2016-06-14 11:20 ` Markus Armbruster [this message]
2016-06-14 11:58 ` Eduardo Habkost
2016-06-14 11:20 ` Eduardo Habkost
2016-06-14 9:03 ` [Qemu-devel] [PATCH v3 0/3] coccinelle: Clean up error checks and return value variables Markus Armbruster
2016-06-14 17:45 ` Markus Armbruster
2016-06-14 17:46 ` Eduardo Habkost
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87oa74f24x.fsf@dusky.pond.sub.org \
--to=armbru@redhat.com \
--cc=ehabkost@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.