* [PATCH] drm/i915: Fix NULL pointer deference when out of PLLs in IVB
@ 2016-05-20 12:47 Ander Conselvan de Oliveira
2016-05-20 13:39 ` ✗ Ro.CI.BAT: failure for " Patchwork
` (4 more replies)
0 siblings, 5 replies; 7+ messages in thread
From: Ander Conselvan de Oliveira @ 2016-05-20 12:47 UTC (permalink / raw)
To: intel-gfx; +Cc: Ander Conselvan de Oliveira
In commit f9476a6c6d0c ("drm/i915: Refactor platform specifics out of
intel_get_shared_dpll()"), the ibx_get_dpll() function lacked an error
check, that can lead to a NULL pointer dereference when trying to enable
pipe C.
BUG: unable to handle kernel NULL pointer dereference at 0000000000000068
IP: [<ffffffffa0482275>] intel_reference_shared_dpll+0x15/0x100 [i915]
PGD cec87067 PUD d30ce067 PMD 0
Oops: 0000 [#1] PREEMPT SMP
Modules linked in: snd_hda_intel i915 drm_kms_helper drm intel_gtt sch_fq_codel cfg80211 binfmt_misc i2c_algo_bit cfbfillrect syscopyarea cfbimgblt sysfillrect sysimgblt fb_sys_fops cfbcopyarea intel_rapl iosf_mbi x86_pkg_temp_thermal coretemp agpgart kvm_intel snd_hda_codec_hdmi kvm iTCO_wdt snd_hda_codec_realtek snd_hda_codec_generic irqbypass aesni_intel aes_x86_64 glue_helper lrw gf128mul ablk_helper cryptd psmouse pcspkr snd_hda_codec i2c_i801 snd_hwdep snd_hda_core snd_pcm snd_timer lpc_ich mfd_core snd soundcore wmi evdev tpm_tis tpm [last unloaded: drm]
CPU: 3 PID: 5810 Comm: kms_flip Tainted: G U W 4.6.0-test+ #3
Hardware name: /DZ77BH-55K, BIOS BHZ7710H.86A.0100.2013.0517.0942 05/17/2013
task: ffff8800d3908040 ti: ffff8801166c8000 task.ti: ffff8801166c8000
RIP: 0010:[<ffffffffa0482275>] [<ffffffffa0482275>] intel_reference_shared_dpll+0x15/0x100 [i915]
RSP: 0018:ffff8801166cba60 EFLAGS: 00010246
RAX: 0000000000000000 RBX: 0000000000000000 RCX: 0000000000000002
RDX: 0000000000000001 RSI: ffff8800d07f1bf8 RDI: 0000000000000000
RBP: ffff8801166cba88 R08: 0000000000000002 R09: ffff8800d32e5698
R10: 0000000000000001 R11: ffff8800cc89ac88 R12: ffff8800d07f1bf8
R13: 0000000000000000 R14: 0000000000000000 R15: 0000000000000000
FS: 00007f4c3fc8d8c0(0000) GS:ffff88011bcc0000(0000) knlGS:0000000000000000
CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033
CR2: 0000000000000068 CR3: 00000000d3b4c000 CR4: 00000000001406e0
Stack:
0000000000000000 ffff8800d07f1bf8 0000000000000000 ffff8800d04c0000
0000000000000000 ffff8801166cbaa8 ffffffffa04823a7 ffff8800d07f1bf8
ffff8800d32e5698 ffff8801166cbab8 ffffffffa04840cf ffff8801166cbaf0
Call Trace:
[<ffffffffa04823a7>] ibx_get_dpll+0x47/0xa0 [i915]
[<ffffffffa04840cf>] intel_get_shared_dpll+0x1f/0x50 [i915]
[<ffffffffa046d080>] ironlake_crtc_compute_clock+0x280/0x430 [i915]
[<ffffffffa0472ac0>] intel_crtc_atomic_check+0x240/0x320 [i915]
[<ffffffffa03da18e>] drm_atomic_helper_check_planes+0x14e/0x1d0 [drm_kms_helper]
[<ffffffffa0474a0c>] intel_atomic_check+0x5dc/0x1110 [i915]
[<ffffffffa029d3aa>] drm_atomic_check_only+0x14a/0x660 [drm]
[<ffffffffa029d086>] ? drm_atomic_set_crtc_for_connector+0x96/0x100 [drm]
[<ffffffffa029d8d7>] drm_atomic_commit+0x17/0x60 [drm]
[<ffffffffa03dc3b7>] restore_fbdev_mode+0x237/0x260 [drm_kms_helper]
[<ffffffffa029c65a>] ? drm_modeset_lock_all_ctx+0x9a/0xb0 [drm]
[<ffffffffa03de9b3>] drm_fb_helper_restore_fbdev_mode_unlocked+0x33/0x80 [drm_kms_helper]
[<ffffffffa03dea2d>] drm_fb_helper_set_par+0x2d/0x50 [drm_kms_helper]
[<ffffffffa03de93a>] drm_fb_helper_hotplug_event+0xaa/0xf0 [drm_kms_helper]
[<ffffffffa03de9d6>] drm_fb_helper_restore_fbdev_mode_unlocked+0x56/0x80 [drm_kms_helper]
[<ffffffffa0490f72>] intel_fbdev_restore_mode+0x22/0x80 [i915]
[<ffffffffa04ba45e>] i915_driver_lastclose+0xe/0x20 [i915]
[<ffffffffa02810de>] drm_lastclose+0x2e/0x130 [drm]
[<ffffffffa028148c>] drm_release+0x2ac/0x4b0 [drm]
[<ffffffff811a6b2d>] __fput+0xed/0x1f0
[<ffffffff811a6c6e>] ____fput+0xe/0x10
[<ffffffff81079156>] task_work_run+0x76/0xb0
[<ffffffff8105aaab>] do_exit+0x3ab/0xc60
[<ffffffff810a145f>] ? trace_hardirqs_on_caller+0x12f/0x1c0
[<ffffffff8105c67e>] do_group_exit+0x4e/0xc0
[<ffffffff8105c704>] SyS_exit_group+0x14/0x20
[<ffffffff8158bb25>] entry_SYSCALL_64_fastpath+0x18/0xa8
Code: 14 80 48 8d 34 90 b8 01 00 00 00 d3 e0 09 04 b3 5b 41 5c 5d c3 90 0f 1f 44 00 00 55 48 89 e5 41 57 41 56 49 89 fe 41 55 41 54 53 <44> 8b 67 68 48 89 f3 48 8b be 08 02 00 00 4c 8b 2e e8 15 9d fd
RIP [<ffffffffa0482275>] intel_reference_shared_dpll+0x15/0x100 [i915]
RSP <ffff8801166cba60>
CR2: 0000000000000068
Cc: Ville Syrjälä <ville.syrjala@linux.intel.com>
Reported-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
Fixes: f9476a6c6d0c ("drm/i915: Refactor platform specifics out of intel_get_shared_dpll()")
Signed-off-by: Ander Conselvan de Oliveira <ander.conselvan.de.oliveira@intel.com>
---
drivers/gpu/drm/i915/intel_dpll_mgr.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/drivers/gpu/drm/i915/intel_dpll_mgr.c b/drivers/gpu/drm/i915/intel_dpll_mgr.c
index f988adb..1e3d091 100644
--- a/drivers/gpu/drm/i915/intel_dpll_mgr.c
+++ b/drivers/gpu/drm/i915/intel_dpll_mgr.c
@@ -366,6 +366,9 @@ ibx_get_dpll(struct intel_crtc *crtc, struct intel_crtc_state *crtc_state,
DPLL_ID_PCH_PLL_B);
}
+ if (!pll)
+ return NULL;
+
/* reference the pll */
intel_reference_shared_dpll(pll, crtc_state);
--
2.5.5
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply related [flat|nested] 7+ messages in thread* ✗ Ro.CI.BAT: failure for drm/i915: Fix NULL pointer deference when out of PLLs in IVB
2016-05-20 12:47 [PATCH] drm/i915: Fix NULL pointer deference when out of PLLs in IVB Ander Conselvan de Oliveira
@ 2016-05-20 13:39 ` Patchwork
2016-05-20 17:13 ` [PATCH] " Ville Syrjälä
` (3 subsequent siblings)
4 siblings, 0 replies; 7+ messages in thread
From: Patchwork @ 2016-05-20 13:39 UTC (permalink / raw)
To: Ander Conselvan de Oliveira; +Cc: intel-gfx
== Series Details ==
Series: drm/i915: Fix NULL pointer deference when out of PLLs in IVB
URL : https://patchwork.freedesktop.org/series/7458/
State : failure
== Summary ==
Series 7458v1 drm/i915: Fix NULL pointer deference when out of PLLs in IVB
http://patchwork.freedesktop.org/api/1.0/series/7458/revisions/1/mbox
Test drv_hangman:
Subgroup error-state-basic:
pass -> INCOMPLETE (fi-snb-i7-2600)
Test gem_exec_flush:
Subgroup basic-batch-kernel-default-cmd:
fail -> PASS (fi-byt-n2820)
Test kms_flip:
Subgroup basic-flip-vs-wf_vblank:
fail -> PASS (ro-bdw-i7-5600u)
Test kms_force_connector_basic:
Subgroup force-connector-state:
skip -> PASS (ro-ivb2-i7-3770)
Subgroup force-edid:
skip -> PASS (ro-ivb2-i7-3770)
Subgroup prune-stale-modes:
skip -> PASS (ro-ivb2-i7-3770)
fi-bdw-i7-5557u total:217 pass:204 dwarn:0 dfail:0 fail:0 skip:13
fi-bsw-n3050 total:216 pass:172 dwarn:0 dfail:0 fail:2 skip:42
fi-byt-n2820 total:216 pass:173 dwarn:0 dfail:0 fail:2 skip:41
fi-hsw-i7-4770k total:217 pass:195 dwarn:0 dfail:0 fail:0 skip:22
fi-hsw-i7-4770r total:217 pass:191 dwarn:0 dfail:0 fail:0 skip:26
fi-skl-i7-6700k total:217 pass:189 dwarn:0 dfail:0 fail:0 skip:28
fi-snb-i7-2600 total:36 pass:27 dwarn:0 dfail:0 fail:0 skip:8
ro-bdw-i5-5250u total:209 pass:171 dwarn:0 dfail:0 fail:0 skip:38
ro-bdw-i7-5557U total:209 pass:196 dwarn:0 dfail:0 fail:0 skip:13
ro-bdw-i7-5600u total:209 pass:179 dwarn:0 dfail:0 fail:1 skip:29
ro-bsw-n3050 total:209 pass:167 dwarn:0 dfail:0 fail:2 skip:40
ro-byt-n2820 total:209 pass:168 dwarn:0 dfail:0 fail:3 skip:38
ro-hsw-i3-4010u total:209 pass:186 dwarn:0 dfail:0 fail:0 skip:23
ro-hsw-i7-4770r total:209 pass:185 dwarn:0 dfail:0 fail:0 skip:24
ro-ilk1-i5-650 total:204 pass:146 dwarn:0 dfail:0 fail:1 skip:57
ro-ivb-i7-3770 total:209 pass:176 dwarn:0 dfail:0 fail:0 skip:33
ro-ivb2-i7-3770 total:209 pass:180 dwarn:0 dfail:0 fail:0 skip:29
ro-skl-i7-6700hq total:204 pass:182 dwarn:0 dfail:0 fail:0 skip:22
ro-snb-i7-2620M total:209 pass:170 dwarn:0 dfail:0 fail:1 skip:38
Results at /archive/results/CI_IGT_test/RO_Patchwork_951/
019aa31 drm-intel-nightly: 2016y-05m-20d-12h-47m-05s UTC integration manifest
8aba6f6c drm/i915: Fix NULL pointer deference when out of PLLs in IVB
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 7+ messages in thread* Re: [PATCH] drm/i915: Fix NULL pointer deference when out of PLLs in IVB
2016-05-20 12:47 [PATCH] drm/i915: Fix NULL pointer deference when out of PLLs in IVB Ander Conselvan de Oliveira
2016-05-20 13:39 ` ✗ Ro.CI.BAT: failure for " Patchwork
@ 2016-05-20 17:13 ` Ville Syrjälä
2016-05-23 8:42 ` Jani Nikula
` (2 subsequent siblings)
4 siblings, 0 replies; 7+ messages in thread
From: Ville Syrjälä @ 2016-05-20 17:13 UTC (permalink / raw)
To: Ander Conselvan de Oliveira; +Cc: intel-gfx
On Fri, May 20, 2016 at 03:47:06PM +0300, Ander Conselvan de Oliveira wrote:
> In commit f9476a6c6d0c ("drm/i915: Refactor platform specifics out of
> intel_get_shared_dpll()"), the ibx_get_dpll() function lacked an error
> check, that can lead to a NULL pointer dereference when trying to enable
> pipe C.
s/pipe C/three pipes/
>
> BUG: unable to handle kernel NULL pointer dereference at 0000000000000068
> IP: [<ffffffffa0482275>] intel_reference_shared_dpll+0x15/0x100 [i915]
> PGD cec87067 PUD d30ce067 PMD 0
> Oops: 0000 [#1] PREEMPT SMP
> Modules linked in: snd_hda_intel i915 drm_kms_helper drm intel_gtt sch_fq_codel cfg80211 binfmt_misc i2c_algo_bit cfbfillrect syscopyarea cfbimgblt sysfillrect sysimgblt fb_sys_fops cfbcopyarea intel_rapl iosf_mbi x86_pkg_temp_thermal coretemp agpgart kvm_intel snd_hda_codec_hdmi kvm iTCO_wdt snd_hda_codec_realtek snd_hda_codec_generic irqbypass aesni_intel aes_x86_64 glue_helper lrw gf128mul ablk_helper cryptd psmouse pcspkr snd_hda_codec i2c_i801 snd_hwdep snd_hda_core snd_pcm snd_timer lpc_ich mfd_core snd soundcore wmi evdev tpm_tis tpm [last unloaded: drm]
> CPU: 3 PID: 5810 Comm: kms_flip Tainted: G U W 4.6.0-test+ #3
> Hardware name: /DZ77BH-55K, BIOS BHZ7710H.86A.0100.2013.0517.0942 05/17/2013
> task: ffff8800d3908040 ti: ffff8801166c8000 task.ti: ffff8801166c8000
> RIP: 0010:[<ffffffffa0482275>] [<ffffffffa0482275>] intel_reference_shared_dpll+0x15/0x100 [i915]
> RSP: 0018:ffff8801166cba60 EFLAGS: 00010246
> RAX: 0000000000000000 RBX: 0000000000000000 RCX: 0000000000000002
> RDX: 0000000000000001 RSI: ffff8800d07f1bf8 RDI: 0000000000000000
> RBP: ffff8801166cba88 R08: 0000000000000002 R09: ffff8800d32e5698
> R10: 0000000000000001 R11: ffff8800cc89ac88 R12: ffff8800d07f1bf8
> R13: 0000000000000000 R14: 0000000000000000 R15: 0000000000000000
> FS: 00007f4c3fc8d8c0(0000) GS:ffff88011bcc0000(0000) knlGS:0000000000000000
> CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033
> CR2: 0000000000000068 CR3: 00000000d3b4c000 CR4: 00000000001406e0
> Stack:
> 0000000000000000 ffff8800d07f1bf8 0000000000000000 ffff8800d04c0000
> 0000000000000000 ffff8801166cbaa8 ffffffffa04823a7 ffff8800d07f1bf8
> ffff8800d32e5698 ffff8801166cbab8 ffffffffa04840cf ffff8801166cbaf0
> Call Trace:
> [<ffffffffa04823a7>] ibx_get_dpll+0x47/0xa0 [i915]
> [<ffffffffa04840cf>] intel_get_shared_dpll+0x1f/0x50 [i915]
> [<ffffffffa046d080>] ironlake_crtc_compute_clock+0x280/0x430 [i915]
> [<ffffffffa0472ac0>] intel_crtc_atomic_check+0x240/0x320 [i915]
> [<ffffffffa03da18e>] drm_atomic_helper_check_planes+0x14e/0x1d0 [drm_kms_helper]
> [<ffffffffa0474a0c>] intel_atomic_check+0x5dc/0x1110 [i915]
> [<ffffffffa029d3aa>] drm_atomic_check_only+0x14a/0x660 [drm]
> [<ffffffffa029d086>] ? drm_atomic_set_crtc_for_connector+0x96/0x100 [drm]
> [<ffffffffa029d8d7>] drm_atomic_commit+0x17/0x60 [drm]
> [<ffffffffa03dc3b7>] restore_fbdev_mode+0x237/0x260 [drm_kms_helper]
> [<ffffffffa029c65a>] ? drm_modeset_lock_all_ctx+0x9a/0xb0 [drm]
> [<ffffffffa03de9b3>] drm_fb_helper_restore_fbdev_mode_unlocked+0x33/0x80 [drm_kms_helper]
> [<ffffffffa03dea2d>] drm_fb_helper_set_par+0x2d/0x50 [drm_kms_helper]
> [<ffffffffa03de93a>] drm_fb_helper_hotplug_event+0xaa/0xf0 [drm_kms_helper]
> [<ffffffffa03de9d6>] drm_fb_helper_restore_fbdev_mode_unlocked+0x56/0x80 [drm_kms_helper]
> [<ffffffffa0490f72>] intel_fbdev_restore_mode+0x22/0x80 [i915]
> [<ffffffffa04ba45e>] i915_driver_lastclose+0xe/0x20 [i915]
> [<ffffffffa02810de>] drm_lastclose+0x2e/0x130 [drm]
> [<ffffffffa028148c>] drm_release+0x2ac/0x4b0 [drm]
> [<ffffffff811a6b2d>] __fput+0xed/0x1f0
> [<ffffffff811a6c6e>] ____fput+0xe/0x10
> [<ffffffff81079156>] task_work_run+0x76/0xb0
> [<ffffffff8105aaab>] do_exit+0x3ab/0xc60
> [<ffffffff810a145f>] ? trace_hardirqs_on_caller+0x12f/0x1c0
> [<ffffffff8105c67e>] do_group_exit+0x4e/0xc0
> [<ffffffff8105c704>] SyS_exit_group+0x14/0x20
> [<ffffffff8158bb25>] entry_SYSCALL_64_fastpath+0x18/0xa8
> Code: 14 80 48 8d 34 90 b8 01 00 00 00 d3 e0 09 04 b3 5b 41 5c 5d c3 90 0f 1f 44 00 00 55 48 89 e5 41 57 41 56 49 89 fe 41 55 41 54 53 <44> 8b 67 68 48 89 f3 48 8b be 08 02 00 00 4c 8b 2e e8 15 9d fd
> RIP [<ffffffffa0482275>] intel_reference_shared_dpll+0x15/0x100 [i915]
> RSP <ffff8801166cba60>
> CR2: 0000000000000068
>
> Cc: Ville Syrjälä <ville.syrjala@linux.intel.com>
> Reported-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
> Fixes: f9476a6c6d0c ("drm/i915: Refactor platform specifics out of intel_get_shared_dpll()")
> Signed-off-by: Ander Conselvan de Oliveira <ander.conselvan.de.oliveira@intel.com>
Reviewed-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
Tested-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
> ---
> drivers/gpu/drm/i915/intel_dpll_mgr.c | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/drivers/gpu/drm/i915/intel_dpll_mgr.c b/drivers/gpu/drm/i915/intel_dpll_mgr.c
> index f988adb..1e3d091 100644
> --- a/drivers/gpu/drm/i915/intel_dpll_mgr.c
> +++ b/drivers/gpu/drm/i915/intel_dpll_mgr.c
> @@ -366,6 +366,9 @@ ibx_get_dpll(struct intel_crtc *crtc, struct intel_crtc_state *crtc_state,
> DPLL_ID_PCH_PLL_B);
> }
>
> + if (!pll)
> + return NULL;
> +
> /* reference the pll */
> intel_reference_shared_dpll(pll, crtc_state);
>
> --
> 2.5.5
--
Ville Syrjälä
Intel OTC
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 7+ messages in thread* Re: [PATCH] drm/i915: Fix NULL pointer deference when out of PLLs in IVB
2016-05-20 12:47 [PATCH] drm/i915: Fix NULL pointer deference when out of PLLs in IVB Ander Conselvan de Oliveira
2016-05-20 13:39 ` ✗ Ro.CI.BAT: failure for " Patchwork
2016-05-20 17:13 ` [PATCH] " Ville Syrjälä
@ 2016-05-23 8:42 ` Jani Nikula
2016-05-23 16:51 ` ✗ Ro.CI.BAT: failure for " Patchwork
2016-05-24 7:00 ` Patchwork
4 siblings, 0 replies; 7+ messages in thread
From: Jani Nikula @ 2016-05-23 8:42 UTC (permalink / raw)
To: intel-gfx; +Cc: Ander Conselvan de Oliveira
On Fri, 20 May 2016, Ander Conselvan de Oliveira <ander.conselvan.de.oliveira@intel.com> wrote:
> In commit f9476a6c6d0c ("drm/i915: Refactor platform specifics out of
> intel_get_shared_dpll()"), the ibx_get_dpll() function lacked an error
> check, that can lead to a NULL pointer dereference when trying to enable
> pipe C.
>
> BUG: unable to handle kernel NULL pointer dereference at 0000000000000068
> IP: [<ffffffffa0482275>] intel_reference_shared_dpll+0x15/0x100 [i915]
> PGD cec87067 PUD d30ce067 PMD 0
> Oops: 0000 [#1] PREEMPT SMP
> Modules linked in: snd_hda_intel i915 drm_kms_helper drm intel_gtt sch_fq_codel cfg80211 binfmt_misc i2c_algo_bit cfbfillrect syscopyarea cfbimgblt sysfillrect sysimgblt fb_sys_fops cfbcopyarea intel_rapl iosf_mbi x86_pkg_temp_thermal coretemp agpgart kvm_intel snd_hda_codec_hdmi kvm iTCO_wdt snd_hda_codec_realtek snd_hda_codec_generic irqbypass aesni_intel aes_x86_64 glue_helper lrw gf128mul ablk_helper cryptd psmouse pcspkr snd_hda_codec i2c_i801 snd_hwdep snd_hda_core snd_pcm snd_timer lpc_ich mfd_core snd soundcore wmi evdev tpm_tis tpm [last unloaded: drm]
> CPU: 3 PID: 5810 Comm: kms_flip Tainted: G U W 4.6.0-test+ #3
> Hardware name: /DZ77BH-55K, BIOS BHZ7710H.86A.0100.2013.0517.0942 05/17/2013
> task: ffff8800d3908040 ti: ffff8801166c8000 task.ti: ffff8801166c8000
> RIP: 0010:[<ffffffffa0482275>] [<ffffffffa0482275>] intel_reference_shared_dpll+0x15/0x100 [i915]
> RSP: 0018:ffff8801166cba60 EFLAGS: 00010246
> RAX: 0000000000000000 RBX: 0000000000000000 RCX: 0000000000000002
> RDX: 0000000000000001 RSI: ffff8800d07f1bf8 RDI: 0000000000000000
> RBP: ffff8801166cba88 R08: 0000000000000002 R09: ffff8800d32e5698
> R10: 0000000000000001 R11: ffff8800cc89ac88 R12: ffff8800d07f1bf8
> R13: 0000000000000000 R14: 0000000000000000 R15: 0000000000000000
> FS: 00007f4c3fc8d8c0(0000) GS:ffff88011bcc0000(0000) knlGS:0000000000000000
> CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033
> CR2: 0000000000000068 CR3: 00000000d3b4c000 CR4: 00000000001406e0
> Stack:
> 0000000000000000 ffff8800d07f1bf8 0000000000000000 ffff8800d04c0000
> 0000000000000000 ffff8801166cbaa8 ffffffffa04823a7 ffff8800d07f1bf8
> ffff8800d32e5698 ffff8801166cbab8 ffffffffa04840cf ffff8801166cbaf0
> Call Trace:
> [<ffffffffa04823a7>] ibx_get_dpll+0x47/0xa0 [i915]
> [<ffffffffa04840cf>] intel_get_shared_dpll+0x1f/0x50 [i915]
> [<ffffffffa046d080>] ironlake_crtc_compute_clock+0x280/0x430 [i915]
> [<ffffffffa0472ac0>] intel_crtc_atomic_check+0x240/0x320 [i915]
> [<ffffffffa03da18e>] drm_atomic_helper_check_planes+0x14e/0x1d0 [drm_kms_helper]
> [<ffffffffa0474a0c>] intel_atomic_check+0x5dc/0x1110 [i915]
> [<ffffffffa029d3aa>] drm_atomic_check_only+0x14a/0x660 [drm]
> [<ffffffffa029d086>] ? drm_atomic_set_crtc_for_connector+0x96/0x100 [drm]
> [<ffffffffa029d8d7>] drm_atomic_commit+0x17/0x60 [drm]
> [<ffffffffa03dc3b7>] restore_fbdev_mode+0x237/0x260 [drm_kms_helper]
> [<ffffffffa029c65a>] ? drm_modeset_lock_all_ctx+0x9a/0xb0 [drm]
> [<ffffffffa03de9b3>] drm_fb_helper_restore_fbdev_mode_unlocked+0x33/0x80 [drm_kms_helper]
> [<ffffffffa03dea2d>] drm_fb_helper_set_par+0x2d/0x50 [drm_kms_helper]
> [<ffffffffa03de93a>] drm_fb_helper_hotplug_event+0xaa/0xf0 [drm_kms_helper]
> [<ffffffffa03de9d6>] drm_fb_helper_restore_fbdev_mode_unlocked+0x56/0x80 [drm_kms_helper]
> [<ffffffffa0490f72>] intel_fbdev_restore_mode+0x22/0x80 [i915]
> [<ffffffffa04ba45e>] i915_driver_lastclose+0xe/0x20 [i915]
> [<ffffffffa02810de>] drm_lastclose+0x2e/0x130 [drm]
> [<ffffffffa028148c>] drm_release+0x2ac/0x4b0 [drm]
> [<ffffffff811a6b2d>] __fput+0xed/0x1f0
> [<ffffffff811a6c6e>] ____fput+0xe/0x10
> [<ffffffff81079156>] task_work_run+0x76/0xb0
> [<ffffffff8105aaab>] do_exit+0x3ab/0xc60
> [<ffffffff810a145f>] ? trace_hardirqs_on_caller+0x12f/0x1c0
> [<ffffffff8105c67e>] do_group_exit+0x4e/0xc0
> [<ffffffff8105c704>] SyS_exit_group+0x14/0x20
> [<ffffffff8158bb25>] entry_SYSCALL_64_fastpath+0x18/0xa8
> Code: 14 80 48 8d 34 90 b8 01 00 00 00 d3 e0 09 04 b3 5b 41 5c 5d c3 90 0f 1f 44 00 00 55 48 89 e5 41 57 41 56 49 89 fe 41 55 41 54 53 <44> 8b 67 68 48 89 f3 48 8b be 08 02 00 00 4c 8b 2e e8 15 9d fd
> RIP [<ffffffffa0482275>] intel_reference_shared_dpll+0x15/0x100 [i915]
> RSP <ffff8801166cba60>
> CR2: 0000000000000068
>
> Cc: Ville Syrjälä <ville.syrjala@linux.intel.com>
> Reported-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
> Fixes: f9476a6c6d0c ("drm/i915: Refactor platform specifics out of intel_get_shared_dpll()")
The scripts are dim, and don't yet handle a lone Fixes: line. Please
also add the relevant Cc. In this case,
$ dim fixes f9476a6c6d0c
Fixes: f9476a6c6d0c ("drm/i915: Refactor platform specifics out of intel_get_shared_dpll()")
Cc: drm-intel-fixes@lists.freedesktop.org
> Signed-off-by: Ander Conselvan de Oliveira <ander.conselvan.de.oliveira@intel.com>
> ---
> drivers/gpu/drm/i915/intel_dpll_mgr.c | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/drivers/gpu/drm/i915/intel_dpll_mgr.c b/drivers/gpu/drm/i915/intel_dpll_mgr.c
> index f988adb..1e3d091 100644
> --- a/drivers/gpu/drm/i915/intel_dpll_mgr.c
> +++ b/drivers/gpu/drm/i915/intel_dpll_mgr.c
> @@ -366,6 +366,9 @@ ibx_get_dpll(struct intel_crtc *crtc, struct intel_crtc_state *crtc_state,
> DPLL_ID_PCH_PLL_B);
> }
>
> + if (!pll)
> + return NULL;
> +
> /* reference the pll */
> intel_reference_shared_dpll(pll, crtc_state);
--
Jani Nikula, Intel Open Source Technology Center
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 7+ messages in thread* ✗ Ro.CI.BAT: failure for drm/i915: Fix NULL pointer deference when out of PLLs in IVB
2016-05-20 12:47 [PATCH] drm/i915: Fix NULL pointer deference when out of PLLs in IVB Ander Conselvan de Oliveira
` (2 preceding siblings ...)
2016-05-23 8:42 ` Jani Nikula
@ 2016-05-23 16:51 ` Patchwork
2016-05-24 7:00 ` Patchwork
4 siblings, 0 replies; 7+ messages in thread
From: Patchwork @ 2016-05-23 16:51 UTC (permalink / raw)
To: Ander Conselvan de Oliveira; +Cc: intel-gfx
== Series Details ==
Series: drm/i915: Fix NULL pointer deference when out of PLLs in IVB
URL : https://patchwork.freedesktop.org/series/7458/
State : failure
== Summary ==
Series 7458v1 drm/i915: Fix NULL pointer deference when out of PLLs in IVB
http://patchwork.freedesktop.org/api/1.0/series/7458/revisions/1/mbox
Test kms_pipe_crc_basic:
Subgroup suspend-read-crc-pipe-a:
pass -> INCOMPLETE (fi-hsw-i7-4770k)
fi-bdw-i7-5557u total:209 pass:197 dwarn:0 dfail:0 fail:0 skip:12
fi-bsw-n3050 total:209 pass:167 dwarn:0 dfail:0 fail:2 skip:40
fi-byt-n2820 total:209 pass:169 dwarn:0 dfail:0 fail:2 skip:38
fi-hsw-i7-4770k total:184 pass:166 dwarn:0 dfail:0 fail:0 skip:17
fi-hsw-i7-4770r total:209 pass:186 dwarn:0 dfail:0 fail:0 skip:23
fi-skl-i5-6260u total:209 pass:196 dwarn:2 dfail:0 fail:0 skip:11
fi-skl-i7-6700k total:209 pass:182 dwarn:2 dfail:0 fail:0 skip:25
fi-snb-i7-2600 total:209 pass:170 dwarn:0 dfail:0 fail:0 skip:39
ro-bdw-i5-5250u total:209 pass:172 dwarn:0 dfail:0 fail:0 skip:37
ro-bdw-i7-5557U total:209 pass:197 dwarn:0 dfail:0 fail:0 skip:12
ro-bdw-i7-5600u total:209 pass:180 dwarn:0 dfail:0 fail:1 skip:28
ro-bsw-n3050 total:209 pass:168 dwarn:0 dfail:0 fail:2 skip:39
ro-byt-n2820 total:209 pass:169 dwarn:0 dfail:0 fail:3 skip:37
ro-hsw-i3-4010u total:209 pass:186 dwarn:0 dfail:0 fail:0 skip:23
ro-hsw-i7-4770r total:209 pass:186 dwarn:0 dfail:0 fail:0 skip:23
ro-ilk-i7-620lm total:209 pass:146 dwarn:0 dfail:0 fail:1 skip:62
ro-ilk1-i5-650 total:204 pass:146 dwarn:0 dfail:0 fail:1 skip:57
ro-ivb-i7-3770 total:209 pass:177 dwarn:0 dfail:0 fail:0 skip:32
ro-ivb2-i7-3770 total:209 pass:181 dwarn:0 dfail:0 fail:0 skip:28
ro-skl-i7-6700hq total:204 pass:181 dwarn:2 dfail:0 fail:0 skip:21
ro-snb-i7-2620M total:209 pass:170 dwarn:0 dfail:0 fail:1 skip:38
Results at /archive/results/CI_IGT_test/RO_Patchwork_979/
facf329 drm-intel-nightly: 2016y-05m-23d-15h-31m-43s UTC integration manifest
b214df4 drm/i915: Fix NULL pointer deference when out of PLLs in IVB
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 7+ messages in thread* ✗ Ro.CI.BAT: failure for drm/i915: Fix NULL pointer deference when out of PLLs in IVB
2016-05-20 12:47 [PATCH] drm/i915: Fix NULL pointer deference when out of PLLs in IVB Ander Conselvan de Oliveira
` (3 preceding siblings ...)
2016-05-23 16:51 ` ✗ Ro.CI.BAT: failure for " Patchwork
@ 2016-05-24 7:00 ` Patchwork
2016-05-26 12:23 ` Ander Conselvan De Oliveira
4 siblings, 1 reply; 7+ messages in thread
From: Patchwork @ 2016-05-24 7:00 UTC (permalink / raw)
To: Ander Conselvan de Oliveira; +Cc: intel-gfx
== Series Details ==
Series: drm/i915: Fix NULL pointer deference when out of PLLs in IVB
URL : https://patchwork.freedesktop.org/series/7458/
State : failure
== Summary ==
Series 7458v1 drm/i915: Fix NULL pointer deference when out of PLLs in IVB
http://patchwork.freedesktop.org/api/1.0/series/7458/revisions/1/mbox
Test gem_busy:
Subgroup basic-parallel-blt:
pass -> DMESG-WARN (ro-skl-i7-6700hq)
Subgroup basic-parallel-vebox:
dmesg-warn -> PASS (ro-skl-i7-6700hq)
Test gem_ringfill:
Subgroup basic-default:
pass -> DMESG-WARN (ro-skl-i7-6700hq)
Subgroup basic-default-interruptible:
dmesg-warn -> PASS (ro-skl-i7-6700hq)
Test gem_storedw_loop:
Subgroup basic-default:
pass -> INCOMPLETE (ro-byt-n2820)
dmesg-warn -> PASS (ro-skl-i7-6700hq)
Test kms_frontbuffer_tracking:
Subgroup basic:
pass -> DMESG-WARN (ro-skl-i7-6700hq)
Test kms_pipe_crc_basic:
Subgroup bad-pipe:
dmesg-warn -> PASS (ro-skl-i7-6700hq)
Subgroup bad-source:
pass -> DMESG-WARN (ro-skl-i7-6700hq)
Test kms_setmode:
Subgroup basic-clone-single-crtc:
pass -> DMESG-WARN (ro-skl-i7-6700hq)
Test kms_sink_crc_basic:
pass -> SKIP (ro-skl-i7-6700hq)
Test pm_rpm:
Subgroup basic-pci-d3-state:
fail -> DMESG-WARN (ro-skl-i7-6700hq)
Test pm_rps:
Subgroup basic-api:
dmesg-warn -> PASS (ro-skl-i7-6700hq)
ro-bdw-i5-5250u total:209 pass:172 dwarn:0 dfail:0 fail:0 skip:37
ro-bdw-i7-5557U total:209 pass:197 dwarn:0 dfail:0 fail:0 skip:12
ro-bdw-i7-5600u total:209 pass:180 dwarn:0 dfail:0 fail:1 skip:28
ro-bsw-n3050 total:209 pass:168 dwarn:0 dfail:0 fail:2 skip:39
ro-byt-n2820 total:10 pass:9 dwarn:0 dfail:0 fail:0 skip:0
ro-hsw-i3-4010u total:209 pass:186 dwarn:0 dfail:0 fail:0 skip:23
ro-hsw-i7-4770r total:209 pass:186 dwarn:0 dfail:0 fail:0 skip:23
ro-ilk-i7-620lm total:209 pass:146 dwarn:0 dfail:0 fail:1 skip:62
ro-ilk1-i5-650 total:204 pass:146 dwarn:0 dfail:0 fail:1 skip:57
ro-ivb-i7-3770 total:209 pass:177 dwarn:0 dfail:0 fail:0 skip:32
ro-ivb2-i7-3770 total:209 pass:181 dwarn:0 dfail:0 fail:0 skip:28
ro-skl-i7-6700hq total:204 pass:174 dwarn:8 dfail:0 fail:0 skip:22
ro-snb-i7-2620M total:209 pass:170 dwarn:0 dfail:0 fail:1 skip:38
fi-bsw-n3050 failed to connect after reboot
Results at /archive/results/CI_IGT_test/RO_Patchwork_983/
8621fb5 drm-intel-nightly: 2016y-05m-23d-18h-18m-33s UTC integration manifest
a62bb7c drm/i915: Fix NULL pointer deference when out of PLLs in IVB
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 7+ messages in thread* Re: ✗ Ro.CI.BAT: failure for drm/i915: Fix NULL pointer deference when out of PLLs in IVB
2016-05-24 7:00 ` Patchwork
@ 2016-05-26 12:23 ` Ander Conselvan De Oliveira
0 siblings, 0 replies; 7+ messages in thread
From: Ander Conselvan De Oliveira @ 2016-05-26 12:23 UTC (permalink / raw)
To: intel-gfx
On Tue, 2016-05-24 at 07:00 +0000, Patchwork wrote:
> == Series Details ==
>
> Series: drm/i915: Fix NULL pointer deference when out of PLLs in IVB
> URL : https://patchwork.freedesktop.org/series/7458/
> State : failure
>
> == Summary ==
>
> Series 7458v1 drm/i915: Fix NULL pointer deference when out of PLLs in IVB
> http://patchwork.freedesktop.org/api/1.0/series/7458/revisions/1/mbox
>
> Test gem_busy:
> Subgroup basic-parallel-blt:
> pass -> DMESG-WARN (ro-skl-i7-6700hq)
*ERROR* Potential atomic update failure on pipe A
https://bugs.freedesktop.org/show_bug.cgi?id=95632
> Subgroup basic-parallel-vebox:
> dmesg-warn -> PASS (ro-skl-i7-6700hq)
> Test gem_ringfill:
> Subgroup basic-default:
> pass -> DMESG-WARN (ro-skl-i7-6700hq)
Same here.
> Subgroup basic-default-interruptible:
> dmesg-warn -> PASS (ro-skl-i7-6700hq)
> Test gem_storedw_loop:
> Subgroup basic-default:
> pass -> INCOMPLETE (ro-byt-n2820)
BYT doesn't use the shared DPLL code that is changed by this patch.
> dmesg-warn -> PASS (ro-skl-i7-6700hq)
> Test kms_frontbuffer_tracking:
> Subgroup basic:
> pass -> DMESG-WARN (ro-skl-i7-6700hq)
More atomic update failure.
> Test kms_pipe_crc_basic:
> Subgroup bad-pipe:
> dmesg-warn -> PASS (ro-skl-i7-6700hq)
> Subgroup bad-source:
> pass -> DMESG-WARN (ro-skl-i7-6700hq)
Here too.
> Test kms_setmode:
> Subgroup basic-clone-single-crtc:
> pass -> DMESG-WARN (ro-skl-i7-6700hq)
Here too.
Patch pushed to dinq. Thanks for reviews.
Ander
> Test kms_sink_crc_basic:
> pass -> SKIP (ro-skl-i7-6700hq)
> Test pm_rpm:
> Subgroup basic-pci-d3-state:
> fail -> DMESG-WARN (ro-skl-i7-6700hq)
> Test pm_rps:
> Subgroup basic-api:
> dmesg-warn -> PASS (ro-skl-i7-6700hq)
>
> ro-bdw-i5-5250u total:209 pass:172 dwarn:0 dfail:0 fail:0 skip:37
> ro-bdw-i7-5557U total:209 pass:197 dwarn:0 dfail:0 fail:0 skip:12
> ro-bdw-i7-5600u total:209 pass:180 dwarn:0 dfail:0 fail:1 skip:28
> ro-bsw-n3050 total:209 pass:168 dwarn:0 dfail:0 fail:2 skip:39
> ro-byt-n2820 total:10 pass:9 dwarn:0 dfail:0 fail:0 skip:0
> ro-hsw-i3-4010u total:209 pass:186 dwarn:0 dfail:0 fail:0 skip:23
> ro-hsw-i7-4770r total:209 pass:186 dwarn:0 dfail:0 fail:0 skip:23
> ro-ilk-i7-620lm total:209 pass:146 dwarn:0 dfail:0 fail:1 skip:62
> ro-ilk1-i5-650 total:204 pass:146 dwarn:0 dfail:0 fail:1 skip:57
> ro-ivb-i7-3770 total:209 pass:177 dwarn:0 dfail:0 fail:0 skip:32
> ro-ivb2-i7-3770 total:209 pass:181 dwarn:0 dfail:0 fail:0 skip:28
> ro-skl-i7-6700hq total:204 pass:174 dwarn:8 dfail:0 fail:0 skip:22
> ro-snb-i7-2620M total:209 pass:170 dwarn:0 dfail:0 fail:1 skip:38
> fi-bsw-n3050 failed to connect after reboot
>
> Results at /archive/results/CI_IGT_test/RO_Patchwork_983/
>
> 8621fb5 drm-intel-nightly: 2016y-05m-23d-18h-18m-33s UTC integration manifest
> a62bb7c drm/i915: Fix NULL pointer deference when out of PLLs in IVB
>
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2016-05-26 12:23 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-05-20 12:47 [PATCH] drm/i915: Fix NULL pointer deference when out of PLLs in IVB Ander Conselvan de Oliveira
2016-05-20 13:39 ` ✗ Ro.CI.BAT: failure for " Patchwork
2016-05-20 17:13 ` [PATCH] " Ville Syrjälä
2016-05-23 8:42 ` Jani Nikula
2016-05-23 16:51 ` ✗ Ro.CI.BAT: failure for " Patchwork
2016-05-24 7:00 ` Patchwork
2016-05-26 12:23 ` Ander Conselvan De Oliveira
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.