From: Felipe Balbi <balbi-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
To: Roger Quadros <rogerq-l0cyMroinI0@public.gmane.org>
Cc: tony-4v6yS6AI5VpBDgjK7y7TUQ@public.gmane.org,
Joao.Pinto-HKixBCOQz3hWk0Htik3J/w@public.gmane.org,
sergei.shtylyov-M4DtvfQ/ZS1MRgGoP+s0PdBPR1lH4CV8@public.gmane.org,
peter.chen-KZfg59tc24xl57MIdRCFDg@public.gmane.org,
jun.li-KZfg59tc24xl57MIdRCFDg@public.gmane.org,
grygorii.strashko-l0cyMroinI0@public.gmane.org,
yoshihiro.shimoda.uh-zM6kxYcvzFBBDgjK7y7TUQ@public.gmane.org,
nsekhar-l0cyMroinI0@public.gmane.org,
linux-usb-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-omap-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: [PATCH v6 07/10] usb: dwc3: gadget: Fix suspend/resume during dual-role mode
Date: Mon, 11 Apr 2016 16:26:59 +0300 [thread overview]
Message-ID: <87oa9gmg2k.fsf@intel.com> (raw)
In-Reply-To: <570BA2AA.8030308-l0cyMroinI0@public.gmane.org>
[-- Attachment #1: Type: text/plain, Size: 828 bytes --]
Hi,
Roger Quadros <rogerq-l0cyMroinI0@public.gmane.org> writes:
> On 11/04/16 15:23, Felipe Balbi wrote:
>>
>> Hi,
>>
>> Roger Quadros <rogerq-l0cyMroinI0@public.gmane.org> writes:
>>> Gadget controller might not be always active during suspend/
>>> resume when we are operating in dual-role/otg mode.
>>> Check if we're active and only if we are then perform
>>> necessary actions during suspend/resume.
>>
>> I don't get this. If we're operating in OTG, we should have a gadget
>> driver loaded, no ?
>>
> At boot gadget driver is not automatically loaded. We're still in OTG mode
> but OTG state machine hasn't started.
> System suspend/resume can still happen.
>
> User might also load/unload the gadget driver prior to system suspend.
good point, this should go in the -rc too.
--
balbi
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 818 bytes --]
WARNING: multiple messages have this Message-ID (diff)
From: Felipe Balbi <balbi@kernel.org>
To: Roger Quadros <rogerq@ti.com>
Cc: tony@atomide.com, Joao.Pinto@synopsys.com,
sergei.shtylyov@cogentembedded.com, peter.chen@freescale.com,
jun.li@freescale.com, grygorii.strashko@ti.com,
yoshihiro.shimoda.uh@renesas.com, nsekhar@ti.com,
linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-omap@vger.kernel.org
Subject: Re: [PATCH v6 07/10] usb: dwc3: gadget: Fix suspend/resume during dual-role mode
Date: Mon, 11 Apr 2016 16:26:59 +0300 [thread overview]
Message-ID: <87oa9gmg2k.fsf@intel.com> (raw)
In-Reply-To: <570BA2AA.8030308@ti.com>
[-- Attachment #1: Type: text/plain, Size: 784 bytes --]
Hi,
Roger Quadros <rogerq@ti.com> writes:
> On 11/04/16 15:23, Felipe Balbi wrote:
>>
>> Hi,
>>
>> Roger Quadros <rogerq@ti.com> writes:
>>> Gadget controller might not be always active during suspend/
>>> resume when we are operating in dual-role/otg mode.
>>> Check if we're active and only if we are then perform
>>> necessary actions during suspend/resume.
>>
>> I don't get this. If we're operating in OTG, we should have a gadget
>> driver loaded, no ?
>>
> At boot gadget driver is not automatically loaded. We're still in OTG mode
> but OTG state machine hasn't started.
> System suspend/resume can still happen.
>
> User might also load/unload the gadget driver prior to system suspend.
good point, this should go in the -rc too.
--
balbi
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 818 bytes --]
next prev parent reply other threads:[~2016-04-11 13:26 UTC|newest]
Thread overview: 59+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-11 11:34 [PATCH v6 00/10] usb: dwc3: add dual-role support Roger Quadros
2016-04-11 11:34 ` Roger Quadros
2016-04-11 11:34 ` [PATCH v6 01/10] usb: dwc3: core.h: add some register definitions Roger Quadros
2016-04-11 11:34 ` Roger Quadros
2016-04-11 11:34 ` [PATCH v6 02/10] usb: dwc3: omap: Make the wrapper interrupt shared Roger Quadros
2016-04-11 11:34 ` Roger Quadros
[not found] ` <1460374506-9779-3-git-send-email-rogerq-l0cyMroinI0@public.gmane.org>
2016-04-11 12:13 ` Felipe Balbi
2016-04-11 12:13 ` Felipe Balbi
2016-04-11 12:51 ` Roger Quadros
2016-04-11 12:51 ` Roger Quadros
2016-04-11 12:58 ` Felipe Balbi
2016-04-11 13:15 ` Roger Quadros
2016-04-11 13:15 ` Roger Quadros
[not found] ` <570BA375.2040203-l0cyMroinI0@public.gmane.org>
2016-04-11 13:20 ` Felipe Balbi
2016-04-11 13:20 ` Felipe Balbi
2016-04-11 11:34 ` [PATCH v6 03/10] usb: dwc3: omap: Pass VBUS and ID events transparently Roger Quadros
2016-04-11 11:34 ` Roger Quadros
[not found] ` <1460374506-9779-4-git-send-email-rogerq-l0cyMroinI0@public.gmane.org>
2016-04-11 12:18 ` Felipe Balbi
2016-04-11 12:18 ` Felipe Balbi
2016-04-11 13:03 ` Roger Quadros
2016-04-11 13:03 ` Roger Quadros
[not found] ` <570BA0B1.1060404-l0cyMroinI0@public.gmane.org>
2016-04-11 13:26 ` Felipe Balbi
2016-04-11 13:26 ` Felipe Balbi
2016-04-11 13:51 ` Roger Quadros
2016-04-11 13:51 ` Roger Quadros
2016-04-11 11:35 ` [PATCH v6 04/10] usb: dwc3: omap: fix up error path on probe() Roger Quadros
2016-04-11 11:35 ` Roger Quadros
[not found] ` <1460374506-9779-5-git-send-email-rogerq-l0cyMroinI0@public.gmane.org>
2016-04-11 12:20 ` Felipe Balbi
2016-04-11 12:20 ` Felipe Balbi
[not found] ` <87bn5gnxp9.fsf-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
2016-04-11 13:09 ` Roger Quadros
2016-04-11 13:09 ` Roger Quadros
2016-04-11 11:35 ` [PATCH v6 05/10] usb: dwc3: core: cleanup IRQ resources Roger Quadros
2016-04-11 11:35 ` Roger Quadros
2016-04-11 11:35 ` [PATCH v6 06/10] usb: dwc3: add dual-role support Roger Quadros
2016-04-11 11:35 ` Roger Quadros
2016-04-11 11:35 ` [PATCH v6 07/10] usb: dwc3: gadget: Fix suspend/resume during dual-role mode Roger Quadros
2016-04-11 11:35 ` Roger Quadros
[not found] ` <1460374506-9779-8-git-send-email-rogerq-l0cyMroinI0@public.gmane.org>
2016-04-11 12:23 ` Felipe Balbi
2016-04-11 12:23 ` Felipe Balbi
2016-04-11 13:12 ` Roger Quadros
2016-04-11 13:12 ` Roger Quadros
[not found] ` <570BA2AA.8030308-l0cyMroinI0@public.gmane.org>
2016-04-11 13:26 ` Felipe Balbi [this message]
2016-04-11 13:26 ` Felipe Balbi
2016-04-11 13:53 ` Roger Quadros
2016-04-11 13:53 ` Roger Quadros
[not found] ` <570BAC4D.8010209-l0cyMroinI0@public.gmane.org>
2016-04-12 8:00 ` Felipe Balbi
2016-04-12 8:00 ` Felipe Balbi
2016-04-12 8:25 ` Roger Quadros
2016-04-12 8:25 ` Roger Quadros
2016-04-11 11:35 ` [PATCH v6 08/10] usb: dwc3: core: fix PHY handling during suspend Roger Quadros
2016-04-11 11:35 ` Roger Quadros
2016-04-11 12:24 ` Felipe Balbi
2016-04-11 12:24 ` Felipe Balbi
[not found] ` <8760vonxin.fsf-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
2016-04-11 13:13 ` Roger Quadros
2016-04-11 13:13 ` Roger Quadros
2016-04-11 11:35 ` [PATCH v6 09/10] ARM: dts: dra7*-evm: Enable dual-role for usb1 Roger Quadros
2016-04-11 11:35 ` Roger Quadros
2016-04-11 11:35 ` [PATCH v6 10/10] ARM: dts: am43xx: Enable dual-role on USB1 Roger Quadros
2016-04-11 11:35 ` Roger Quadros
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87oa9gmg2k.fsf@intel.com \
--to=balbi-dgejt+ai2ygdnm+yrofe0a@public.gmane.org \
--cc=Joao.Pinto-HKixBCOQz3hWk0Htik3J/w@public.gmane.org \
--cc=grygorii.strashko-l0cyMroinI0@public.gmane.org \
--cc=jun.li-KZfg59tc24xl57MIdRCFDg@public.gmane.org \
--cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-omap-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-usb-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=nsekhar-l0cyMroinI0@public.gmane.org \
--cc=peter.chen-KZfg59tc24xl57MIdRCFDg@public.gmane.org \
--cc=rogerq-l0cyMroinI0@public.gmane.org \
--cc=sergei.shtylyov-M4DtvfQ/ZS1MRgGoP+s0PdBPR1lH4CV8@public.gmane.org \
--cc=tony-4v6yS6AI5VpBDgjK7y7TUQ@public.gmane.org \
--cc=yoshihiro.shimoda.uh-zM6kxYcvzFBBDgjK7y7TUQ@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.