From: "Aneesh Kumar K.V" <aneesh.kumar@linux.vnet.ibm.com>
To: Paul Mackerras <paulus@samba.org>
Cc: agraf@suse.de, benh@kernel.crashing.org,
linuxppc-dev@lists.ozlabs.org, kvm-ppc@vger.kernel.org,
kvm@vger.kernel.org
Subject: Re: [RFC PATCH 07/10] KVM: PPC: BOOK3S: PR: Emulate facility status and control register
Date: Fri, 31 Jan 2014 11:40:05 +0000 [thread overview]
Message-ID: <87ob2sjsqi.fsf@linux.vnet.ibm.com> (raw)
In-Reply-To: <20140130060000.GB10611@iris.ozlabs.ibm.com>
Paul Mackerras <paulus@samba.org> writes:
> On Tue, Jan 28, 2014 at 10:14:12PM +0530, Aneesh Kumar K.V wrote:
>> We allow priv-mode update of this. The guest value is saved in fscr,
>> and the value actually used is saved in shadow_fscr. shadow_fscr
>> only contains values that are allowed by the host. On
>> facility unavailable interrupt, if the facility is allowed by fscr
>> but disabled in shadow_fscr we need to emulate the support. Currently
>> all but EBB is disabled. We still don't support performance monitoring
>> in PR guest.
>
> ...
>
>> + /*
>> + * Save the current fscr in shadow fscr
>> + */
>> + mfspr r3,SPRN_FSCR
>> + PPC_STL r3, VCPU_SHADOW_FSCR(r7)
>
> I don't think you need to do this. What could possibly have changed
> FSCR since we loaded it on the way into the guest?
The reason for facility unavailable interrupt is encoded in FSCR right ?
-aneesh
WARNING: multiple messages have this Message-ID (diff)
From: "Aneesh Kumar K.V" <aneesh.kumar@linux.vnet.ibm.com>
To: Paul Mackerras <paulus@samba.org>
Cc: linuxppc-dev@lists.ozlabs.org, agraf@suse.de,
kvm-ppc@vger.kernel.org, kvm@vger.kernel.org
Subject: Re: [RFC PATCH 07/10] KVM: PPC: BOOK3S: PR: Emulate facility status and control register
Date: Fri, 31 Jan 2014 16:58:05 +0530 [thread overview]
Message-ID: <87ob2sjsqi.fsf@linux.vnet.ibm.com> (raw)
In-Reply-To: <20140130060000.GB10611@iris.ozlabs.ibm.com>
Paul Mackerras <paulus@samba.org> writes:
> On Tue, Jan 28, 2014 at 10:14:12PM +0530, Aneesh Kumar K.V wrote:
>> We allow priv-mode update of this. The guest value is saved in fscr,
>> and the value actually used is saved in shadow_fscr. shadow_fscr
>> only contains values that are allowed by the host. On
>> facility unavailable interrupt, if the facility is allowed by fscr
>> but disabled in shadow_fscr we need to emulate the support. Currently
>> all but EBB is disabled. We still don't support performance monitoring
>> in PR guest.
>
> ...
>
>> + /*
>> + * Save the current fscr in shadow fscr
>> + */
>> + mfspr r3,SPRN_FSCR
>> + PPC_STL r3, VCPU_SHADOW_FSCR(r7)
>
> I don't think you need to do this. What could possibly have changed
> FSCR since we loaded it on the way into the guest?
The reason for facility unavailable interrupt is encoded in FSCR right ?
-aneesh
WARNING: multiple messages have this Message-ID (diff)
From: "Aneesh Kumar K.V" <aneesh.kumar@linux.vnet.ibm.com>
To: Paul Mackerras <paulus@samba.org>
Cc: agraf@suse.de, benh@kernel.crashing.org,
linuxppc-dev@lists.ozlabs.org, kvm-ppc@vger.kernel.org,
kvm@vger.kernel.org
Subject: Re: [RFC PATCH 07/10] KVM: PPC: BOOK3S: PR: Emulate facility status and control register
Date: Fri, 31 Jan 2014 16:58:05 +0530 [thread overview]
Message-ID: <87ob2sjsqi.fsf@linux.vnet.ibm.com> (raw)
In-Reply-To: <20140130060000.GB10611@iris.ozlabs.ibm.com>
Paul Mackerras <paulus@samba.org> writes:
> On Tue, Jan 28, 2014 at 10:14:12PM +0530, Aneesh Kumar K.V wrote:
>> We allow priv-mode update of this. The guest value is saved in fscr,
>> and the value actually used is saved in shadow_fscr. shadow_fscr
>> only contains values that are allowed by the host. On
>> facility unavailable interrupt, if the facility is allowed by fscr
>> but disabled in shadow_fscr we need to emulate the support. Currently
>> all but EBB is disabled. We still don't support performance monitoring
>> in PR guest.
>
> ...
>
>> + /*
>> + * Save the current fscr in shadow fscr
>> + */
>> + mfspr r3,SPRN_FSCR
>> + PPC_STL r3, VCPU_SHADOW_FSCR(r7)
>
> I don't think you need to do this. What could possibly have changed
> FSCR since we loaded it on the way into the guest?
The reason for facility unavailable interrupt is encoded in FSCR right ?
-aneesh
next prev parent reply other threads:[~2014-01-31 11:40 UTC|newest]
Thread overview: 99+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-01-28 16:44 [RFC PATCH 01/10] KVM: PPC: BOOK3S: PR: Add POWER8 support Aneesh Kumar K.V
2014-01-28 16:56 ` Aneesh Kumar K.V
2014-01-28 16:44 ` Aneesh Kumar K.V
2014-01-28 16:44 ` [RFC PATCH 01/10] KVM: PPC: BOOK3S: PR: Fix PURR and SPURR emulation Aneesh Kumar K.V
2014-01-28 16:56 ` Aneesh Kumar K.V
2014-01-28 16:44 ` Aneesh Kumar K.V
2014-01-29 16:32 ` Alexander Graf
2014-01-29 16:32 ` Alexander Graf
2014-01-29 16:32 ` Alexander Graf
2014-01-31 10:38 ` Aneesh Kumar K.V
2014-01-31 10:50 ` Aneesh Kumar K.V
2014-01-31 10:38 ` Aneesh Kumar K.V
2014-01-31 10:47 ` Alexander Graf
2014-01-31 10:47 ` Alexander Graf
2014-01-31 10:47 ` Alexander Graf
2014-01-31 22:17 ` Paul Mackerras
2014-01-31 22:17 ` Paul Mackerras
2014-01-31 22:17 ` Paul Mackerras
2014-02-05 9:15 ` Alexander Graf
2014-02-05 9:15 ` Alexander Graf
2014-02-05 9:15 ` Alexander Graf
2014-01-28 16:44 ` [RFC PATCH 02/10] KVM: PPC: BOOK3S: PR: Emulate virtual timebase register Aneesh Kumar K.V
2014-01-28 16:56 ` Aneesh Kumar K.V
2014-01-28 16:44 ` Aneesh Kumar K.V
2014-01-29 16:39 ` Alexander Graf
2014-01-29 16:39 ` Alexander Graf
2014-01-29 16:39 ` Alexander Graf
2014-01-29 22:54 ` Benjamin Herrenschmidt
2014-01-29 22:54 ` Benjamin Herrenschmidt
2014-01-29 22:54 ` Benjamin Herrenschmidt
2014-01-30 0:35 ` Benjamin Herrenschmidt
2014-01-30 0:35 ` Benjamin Herrenschmidt
2014-01-30 0:35 ` Benjamin Herrenschmidt
2014-01-30 5:49 ` Paul Mackerras
2014-01-30 5:49 ` Paul Mackerras
2014-01-30 5:49 ` Paul Mackerras
2014-01-30 10:04 ` Alexander Graf
2014-01-30 10:04 ` Alexander Graf
2014-01-30 10:04 ` Alexander Graf
2014-01-31 10:57 ` Aneesh Kumar K.V
2014-01-31 10:57 ` Aneesh Kumar K.V
2014-01-31 10:57 ` Aneesh Kumar K.V
2014-01-28 16:44 ` [RFC PATCH 03/10] KVM: PPC: BOOK3S: PR: Emulate instruction counter Aneesh Kumar K.V
2014-01-28 16:56 ` Aneesh Kumar K.V
2014-01-28 16:44 ` Aneesh Kumar K.V
2014-01-29 16:40 ` Alexander Graf
2014-01-29 16:40 ` Alexander Graf
2014-01-29 16:40 ` Alexander Graf
2014-01-31 11:25 ` Aneesh Kumar K.V
2014-01-31 11:37 ` Aneesh Kumar K.V
2014-01-31 11:25 ` Aneesh Kumar K.V
2014-01-31 11:28 ` Alexander Graf
2014-01-31 11:28 ` Alexander Graf
2014-01-31 11:28 ` Alexander Graf
2014-01-28 16:44 ` [RFC PATCH 04/10] KVM: PPC: BOOK3S: PR: Emulate Thread identification register Aneesh Kumar K.V
2014-01-28 16:56 ` Aneesh Kumar K.V
2014-01-28 16:44 ` Aneesh Kumar K.V
2014-01-28 16:44 ` [RFC PATCH 05/10] KVM: PPC: BOOK3S: PR: Doorbell support Aneesh Kumar K.V
2014-01-28 16:56 ` Aneesh Kumar K.V
2014-01-28 16:44 ` Aneesh Kumar K.V
2014-01-28 16:44 ` [RFC PATCH 06/10] KVM: PPC: BOOK3S: PR: Emulate DPDES register Aneesh Kumar K.V
2014-01-28 16:56 ` Aneesh Kumar K.V
2014-01-28 16:44 ` Aneesh Kumar K.V
2014-01-28 16:44 ` [RFC PATCH 07/10] KVM: PPC: BOOK3S: PR: Emulate facility status and control register Aneesh Kumar K.V
2014-01-28 16:56 ` Aneesh Kumar K.V
2014-01-28 16:44 ` Aneesh Kumar K.V
2014-01-29 17:11 ` Alexander Graf
2014-01-29 17:11 ` Alexander Graf
2014-01-29 17:11 ` Alexander Graf
2014-01-30 6:00 ` Paul Mackerras
2014-01-30 6:00 ` Paul Mackerras
2014-01-30 6:00 ` Paul Mackerras
2014-01-30 10:02 ` Alexander Graf
2014-01-30 10:02 ` Alexander Graf
2014-01-30 10:02 ` Alexander Graf
2014-01-31 11:28 ` Aneesh Kumar K.V [this message]
2014-01-31 11:40 ` Aneesh Kumar K.V
2014-01-31 11:28 ` Aneesh Kumar K.V
2014-01-28 16:44 ` [RFC PATCH 08/10] KVM: PPC: BOOK3S: PR: Add support for facility unavailable interrupt Aneesh Kumar K.V
2014-01-28 16:56 ` Aneesh Kumar K.V
2014-01-28 16:44 ` Aneesh Kumar K.V
2014-01-29 17:35 ` Alexander Graf
2014-01-29 17:35 ` Alexander Graf
2014-01-29 17:35 ` Alexander Graf
2014-01-31 11:40 ` Aneesh Kumar K.V
2014-01-31 11:52 ` Aneesh Kumar K.V
2014-01-31 11:40 ` Aneesh Kumar K.V
2014-01-31 12:02 ` Alexander Graf
2014-01-31 12:02 ` Alexander Graf
2014-01-31 12:02 ` Alexander Graf
2014-01-28 16:44 ` [RFC PATCH 09/10] KVM: PPC: BOOK3S: PR: Ignore write to monitor mode control register Aneesh Kumar K.V
2014-01-28 16:56 ` Aneesh Kumar K.V
2014-01-28 16:44 ` Aneesh Kumar K.V
2014-01-28 16:44 ` [RFC PATCH 10/10] PPC: BOOK3S: Disable/Enable TM looking at the ibm, pa-features device tree entry Aneesh Kumar K.V
2014-01-28 16:56 ` [RFC PATCH 10/10] PPC: BOOK3S: Disable/Enable TM looking at the ibm,pa-features " Aneesh Kumar K.V
2014-01-28 16:44 ` Aneesh Kumar K.V
2014-01-29 17:37 ` [RFC PATCH 10/10] PPC: BOOK3S: Disable/Enable TM looking at the ibm,pa-features device tree entr Alexander Graf
2014-01-29 17:37 ` [RFC PATCH 10/10] PPC: BOOK3S: Disable/Enable TM looking at the ibm,pa-features device tree entry Alexander Graf
2014-01-29 17:37 ` Alexander Graf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87ob2sjsqi.fsf@linux.vnet.ibm.com \
--to=aneesh.kumar@linux.vnet.ibm.com \
--cc=agraf@suse.de \
--cc=benh@kernel.crashing.org \
--cc=kvm-ppc@vger.kernel.org \
--cc=kvm@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=paulus@samba.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.