From: Peter Korsgaard <peter.korsgaard@barco.com>
To: Ionut Nicu <ioan.nicu.ext@nsn.com>
Cc: Wolfram Sang <wsa@the-dreams.de>,
Alexander Sverdlin <alexander.sverdlin@nsn.com>,
linux-i2c@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] i2c-mux-gpio: use deferred probing with the device tree
Date: Tue, 8 Oct 2013 15:30:49 +0200 [thread overview]
Message-ID: <87ob6znb3q.fsf@thor.barco.com> (raw)
In-Reply-To: <52540692.9080208@nsn.com> (Ionut Nicu's message of "Tue, 8 Oct 2013 15:20:18 +0200")
>>>>> "IN" == Ionut Nicu <ioan.nicu.ext@nsn.com> writes:
IN> If the i2c-parent bus driver is not loaded, returning
IN> -EINVAL will force people to unload and then reload the
IN> module again to get it working.
IN> Also of_get_named_gpio could return -E_PROBE_DEFER or
IN> another error code. This error should be passed further
IN> instead of being ignored.
Two different fixes, so should be 2 separate patches. Other that that,
it looks good.
Acked-by: Peter Korsgaard <peter.korsgaard@barco.com>
--
Sorry about disclaimer - It's out of my control.
Bye, Peter Korsgaard
This message is subject to the following terms and conditions: MAIL DISCLAIMER<http://www.barco.com/en/maildisclaimer>
WARNING: multiple messages have this Message-ID (diff)
From: Peter Korsgaard <peter.korsgaard@barco.com>
To: Ionut Nicu <ioan.nicu.ext@nsn.com>
Cc: Wolfram Sang <wsa@the-dreams.de>,
Alexander Sverdlin <alexander.sverdlin@nsn.com>,
<linux-i2c@vger.kernel.org>, <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] i2c-mux-gpio: use deferred probing with the device tree
Date: Tue, 8 Oct 2013 15:30:49 +0200 [thread overview]
Message-ID: <87ob6znb3q.fsf@thor.barco.com> (raw)
In-Reply-To: <52540692.9080208@nsn.com> (Ionut Nicu's message of "Tue, 8 Oct 2013 15:20:18 +0200")
>>>>> "IN" == Ionut Nicu <ioan.nicu.ext@nsn.com> writes:
IN> If the i2c-parent bus driver is not loaded, returning
IN> -EINVAL will force people to unload and then reload the
IN> module again to get it working.
IN> Also of_get_named_gpio could return -E_PROBE_DEFER or
IN> another error code. This error should be passed further
IN> instead of being ignored.
Two different fixes, so should be 2 separate patches. Other that that,
it looks good.
Acked-by: Peter Korsgaard <peter.korsgaard@barco.com>
--
Sorry about disclaimer - It's out of my control.
Bye, Peter Korsgaard
This message is subject to the following terms and conditions: MAIL DISCLAIMER<http://www.barco.com/en/maildisclaimer>
next prev parent reply other threads:[~2013-10-08 13:30 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-10-08 13:20 [PATCH] i2c-mux-gpio: use deferred probing with the device tree Ionut Nicu
2013-10-08 13:20 ` Ionut Nicu
2013-10-08 13:30 ` Peter Korsgaard [this message]
2013-10-08 13:30 ` Peter Korsgaard
[not found] ` <87ob6znb3q.fsf-1Ae4nN3xCbAluPl5bxqUMw@public.gmane.org>
2013-10-08 13:34 ` Ionut Nicu
2013-10-08 13:34 ` Ionut Nicu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87ob6znb3q.fsf@thor.barco.com \
--to=peter.korsgaard@barco.com \
--cc=alexander.sverdlin@nsn.com \
--cc=ioan.nicu.ext@nsn.com \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=wsa@the-dreams.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.