* netrc credential helper promotion out of contrib?
@ 2013-08-18 10:35 Ted Zlatanov
2013-08-20 19:28 ` Junio C Hamano
0 siblings, 1 reply; 3+ messages in thread
From: Ted Zlatanov @ 2013-08-18 10:35 UTC (permalink / raw)
To: git
A while has passed since contrib/credential/netrc was added. Is it OK to
promote it to be part of the main installation? In that directory
there's also gnome-keyring, osxkeychain, and wincred; I don't know if
those are ready for promotion.
Thanks
Ted
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: netrc credential helper promotion out of contrib?
2013-08-18 10:35 netrc credential helper promotion out of contrib? Ted Zlatanov
@ 2013-08-20 19:28 ` Junio C Hamano
2013-09-03 15:12 ` Ted Zlatanov
0 siblings, 1 reply; 3+ messages in thread
From: Junio C Hamano @ 2013-08-20 19:28 UTC (permalink / raw)
To: Ted Zlatanov; +Cc: git
Ted Zlatanov <tzz@lifelogs.com> writes:
> A while has passed since contrib/credential/netrc was added. Is it OK to
> promote it to be part of the main installation?
I gave it a quick glance, and it seems to be cleanly written, except
that "EOHIPPUS" (End-of-Hippus? Eohippus the extinct horse?) looked
a bit too strange to my taste ;-). It does not seem to use features
older versions of Perl some people are stuck with do not support.
I do not mind seeing a patch that moves contrib/credential/netrc to
credential/netrc and adjusts the top-level Makefile. The test
script needs to be updated to fit the rest of t/ hierarchy better,
though.
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: netrc credential helper promotion out of contrib?
2013-08-20 19:28 ` Junio C Hamano
@ 2013-09-03 15:12 ` Ted Zlatanov
0 siblings, 0 replies; 3+ messages in thread
From: Ted Zlatanov @ 2013-09-03 15:12 UTC (permalink / raw)
To: git
On Tue, 20 Aug 2013 12:28:39 -0700 Junio C Hamano <gitster@pobox.com> wrote:
JCH> Ted Zlatanov <tzz@lifelogs.com> writes:
>> A while has passed since contrib/credential/netrc was added. Is it OK to
>> promote it to be part of the main installation?
JCH> I gave it a quick glance, and it seems to be cleanly written, except
JCH> that "EOHIPPUS" (End-of-Hippus? Eohippus the extinct horse?) looked
JCH> a bit too strange to my taste ;-). It does not seem to use features
JCH> older versions of Perl some people are stuck with do not support.
Thanks, I was careful about that. `EOF' as the end-of-document marker
is a bit boring, don't you think? Well, I can use it here if you
insist, but it seems OK to me.
JCH> I do not mind seeing a patch that moves contrib/credential/netrc to
JCH> credential/netrc and adjusts the top-level Makefile. The test
JCH> script needs to be updated to fit the rest of t/ hierarchy better,
JCH> though.
OK, I will work on that patch. Thanks for the reply.
Ted
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2013-09-03 15:12 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-08-18 10:35 netrc credential helper promotion out of contrib? Ted Zlatanov
2013-08-20 19:28 ` Junio C Hamano
2013-09-03 15:12 ` Ted Zlatanov
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.