From: Jani Nikula <jani.nikula@linux.intel.com>
To: Paulo Zanoni <przanoni@gmail.com>, intel-gfx@lists.freedesktop.org
Cc: Paulo Zanoni <paulo.r.zanoni@intel.com>
Subject: Re: [PATCH] drm/i915: implement WaMbcDriverBootEnable on Haswell
Date: Wed, 31 Oct 2012 14:46:22 +0200 [thread overview]
Message-ID: <87objilsgx.fsf@intel.com> (raw)
In-Reply-To: <1351269290-3910-1-git-send-email-przanoni@gmail.com>
On Fri, 26 Oct 2012, Paulo Zanoni <przanoni@gmail.com> wrote:
> From: Paulo Zanoni <paulo.r.zanoni@intel.com>
>
> Also document the WA name for the previous gens that implement it.
Looks good based on the existing workarounds and specs; was unable to
find any further details on the WA.
Reviewed-by: Jani Nikula <jani.nikula@intel.com>
> Signed-off-by: Paulo Zanoni <paulo.r.zanoni@intel.com>
> ---
> drivers/gpu/drm/i915/intel_pm.c | 7 +++++++
> 1 file changed, 7 insertions(+)
>
> diff --git a/drivers/gpu/drm/i915/intel_pm.c b/drivers/gpu/drm/i915/intel_pm.c
> index 59068be..150aebd 100644
> --- a/drivers/gpu/drm/i915/intel_pm.c
> +++ b/drivers/gpu/drm/i915/intel_pm.c
> @@ -3450,6 +3450,7 @@ static void gen6_init_clock_gating(struct drm_device *dev)
> ILK_DPARBUNIT_CLOCK_GATE_ENABLE |
> ILK_DPFDUNIT_CLOCK_GATE_ENABLE);
>
> + /* WaMbcDriverBootEnable */
> I915_WRITE(GEN6_MBCTL, I915_READ(GEN6_MBCTL) |
> GEN6_MBCTL_ENABLE_BOOT_FETCH);
>
> @@ -3520,6 +3521,10 @@ static void haswell_init_clock_gating(struct drm_device *dev)
> I915_WRITE(CACHE_MODE_1,
> _MASKED_BIT_ENABLE(PIXEL_SUBSPAN_COLLECT_OPT_DISABLE));
>
> + /* WaMbcDriverBootEnable */
> + I915_WRITE(GEN6_MBCTL, I915_READ(GEN6_MBCTL) |
> + GEN6_MBCTL_ENABLE_BOOT_FETCH);
> +
> /* XXX: This is a workaround for early silicon revisions and should be
> * removed later.
> */
> @@ -3595,6 +3600,7 @@ static void ivybridge_init_clock_gating(struct drm_device *dev)
> intel_flush_display_plane(dev_priv, pipe);
> }
>
> + /* WaMbcDriverBootEnable */
> I915_WRITE(GEN6_MBCTL, I915_READ(GEN6_MBCTL) |
> GEN6_MBCTL_ENABLE_BOOT_FETCH);
>
> @@ -3647,6 +3653,7 @@ static void valleyview_init_clock_gating(struct drm_device *dev)
> I915_READ(GEN7_SQ_CHICKEN_MBCUNIT_CONFIG) |
> GEN7_SQ_CHICKEN_MBCUNIT_SQINTMOB);
>
> + /* WaMbcDriverBootEnable */
> I915_WRITE(GEN6_MBCTL, I915_READ(GEN6_MBCTL) |
> GEN6_MBCTL_ENABLE_BOOT_FETCH);
>
> --
> 1.7.11.4
>
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/intel-gfx
prev parent reply other threads:[~2012-10-31 12:40 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-10-26 16:34 [PATCH] drm/i915: implement WaMbcDriverBootEnable on Haswell Paulo Zanoni
2012-10-31 12:46 ` Jani Nikula [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87objilsgx.fsf@intel.com \
--to=jani.nikula@linux.intel.com \
--cc=intel-gfx@lists.freedesktop.org \
--cc=paulo.r.zanoni@intel.com \
--cc=przanoni@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.