From: "Aneesh Kumar K.V" <aneesh.kumar-23VcF4HTsmIX0ybBhKVfKdBPR1lH4CV8@public.gmane.org>
To: Glauber Costa <glommer-bzQdu9zFT3WakBO8gow8eQ@public.gmane.org>
Cc: linux-mm-Bw31MaZKKs3YtjvyW6yDsg@public.gmane.org,
mgorman-l3A5Bk7waGM@public.gmane.org,
kamezawa.hiroyu-+CUm20s59erQFUHtdCDX3A@public.gmane.org,
dhillf-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org,
aarcange-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org,
mhocko-AlSwsSmVLrQ@public.gmane.org,
akpm-de/tnXTf+JLsfHDXvbKv3WD2FQJk+8+b@public.gmane.org,
hannes-druUgvl0LCNAfugRpC6u6w@public.gmane.org,
linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
cgroups-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: [PATCH -V3 4/8] memcg: track resource index in cftype private
Date: Wed, 14 Mar 2012 16:18:44 +0530 [thread overview]
Message-ID: <87obrz8nlf.fsf@linux.vnet.ibm.com> (raw)
In-Reply-To: <4F5F4CD0.3080207-bzQdu9zFT3WakBO8gow8eQ@public.gmane.org>
On Tue, 13 Mar 2012 17:34:08 +0400, Glauber Costa <glommer-bzQdu9zFT3WakBO8gow8eQ@public.gmane.org> wrote:
> On 03/13/2012 11:07 AM, Aneesh Kumar K.V wrote:
> > if (type == _MEM)
> > ret = mem_cgroup_resize_limit(memcg, val);
> > - else
> > + else if (type == _MEMHUGETLB) {
> > + int idx = MEMFILE_IDX(cft->private);
> > + ret = res_counter_set_limit(&memcg->hugepage[idx], val);
> > + } else
> > ret = mem_cgroup_resize_memsw_limit(memcg, val);
> > break;
> > case RES_SOFT_LIMIT:
>
> What if a user try to set limit < usage ? Isn't there any reclaim that
> we could possibly do, like it is done by normal memcg ?
No, HugeTLB doesn't support reclaim. If we set the limit to a value
below current usage, future allocations will fail, but we don't reclaim.
-aneesh
WARNING: multiple messages have this Message-ID (diff)
From: "Aneesh Kumar K.V" <aneesh.kumar@linux.vnet.ibm.com>
To: Glauber Costa <glommer@parallels.com>
Cc: linux-mm@kvack.org, mgorman@suse.de,
kamezawa.hiroyu@jp.fujitsu.com, dhillf@gmail.com,
aarcange@redhat.com, mhocko@suse.cz, akpm@linux-foundation.org,
hannes@cmpxchg.org, linux-kernel@vger.kernel.org,
cgroups@vger.kernel.org
Subject: Re: [PATCH -V3 4/8] memcg: track resource index in cftype private
Date: Wed, 14 Mar 2012 16:18:44 +0530 [thread overview]
Message-ID: <87obrz8nlf.fsf@linux.vnet.ibm.com> (raw)
In-Reply-To: <4F5F4CD0.3080207@parallels.com>
On Tue, 13 Mar 2012 17:34:08 +0400, Glauber Costa <glommer@parallels.com> wrote:
> On 03/13/2012 11:07 AM, Aneesh Kumar K.V wrote:
> > if (type == _MEM)
> > ret = mem_cgroup_resize_limit(memcg, val);
> > - else
> > + else if (type == _MEMHUGETLB) {
> > + int idx = MEMFILE_IDX(cft->private);
> > + ret = res_counter_set_limit(&memcg->hugepage[idx], val);
> > + } else
> > ret = mem_cgroup_resize_memsw_limit(memcg, val);
> > break;
> > case RES_SOFT_LIMIT:
>
> What if a user try to set limit < usage ? Isn't there any reclaim that
> we could possibly do, like it is done by normal memcg ?
No, HugeTLB doesn't support reclaim. If we set the limit to a value
below current usage, future allocations will fail, but we don't reclaim.
-aneesh
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
WARNING: multiple messages have this Message-ID (diff)
From: "Aneesh Kumar K.V" <aneesh.kumar@linux.vnet.ibm.com>
To: Glauber Costa <glommer@parallels.com>
Cc: linux-mm@kvack.org, mgorman@suse.de,
kamezawa.hiroyu@jp.fujitsu.com, dhillf@gmail.com,
aarcange@redhat.com, mhocko@suse.cz, akpm@linux-foundation.org,
hannes@cmpxchg.org, linux-kernel@vger.kernel.org,
cgroups@vger.kernel.org
Subject: Re: [PATCH -V3 4/8] memcg: track resource index in cftype private
Date: Wed, 14 Mar 2012 16:18:44 +0530 [thread overview]
Message-ID: <87obrz8nlf.fsf@linux.vnet.ibm.com> (raw)
In-Reply-To: <4F5F4CD0.3080207@parallels.com>
On Tue, 13 Mar 2012 17:34:08 +0400, Glauber Costa <glommer@parallels.com> wrote:
> On 03/13/2012 11:07 AM, Aneesh Kumar K.V wrote:
> > if (type == _MEM)
> > ret = mem_cgroup_resize_limit(memcg, val);
> > - else
> > + else if (type == _MEMHUGETLB) {
> > + int idx = MEMFILE_IDX(cft->private);
> > + ret = res_counter_set_limit(&memcg->hugepage[idx], val);
> > + } else
> > ret = mem_cgroup_resize_memsw_limit(memcg, val);
> > break;
> > case RES_SOFT_LIMIT:
>
> What if a user try to set limit < usage ? Isn't there any reclaim that
> we could possibly do, like it is done by normal memcg ?
No, HugeTLB doesn't support reclaim. If we set the limit to a value
below current usage, future allocations will fail, but we don't reclaim.
-aneesh
next prev parent reply other threads:[~2012-03-14 10:48 UTC|newest]
Thread overview: 69+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-03-13 7:07 [PATCH -V3 0/8] memcg: Add memcg extension to control HugeTLB allocation Aneesh Kumar K.V
2012-03-13 7:07 ` Aneesh Kumar K.V
2012-03-13 7:07 ` [PATCH -V3 1/8] hugetlb: rename max_hstate to hugetlb_max_hstate Aneesh Kumar K.V
2012-03-13 7:07 ` Aneesh Kumar K.V
[not found] ` <1331622432-24683-2-git-send-email-aneesh.kumar-23VcF4HTsmIX0ybBhKVfKdBPR1lH4CV8@public.gmane.org>
2012-03-13 13:13 ` Hillf Danton
2012-03-13 13:13 ` Hillf Danton
2012-03-13 13:13 ` Hillf Danton
2012-03-13 7:07 ` [PATCH -V3 2/8] memcg: Add HugeTLB extension Aneesh Kumar K.V
2012-03-13 7:07 ` Aneesh Kumar K.V
2012-03-13 13:28 ` Glauber Costa
2012-03-13 13:42 ` Glauber Costa
2012-03-13 21:33 ` Andrew Morton
2012-03-13 21:33 ` Andrew Morton
2012-03-14 10:21 ` Aneesh Kumar K.V
2012-03-14 10:21 ` Aneesh Kumar K.V
[not found] ` <87zkbj8ou9.fsf-23VcF4HTsmIX0ybBhKVfKdBPR1lH4CV8@public.gmane.org>
2012-03-14 23:43 ` Andrew Morton
2012-03-14 23:43 ` Andrew Morton
2012-03-14 23:43 ` Andrew Morton
2012-03-13 7:07 ` [PATCH -V3 3/8] hugetlb: add charge/uncharge calls for HugeTLB alloc/free Aneesh Kumar K.V
2012-03-13 7:07 ` Aneesh Kumar K.V
2012-03-13 13:20 ` Hillf Danton
2012-03-13 13:20 ` Hillf Danton
[not found] ` <CAJd=RBAHYi-BOXBO+u0u9-C=35Lu=ow=L77w2WSsndUBxVKf9w-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2012-03-14 10:22 ` Aneesh Kumar K.V
2012-03-14 10:22 ` Aneesh Kumar K.V
2012-03-14 10:22 ` Aneesh Kumar K.V
2012-03-13 13:31 ` Glauber Costa
[not found] ` <4F5F4C48.8050001-bzQdu9zFT3WakBO8gow8eQ@public.gmane.org>
2012-03-14 10:41 ` Aneesh Kumar K.V
2012-03-14 10:41 ` Aneesh Kumar K.V
2012-03-14 10:41 ` Aneesh Kumar K.V
[not found] ` <1331622432-24683-4-git-send-email-aneesh.kumar-23VcF4HTsmIX0ybBhKVfKdBPR1lH4CV8@public.gmane.org>
2012-03-13 21:36 ` Andrew Morton
2012-03-13 21:36 ` Andrew Morton
2012-03-13 21:36 ` Andrew Morton
[not found] ` <20120313143654.5dd1243d.akpm-de/tnXTf+JLsfHDXvbKv3WD2FQJk+8+b@public.gmane.org>
2012-03-14 10:47 ` Aneesh Kumar K.V
2012-03-14 10:47 ` Aneesh Kumar K.V
2012-03-14 10:47 ` Aneesh Kumar K.V
2012-03-13 7:07 ` [PATCH -V3 4/8] memcg: track resource index in cftype private Aneesh Kumar K.V
2012-03-13 7:07 ` Aneesh Kumar K.V
2012-03-13 13:34 ` Glauber Costa
[not found] ` <4F5F4CD0.3080207-bzQdu9zFT3WakBO8gow8eQ@public.gmane.org>
2012-03-14 10:48 ` Aneesh Kumar K.V [this message]
2012-03-14 10:48 ` Aneesh Kumar K.V
2012-03-14 10:48 ` Aneesh Kumar K.V
2012-03-13 7:07 ` [PATCH -V3 5/8] hugetlbfs: Add memcg control files for hugetlbfs Aneesh Kumar K.V
2012-03-13 7:07 ` Aneesh Kumar K.V
[not found] ` <1331622432-24683-6-git-send-email-aneesh.kumar-23VcF4HTsmIX0ybBhKVfKdBPR1lH4CV8@public.gmane.org>
2012-03-13 21:42 ` Andrew Morton
2012-03-13 21:42 ` Andrew Morton
2012-03-13 21:42 ` Andrew Morton
2012-03-14 11:10 ` Aneesh Kumar K.V
2012-03-14 11:10 ` Aneesh Kumar K.V
2012-03-14 11:35 ` Andrew Morton
2012-03-14 11:35 ` Andrew Morton
[not found] ` <20120314043530.d6f3d424.akpm-de/tnXTf+JLsfHDXvbKv3WD2FQJk+8+b@public.gmane.org>
2012-03-14 15:57 ` Aneesh Kumar K.V
2012-03-14 15:57 ` Aneesh Kumar K.V
2012-03-14 15:57 ` Aneesh Kumar K.V
2012-03-13 7:07 ` [PATCH -V3 6/8] hugetlbfs: Add a list for tracking in-use HugeTLB pages Aneesh Kumar K.V
2012-03-13 7:07 ` Aneesh Kumar K.V
2012-03-13 7:07 ` [PATCH -V3 7/8] memcg: move HugeTLB resource count to parent cgroup on memcg removal Aneesh Kumar K.V
2012-03-13 7:07 ` Aneesh Kumar K.V
[not found] ` <1331622432-24683-8-git-send-email-aneesh.kumar-23VcF4HTsmIX0ybBhKVfKdBPR1lH4CV8@public.gmane.org>
2012-03-13 21:47 ` Andrew Morton
2012-03-13 21:47 ` Andrew Morton
2012-03-13 21:47 ` Andrew Morton
2012-03-14 12:22 ` Aneesh Kumar K.V
2012-03-14 12:22 ` Aneesh Kumar K.V
2012-03-13 7:07 ` [PATCH -V3 8/8] memcg: Add memory controller documentation for hugetlb management Aneesh Kumar K.V
2012-03-13 7:07 ` Aneesh Kumar K.V
[not found] ` <1331622432-24683-1-git-send-email-aneesh.kumar-23VcF4HTsmIX0ybBhKVfKdBPR1lH4CV8@public.gmane.org>
2012-03-13 21:49 ` [PATCH -V3 0/8] memcg: Add memcg extension to control HugeTLB allocation Andrew Morton
2012-03-13 21:49 ` Andrew Morton
2012-03-13 21:49 ` Andrew Morton
2012-03-14 13:01 ` Aneesh Kumar K.V
2012-03-14 13:01 ` Aneesh Kumar K.V
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87obrz8nlf.fsf@linux.vnet.ibm.com \
--to=aneesh.kumar-23vcf4htsmix0ybbhkvfkdbpr1lh4cv8@public.gmane.org \
--cc=aarcange-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org \
--cc=akpm-de/tnXTf+JLsfHDXvbKv3WD2FQJk+8+b@public.gmane.org \
--cc=cgroups-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=dhillf-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
--cc=glommer-bzQdu9zFT3WakBO8gow8eQ@public.gmane.org \
--cc=hannes-druUgvl0LCNAfugRpC6u6w@public.gmane.org \
--cc=kamezawa.hiroyu-+CUm20s59erQFUHtdCDX3A@public.gmane.org \
--cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-mm-Bw31MaZKKs3YtjvyW6yDsg@public.gmane.org \
--cc=mgorman-l3A5Bk7waGM@public.gmane.org \
--cc=mhocko-AlSwsSmVLrQ@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.