[PATCH RESEND] [ARM] msm: compilation fix for arch/arm/mach-msm/vreg.c

[PATCH RESEND] [ARM] msm: compilation fix for arch/arm/mach-msm/vreg.c

[JJ Ding]

From: JJ Ding <dgdunix@gmail.com>

Include linux/export.h to fix the following when CONFIG_DEBUG_FS=y.

  CC      arch/arm/mach-msm/vreg.o
arch/arm/mach-msm/vreg.c:190: error: 'THIS_MODULE' undeclared here (not in a function)
make[2]: *** [arch/arm/mach-msm/vreg.o] Error 1
make[1]: *** [arch/arm/mach-msm] Error 2
make: *** [sub-make] Error 2

Signed-off-by: JJ Ding <dgdunix@gmail.com>
---
Hi all,

Sorry for the wrong sender field in last mail.
Here is the correct version.

Thanks,
jj

 arch/arm/mach-msm/vreg.c |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)

diff --git a/arch/arm/mach-msm/vreg.c b/arch/arm/mach-msm/vreg.c
index a9103bc..e87792b 100644
--- a/arch/arm/mach-msm/vreg.c
+++ b/arch/arm/mach-msm/vreg.c
@@ -20,6 +20,7 @@
 #include <linux/init.h>
 #include <linux/debugfs.h>
 #include <linux/string.h>
+#include <linux/export.h>
 #include <mach/vreg.h>
 
 #include "proc_comm.h"
-- 
1.7.8

Re: [PATCH RESEND] [ARM] msm: compilation fix for arch/arm/mach-msm/vreg.c

[David Brown]

On Tue, Jan 10, 2012 at 03:35:59PM +0800, JJ Ding wrote:

> diff --git a/arch/arm/mach-msm/vreg.c b/arch/arm/mach-msm/vreg.c
> index a9103bc..e87792b 100644
> --- a/arch/arm/mach-msm/vreg.c
> +++ b/arch/arm/mach-msm/vreg.c
> @@ -20,6 +20,7 @@
>  #include <linux/init.h>
>  #include <linux/debugfs.h>
>  #include <linux/string.h>
> +#include <linux/export.h>
>  #include <mach/vreg.h>
>  
>  #include "proc_comm.h"

Thanks for the patch, although I just submitted a pull request
containing a very similar fix:

  http://article.gmane.org/gmane.linux.ports.arm.msm/2289

David

-- 
Sent by an employee of the Qualcomm Innovation Center, Inc.
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum.

Re: [PATCH RESEND] [ARM] msm: compilation fix for arch/arm/mach-msm/vreg.c

[JJ Ding]

Hi David,

On Tue, 10 Jan 2012 08:57:40 -0800, David Brown <davidb@codeaurora.org> wrote:
> On Tue, Jan 10, 2012 at 03:35:59PM +0800, JJ Ding wrote:
> 
> > diff --git a/arch/arm/mach-msm/vreg.c b/arch/arm/mach-msm/vreg.c
> > index a9103bc..e87792b 100644
> > --- a/arch/arm/mach-msm/vreg.c
> > +++ b/arch/arm/mach-msm/vreg.c
> > @@ -20,6 +20,7 @@
> >  #include <linux/init.h>
> >  #include <linux/debugfs.h>
> >  #include <linux/string.h>
> > +#include <linux/export.h>
> >  #include <mach/vreg.h>
> >  
> >  #include "proc_comm.h"
> 
> Thanks for the patch, although I just submitted a pull request
> containing a very similar fix:
> 
>   http://article.gmane.org/gmane.linux.ports.arm.msm/2289

I am not subscribed to this list and happen to run into this.
Thanks for pointing me at this.

jj

> David
> 
> -- 
> Sent by an employee of the Qualcomm Innovation Center, Inc.
> The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum.

Re: [PATCH RESEND] [ARM] msm: compilation fix for arch/arm/mach-msm/vreg.c

[David Brown]

On Wed, Jan 11, 2012 at 09:06:02AM +0800, JJ Ding wrote:

> > Thanks for the patch, although I just submitted a pull request
> > containing a very similar fix:
> > 
> >   http://article.gmane.org/gmane.linux.ports.arm.msm/2289
> 
> I am not subscribed to this list and happen to run into this.
> Thanks for pointing me at this.

I also CC'd the arm-linux-kernel and linux-kernel lists.  They're high
traffic, though, so it's easy to miss things.

David

-- 
Sent by an employee of the Qualcomm Innovation Center, Inc.
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum.