From: Rusty Russell <rusty@rustcorp.com.au>
Cc: Amit Shah <amit.shah@redhat.com>,
Virtualization List <virtualization@lists.linux-foundation.org>,
miche@google.com, "Michael S. Tsirkin" <mst@redhat.com>
Subject: Re: [PATCH 0/2] virtio: console: control queue race fixes
Date: Mon, 09 Jan 2012 13:01:15 +1030 [thread overview]
Message-ID: <87obuda9os.fsf@rustcorp.com.au> (raw)
In-Reply-To: <cover.1325845993.git.amit.shah@redhat.com>
On Fri, 6 Jan 2012 16:19:06 +0530, Amit Shah <amit.shah@redhat.com> wrote:
> Hello,
>
> The first patch here fixes the race seen by Miche. He hasn't yet
> reported back if this fixes the races he saw, but Joy Pu from Red Hat
> tested this patch with hot-plugging/unplugging ports in a loop.
> Before this patch, he saw some freezes as well as sysfs warnings.
> After applying the patch, all was well.
So, the first one should be cc: stable?
> The second patch can be folded into the series fixing S4 for
> virtio-console. It ensures all callbacks are disabled in the freeze
> function. This patch has a dependency on the 1st one in the sense the
> double disabling of vq won't make sense w/o patch 1.
>
> Please review and apply.
Done, thanks.
Cheers,
Rusty.
prev parent reply other threads:[~2012-01-09 2:31 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-01-06 10:49 [PATCH 0/2] virtio: console: control queue race fixes Amit Shah
2012-01-06 10:49 ` [PATCH 1/2] virtio: console: Serialise control work Amit Shah
2012-01-09 2:33 ` Rusty Russell
2012-01-09 3:53 ` Amit Shah
2012-01-06 10:49 ` [PATCH 2/2] virtio: console: Disable callbacks for virtqueues at start of S4 freeze Amit Shah
2012-01-09 2:31 ` Rusty Russell [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87obuda9os.fsf@rustcorp.com.au \
--to=rusty@rustcorp.com.au \
--cc=amit.shah@redhat.com \
--cc=miche@google.com \
--cc=mst@redhat.com \
--cc=virtualization@lists.linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.