All of lore.kernel.org
 help / color / mirror / Atom feed
From: Kevin Hilman <khilman@ti.com>
To: jean.pihet@newoldbits.com
Cc: linux-arm-kernel@lists.infradead.org, linux-omap@vger.kernel.org,
	Tony Lindgren <tony@atomide.com>, Jean Pihet <j-pihet@ti.com>
Subject: Re: [PATCH 1/5] OMAP3 cpuidle: remove useless SDP specific timings
Date: Wed, 04 May 2011 07:40:01 -0700	[thread overview]
Message-ID: <87oc3iv8am.fsf@ti.com> (raw)
In-Reply-To: <1304069186-3086-2-git-send-email-j-pihet@ti.com> (jean pihet's message of "Fri, 29 Apr 2011 11:26:22 +0200")

jean.pihet@newoldbits.com writes:

> From: Jean Pihet <j-pihet@ti.com>
>
> The cpuidle states settings can be overriden by some board-
> specific settings, by calling omap3_pm_init_cpuidle.
> Remove the 3430SDP specific states settings registration
> since the figures are identical to the default ones (in cpuidle34xx.c).
>
> Signed-off-by: Jean Pihet <j-pihet@ti.com>

Thanks,  queuing for 2.6.40 (branch: for_2.6.40/pm-cleanup)

Kevin

> ---
>  arch/arm/mach-omap2/board-3430sdp.c |   19 -------------------
>  1 files changed, 0 insertions(+), 19 deletions(-)
>
> diff --git a/arch/arm/mach-omap2/board-3430sdp.c b/arch/arm/mach-omap2/board-3430sdp.c
> index 9afd087..7ffad7b 100644
> --- a/arch/arm/mach-omap2/board-3430sdp.c
> +++ b/arch/arm/mach-omap2/board-3430sdp.c
> @@ -59,24 +59,6 @@
>  
>  #define TWL4030_MSECURE_GPIO 22
>  
> -/* FIXME: These values need to be updated based on more profiling on 3430sdp*/
> -static struct cpuidle_params omap3_cpuidle_params_table[] = {
> -	/* C1 */
> -	{1, 2, 2, 5},
> -	/* C2 */
> -	{1, 10, 10, 30},
> -	/* C3 */
> -	{1, 50, 50, 300},
> -	/* C4 */
> -	{1, 1500, 1800, 4000},
> -	/* C5 */
> -	{1, 2500, 7500, 12000},
> -	/* C6 */
> -	{1, 3000, 8500, 15000},
> -	/* C7 */
> -	{1, 10000, 30000, 300000},
> -};
> -
>  static uint32_t board_keymap[] = {
>  	KEY(0, 0, KEY_LEFT),
>  	KEY(0, 1, KEY_RIGHT),
> @@ -883,7 +865,6 @@ static void __init omap_3430sdp_init(void)
>  	omap3_mux_init(board_mux, OMAP_PACKAGE_CBB);
>  	omap_board_config = sdp3430_config;
>  	omap_board_config_size = ARRAY_SIZE(sdp3430_config);
> -	omap3_pm_init_cpuidle(omap3_cpuidle_params_table);
>  	omap3430_i2c_init();
>  	omap_display_init(&sdp3430_dss_data);
>  	if (omap_rev() > OMAP3430_REV_ES1_0)

WARNING: multiple messages have this Message-ID (diff)
From: khilman@ti.com (Kevin Hilman)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 1/5] OMAP3 cpuidle: remove useless SDP specific timings
Date: Wed, 04 May 2011 07:40:01 -0700	[thread overview]
Message-ID: <87oc3iv8am.fsf@ti.com> (raw)
In-Reply-To: <1304069186-3086-2-git-send-email-j-pihet@ti.com> (jean pihet's message of "Fri, 29 Apr 2011 11:26:22 +0200")

jean.pihet at newoldbits.com writes:

> From: Jean Pihet <j-pihet@ti.com>
>
> The cpuidle states settings can be overriden by some board-
> specific settings, by calling omap3_pm_init_cpuidle.
> Remove the 3430SDP specific states settings registration
> since the figures are identical to the default ones (in cpuidle34xx.c).
>
> Signed-off-by: Jean Pihet <j-pihet@ti.com>

Thanks,  queuing for 2.6.40 (branch: for_2.6.40/pm-cleanup)

Kevin

> ---
>  arch/arm/mach-omap2/board-3430sdp.c |   19 -------------------
>  1 files changed, 0 insertions(+), 19 deletions(-)
>
> diff --git a/arch/arm/mach-omap2/board-3430sdp.c b/arch/arm/mach-omap2/board-3430sdp.c
> index 9afd087..7ffad7b 100644
> --- a/arch/arm/mach-omap2/board-3430sdp.c
> +++ b/arch/arm/mach-omap2/board-3430sdp.c
> @@ -59,24 +59,6 @@
>  
>  #define TWL4030_MSECURE_GPIO 22
>  
> -/* FIXME: These values need to be updated based on more profiling on 3430sdp*/
> -static struct cpuidle_params omap3_cpuidle_params_table[] = {
> -	/* C1 */
> -	{1, 2, 2, 5},
> -	/* C2 */
> -	{1, 10, 10, 30},
> -	/* C3 */
> -	{1, 50, 50, 300},
> -	/* C4 */
> -	{1, 1500, 1800, 4000},
> -	/* C5 */
> -	{1, 2500, 7500, 12000},
> -	/* C6 */
> -	{1, 3000, 8500, 15000},
> -	/* C7 */
> -	{1, 10000, 30000, 300000},
> -};
> -
>  static uint32_t board_keymap[] = {
>  	KEY(0, 0, KEY_LEFT),
>  	KEY(0, 1, KEY_RIGHT),
> @@ -883,7 +865,6 @@ static void __init omap_3430sdp_init(void)
>  	omap3_mux_init(board_mux, OMAP_PACKAGE_CBB);
>  	omap_board_config = sdp3430_config;
>  	omap_board_config_size = ARRAY_SIZE(sdp3430_config);
> -	omap3_pm_init_cpuidle(omap3_cpuidle_params_table);
>  	omap3430_i2c_init();
>  	omap_display_init(&sdp3430_dss_data);
>  	if (omap_rev() > OMAP3430_REV_ES1_0)

  parent reply	other threads:[~2011-05-04 14:40 UTC|newest]

Thread overview: 28+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-04-29  9:26 [PATCH 0/5] OMAP: cpuidle code clean-up jean.pihet
2011-04-29  9:26 ` jean.pihet at newoldbits.com
2011-04-29  9:26 ` [PATCH 1/5] OMAP3 cpuidle: remove useless SDP specific timings jean.pihet
2011-04-29  9:26   ` jean.pihet at newoldbits.com
2011-04-29 11:14   ` Santosh Shilimkar
2011-04-29 11:14     ` Santosh Shilimkar
2011-05-04 14:40   ` Kevin Hilman [this message]
2011-05-04 14:40     ` Kevin Hilman
2011-04-29  9:26 ` [PATCH 2/5] OMAP3: clean-up mach specific cpuidle data structures jean.pihet
2011-04-29  9:26   ` jean.pihet at newoldbits.com
2011-05-04 20:09   ` Kevin Hilman
2011-05-04 20:09     ` Kevin Hilman
2011-04-29  9:26 ` [PATCH 3/5] OMAP3: cpuidle: re-organize the C-states data jean.pihet
2011-04-29  9:26   ` jean.pihet at newoldbits.com
2011-04-29 11:24   ` Santosh Shilimkar
2011-04-29 11:24     ` Santosh Shilimkar
2011-05-04 14:59   ` Kevin Hilman
2011-05-04 14:59     ` Kevin Hilman
2011-04-29  9:26 ` [PATCH 4/5] OMAP3: cpuidle: code rework for improved readability jean.pihet
2011-04-29  9:26   ` jean.pihet at newoldbits.com
2011-05-04 15:32   ` Kevin Hilman
2011-05-04 15:32     ` Kevin Hilman
2011-04-29  9:26 ` [PATCH 5/5] OMAP3: cpuidle: change the power domains modes determination logic jean.pihet
2011-04-29  9:26   ` jean.pihet at newoldbits.com
2011-04-29 11:29   ` Santosh Shilimkar
2011-04-29 11:29     ` Santosh Shilimkar
2011-04-29 14:00     ` Jean Pihet
2011-04-29 14:00       ` Jean Pihet

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87oc3iv8am.fsf@ti.com \
    --to=khilman@ti.com \
    --cc=j-pihet@ti.com \
    --cc=jean.pihet@newoldbits.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-omap@vger.kernel.org \
    --cc=tony@atomide.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.