All of lore.kernel.org
 help / color / mirror / Atom feed
From: arnaud.patard@rtp-net.org (Arnaud Patard (Rtp))
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v4 5/8] arm: mxc: move IOMUX_CONFIG_XXXX definitions to iomux-v3.h
Date: Thu, 06 Jan 2011 11:41:55 +0100	[thread overview]
Message-ID: <87oc7u71qk.fsf@lechat.rtp-net.org> (raw)
In-Reply-To: <20110106101639.GE26009@pengutronix.de> (Sascha Hauer's message of "Thu, 6 Jan 2011 11:16:39 +0100")

Sascha Hauer <s.hauer@pengutronix.de> writes:
Hi,

> On Thu, Jan 06, 2011 at 02:59:36PM +0800, Richard Zhao wrote:
>> Hello Sascha,
>> 
>> On Thu, Dec 30, 2010 at 07:25:04PM +0800, Richard Zhao wrote:
>> > IOMUX_CONFIG_GPIO is not for iomux-v3. It's for old freescale
>> > iomux routines. Remove it.
>> > 
>> > Signed-off-by: Richard Zhao <richard.zhao@freescale.com>
>> > Acked-by: Uwe Kleine-K?nig <u.kleine-koenig@pengutronix.de>
>> If you don't have comments, could you please merge this patch?
>> It's causing arch/arm/plat-mxc/include/mach/iomux-mx50.h incomplete.
>
> I didn't apply it because it conflicts with current imx-for-2.6.38
> branch. Other than that I don't find the enum very useful at all,
> because we have problems with very long lines in these files and
> using IOMUX_CONFIG_ALT0 where we could use 0 does not exactly improve
> the situation.

While I agree with this, there's a small exception. I found out
yesterday that now, there's no more any macro/enum defined for the
infamous SION bit. Theses means that currently to defined a PAD with
SION bit set, we have to create a new macro with IOMUX_PAD instead
of using the _MX51_PAD_* macro as basis. Did I miss something ?

Arnaud

      parent reply	other threads:[~2011-01-06 10:41 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-12-30 11:25 [PATCH v4 1/8] ARM: mx5: use config to define boot related addresses Richard Zhao
2010-12-30 11:25 ` [PATCH v4 2/8] arm: plat-mxc: add full parameter macro to define gpio port Richard Zhao
2010-12-30 11:25   ` [PATCH v4 3/8] arm: mx51: define mx51's own MXC_GPIO_IRQS Richard Zhao
2010-12-30 11:25     ` [PATCH v4 4/8] arm: mx5: mx51/53 have different mxc_cpu_type definition Richard Zhao
2010-12-30 11:25       ` [PATCH v4 5/8] arm: mxc: move IOMUX_CONFIG_XXXX definitions to iomux-v3.h Richard Zhao
2010-12-30 11:25         ` [PATCH v4 6/8] arm: mx50: add core functions support except clock Richard Zhao
2010-12-30 11:25           ` [PATCH v4 7/8] arm: mx50: add mx50 reference design board support Richard Zhao
2011-01-06  6:59         ` [PATCH v4 5/8] arm: mxc: move IOMUX_CONFIG_XXXX definitions to iomux-v3.h Richard Zhao
2011-01-06 10:16           ` Sascha Hauer
2011-01-06 10:29             ` Richard Zhao
2011-01-06 10:32               ` Sascha Hauer
2011-01-06 10:43                 ` Richard Zhao
2011-01-06 10:41             ` Arnaud Patard (Rtp) [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87oc7u71qk.fsf@lechat.rtp-net.org \
    --to=arnaud.patard@rtp-net.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.