Re: [PATCH] Fix suspend/resume of pxa_camera driver

[Robert Jarzmik <robert.jarzmik@free.fr>]

Guennadi Liakhovetski <g.liakhovetski@gmx.de> writes:

> On Sat, 2 Aug 2008, Robert Jarzmik wrote:
>
>> PXA suspend switches off DMA core, which loses all context
>> of previously assigned descriptors. As pxa_camera driver
>> relies on DMA transfers, setup the lost descriptors on
>> resume and retrigger frame acquisition if needed.
>> 
>> Signed-off-by: Robert Jarzmik <robert.jarzmik@free.fr>
>
> _Conditionally_ applied: I changed the subject to "Add suspend/resume 
> to...", upgraded to the current Linus' top-of-tree, and, most importantly, 
> changed this:
OK.

>> +	if ((pcdev->icd) && (pcdev->icd->ops->resume))
>> +		ret = pcdev->icd->ops->resume(pcdev->icd);
>
> To 
>
>
> Which I assume was a typo. Please, test these patches with this my change, 
> and confirm they are ok now. I'll push both of them upstream then.

To be exact: wrong copy/paste. I'm sorry not have spotted this, I have no
suspend function in mt9m111, I only used the resume one to restore the state ...

And the two lines should be :
+	if ((pcdev->icd) && (pcdev->icd->ops->suspend))
+		ret = pcdev->icd->ops->suspend(pcdev->icd, state);
                                                           ^
                                                           compile error without

Apart from that, I tested, and it's OK.

Do you have an exported git tree I can sync with ?

--
Robert

--
video4linux-list mailing list
Unsubscribe mailto:video4linux-list-request@redhat.com?subject=unsubscribe
https://www.redhat.com/mailman/listinfo/video4linux-list