From: Mathieu SEGAUD <mathieu.segaud@regala.cx>
To: Matthew Wilcox <matthew@wil.cx>
Cc: James.Bottomley@HansenPartnership.com,
linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Convert drivers/scsi/ch.c to use unlocked_ioctl
Date: Mon, 14 Jan 2008 15:22:42 +0100 [thread overview]
Message-ID: <87odbotrkd.fsf@barad-dur.regala.cx> (raw)
In-Reply-To: <20080114141854.GJ18741@parisc-linux.org> (Matthew Wilcox's message of "Mon\, 14 Jan 2008 07\:18\:54 -0700")
Vous m'avez dit récemment :
> On Mon, Jan 14, 2008 at 02:32:13PM +0100, Mathieu Segaud wrote:
>> +#include <linux/smp_lock.h>
> You don't add any uses of lock_kernel() and there are none in the
> driver currently.
yep, it was before I noticed the locking semantics of
ch_ioctl_compat()
>> - .owner = THIS_MODULE,
>> - .open = ch_open,
>> - .release = ch_release,
>> - .ioctl = ch_ioctl,
>> + .owner = THIS_MODULE,
>> + .open = ch_open,
>> + .release = ch_release,
>> + .unlocked_ioctl = ch_ioctl,
>
> If you're going to do the gratuitous reformatting, at least use tabs
> instead of spaces.
thanks, will do
> Other than that, should be fine.
I repost this one
thanks a lot.
--
Mathieu
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
WARNING: multiple messages have this Message-ID (diff)
From: Mathieu SEGAUD <mathieu.segaud@regala.cx>
To: Matthew Wilcox <matthew@wil.cx>
Cc: James.Bottomley@HansenPartnership.com,
linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Convert drivers/scsi/ch.c to use unlocked_ioctl
Date: Mon, 14 Jan 2008 15:22:42 +0100 [thread overview]
Message-ID: <87odbotrkd.fsf@barad-dur.regala.cx> (raw)
In-Reply-To: <20080114141854.GJ18741@parisc-linux.org> (Matthew Wilcox's message of "Mon\, 14 Jan 2008 07\:18\:54 -0700")
Vous m'avez dit récemment :
> On Mon, Jan 14, 2008 at 02:32:13PM +0100, Mathieu Segaud wrote:
>> +#include <linux/smp_lock.h>
> You don't add any uses of lock_kernel() and there are none in the
> driver currently.
yep, it was before I noticed the locking semantics of
ch_ioctl_compat()
>> - .owner = THIS_MODULE,
>> - .open = ch_open,
>> - .release = ch_release,
>> - .ioctl = ch_ioctl,
>> + .owner = THIS_MODULE,
>> + .open = ch_open,
>> + .release = ch_release,
>> + .unlocked_ioctl = ch_ioctl,
>
> If you're going to do the gratuitous reformatting, at least use tabs
> instead of spaces.
thanks, will do
> Other than that, should be fine.
I repost this one
thanks a lot.
--
Mathieu
next prev parent reply other threads:[~2008-01-14 14:22 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-01-14 13:32 [PATCH] Convert drivers/scsi/ch.c to use unlocked_ioctl Mathieu Segaud
2008-01-14 14:18 ` Matthew Wilcox
2008-01-14 14:22 ` Mathieu SEGAUD [this message]
2008-01-14 14:22 ` Mathieu SEGAUD
-- strict thread matches above, loose matches on Subject: below --
2008-01-14 14:31 Mathieu Segaud
2008-01-14 14:37 ` Matthew Wilcox
2008-01-14 14:43 Mathieu Segaud
2008-01-14 15:21 Mathieu Segaud
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87odbotrkd.fsf@barad-dur.regala.cx \
--to=mathieu.segaud@regala.cx \
--cc=James.Bottomley@HansenPartnership.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=matthew@wil.cx \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.