Re: Partition modules

[Marco Gerards <metgerards@student.han.nl>]

Hollis Blanchard <hollis@penguinppc.org> writes:

> I do have an objection here: members like "bsd_type" don't belong in a
> generic struct, but rather in grub_partition_bsd_type. I believe
> grub_partition should be the abstraction, i.e. what defines a
> partition in the general sense. start, len, and index are obviously
> good; offset is compensating for a DOS issue, though at least it has
> (irrelevant) meaning for an Apple map... but ext_offset and these dos_
> and bsd_ things don't belong here IMHO.

Ok.

> Also, there were a number of whitespace-only lines in your patch; a
> simple regex should show you where.

Ok.

> I'm seeing a crash on both briQ and my G3, so I'm sprinkling printfs
> now...

Does the PC partition map work on the briQ now?

Thanks,
Marco