* pinctrl-sunxi dovetail changes
@ 2026-11-11 12:29 Jan Kiszka
2026-11-11 17:47 ` Philippe Gerum
0 siblings, 1 reply; 3+ messages in thread
From: Jan Kiszka @ 2026-11-11 12:29 UTC (permalink / raw)
To: Philippe Gerum; +Cc: Xenomai
Hi Philippe,
the LLM considers this pattern unusual:
diff --git a/drivers/pinctrl/sunxi/pinctrl-sunxi.c b/drivers/pinctrl/sunxi/pinctrl-sunxi.c
index 31cd142ce0f79..fb73cdaa30ca4 100644
--- a/drivers/pinctrl/sunxi/pinctrl-sunxi.c
+++ b/drivers/pinctrl/sunxi/pinctrl-sunxi.c
@@ -1280,7 +1280,7 @@ static struct irq_chip sunxi_pinctrl_edge_irq_chip = {
.irq_release_resources = sunxi_pinctrl_irq_release_resources,
.irq_set_type = sunxi_pinctrl_irq_set_type,
.irq_set_wake = sunxi_pinctrl_irq_set_wake,
- .flags = IRQCHIP_MASK_ON_SUSPEND,
+ .flags = IRQCHIP_SKIP_SET_WAKE | IRQCHIP_PIPELINE_SAFE,
};
static struct irq_chip sunxi_pinctrl_level_irq_chip = {
Since day #1 of the patch, we are dropping IRQCHIP_MASK_ON_SUSPEND and
setting IRQCHIP_SKIP_SET_WAKE instead. Do we need the latter? And do we
have to drop the former?
Jan
--
Siemens AG, Foundational Technologies
Linux Expert Center
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: pinctrl-sunxi dovetail changes
2026-11-11 12:29 pinctrl-sunxi dovetail changes Jan Kiszka
@ 2026-11-11 17:47 ` Philippe Gerum
2026-11-11 17:54 ` Jan Kiszka
0 siblings, 1 reply; 3+ messages in thread
From: Philippe Gerum @ 2026-11-11 17:47 UTC (permalink / raw)
To: Jan Kiszka; +Cc: Xenomai
Jan Kiszka <jan.kiszka@siemens.com> writes:
> Hi Philippe,
>
> the LLM considers this pattern unusual:
>
> diff --git a/drivers/pinctrl/sunxi/pinctrl-sunxi.c b/drivers/pinctrl/sunxi/pinctrl-sunxi.c
> index 31cd142ce0f79..fb73cdaa30ca4 100644
> --- a/drivers/pinctrl/sunxi/pinctrl-sunxi.c
> +++ b/drivers/pinctrl/sunxi/pinctrl-sunxi.c
> @@ -1280,7 +1280,7 @@ static struct irq_chip sunxi_pinctrl_edge_irq_chip = {
> .irq_release_resources = sunxi_pinctrl_irq_release_resources,
> .irq_set_type = sunxi_pinctrl_irq_set_type,
> .irq_set_wake = sunxi_pinctrl_irq_set_wake,
> - .flags = IRQCHIP_MASK_ON_SUSPEND,
> + .flags = IRQCHIP_SKIP_SET_WAKE | IRQCHIP_PIPELINE_SAFE,
> };
>
> static struct irq_chip sunxi_pinctrl_level_irq_chip = {
>
> Since day #1 of the patch, we are dropping IRQCHIP_MASK_ON_SUSPEND and
> setting IRQCHIP_SKIP_SET_WAKE instead. Do we need the latter? And do we
> have to drop the former?
>
This looks suspicious, indeed. I don't see the reasoning here.
--
Philippe.
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: pinctrl-sunxi dovetail changes
2026-11-11 17:47 ` Philippe Gerum
@ 2026-11-11 17:54 ` Jan Kiszka
0 siblings, 0 replies; 3+ messages in thread
From: Jan Kiszka @ 2026-11-11 17:54 UTC (permalink / raw)
To: Philippe Gerum; +Cc: Xenomai
On 11.11.26 18:47, Philippe Gerum wrote:
> Jan Kiszka <jan.kiszka@siemens.com> writes:
>
>> Hi Philippe,
>>
>> the LLM considers this pattern unusual:
>>
>> diff --git a/drivers/pinctrl/sunxi/pinctrl-sunxi.c b/drivers/pinctrl/sunxi/pinctrl-sunxi.c
>> index 31cd142ce0f79..fb73cdaa30ca4 100644
>> --- a/drivers/pinctrl/sunxi/pinctrl-sunxi.c
>> +++ b/drivers/pinctrl/sunxi/pinctrl-sunxi.c
>> @@ -1280,7 +1280,7 @@ static struct irq_chip sunxi_pinctrl_edge_irq_chip = {
>> .irq_release_resources = sunxi_pinctrl_irq_release_resources,
>> .irq_set_type = sunxi_pinctrl_irq_set_type,
>> .irq_set_wake = sunxi_pinctrl_irq_set_wake,
>> - .flags = IRQCHIP_MASK_ON_SUSPEND,
>> + .flags = IRQCHIP_SKIP_SET_WAKE | IRQCHIP_PIPELINE_SAFE,
>> };
>>
>> static struct irq_chip sunxi_pinctrl_level_irq_chip = {
>>
>> Since day #1 of the patch, we are dropping IRQCHIP_MASK_ON_SUSPEND and
>> setting IRQCHIP_SKIP_SET_WAKE instead. Do we need the latter? And do we
>> have to drop the former?
>>
>
> This looks suspicious, indeed. I don't see the reasoning here.
>
OK, patch follows.
Jan
--
Siemens AG, Foundational Technologies
Linux Expert Center
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2026-11-11 17:54 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-11-11 12:29 pinctrl-sunxi dovetail changes Jan Kiszka
2026-11-11 17:47 ` Philippe Gerum
2026-11-11 17:54 ` Jan Kiszka
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.