From: Markus Armbruster <armbru@redhat.com>
To: John Snow <jsnow@redhat.com>
Cc: qemu-devel@nongnu.org, "Alex Bennée" <alex.bennee@linaro.org>,
"Peter Maydell" <peter.maydell@linaro.org>,
"Philippe Mathieu-Daudé" <philmd@mailo.com>,
"Warner Losh" <imp@bsdimp.com>,
"Kohei Tokunaga" <ktokunaga.mail@gmail.com>,
"Pierrick Bouvier" <pierrick.bouvier@oss.qualcomm.com>,
"Cleber Rosa" <crosa@redhat.com>,
"Paolo Bonzini" <pbonzini@redhat.com>,
"Reinoud Zandijk" <reinoud@netbsd.org>,
"Kyle Evans" <kevans@freebsd.org>,
"Michael Roth" <michael.roth@amd.com>,
"Marc-André Lureau" <marcandre.lureau@redhat.com>,
"Mauro Carvalho Chehab" <mchehab+huawei@kernel.org>
Subject: Re: [PATCH v2 16/16] sphinx: drop qapidoc back-compat overboiled spaghetti dinner
Date: Tue, 25 Aug 2026 08:54:47 +0200 [thread overview]
Message-ID: <87pkz6pu4o.fsf@pond.sub.org> (raw)
In-Reply-To: <20260825051441.1562454-17-jsnow@redhat.com> (John Snow's message of "Tue, 25 Aug 2026 01:14:41 -0400")
John Snow <jsnow@redhat.com> writes:
> Drop the disgusting amount of hacks required to keep qapidoc working
> on older Sphinx versions, enjoying the cutting edge technology of
> 2023.
>
> This felt like an achievement to have written, and equally feels an
> achievement to have deleted.
>
> A note on the content_node parameter: Sphinx has been gradually
> implementing typing support and renaming parameters to be
> consistent. As a result of losing our intermediate compatibility shim,
> mypy and pylint now check directly against the Sphinx version. So,
> alongside removing compat gunk, we need to fix up some parameter
> naming for the Sphinx upgrade, too.
>
> Signed-off-by: John Snow <jsnow@redhat.com>
> Reviewed-by: Marc-André Lureau <marcandre.lureau@redhat.com>
This repays the technical debt you had to take on to make the rewritten
Sphinx QAPI doc extension work, which massively improved the rendering
of QMP and QGA reference manuals. The impressive and ugly work goes,
the impressive and lovely work stays. Thank you!
Reviewed-by: Markus Armbruster <armbru@redhat.com>
prev parent reply other threads:[~2026-08-25 6:55 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-08-25 5:14 [PATCH v2 00/16] python: require python3.12+ John Snow
2026-08-25 5:14 ` [PATCH v2 01/16] tests: update vm tests to prefer locally-built QEMU John Snow
2026-08-25 6:41 ` Markus Armbruster
2026-08-25 8:30 ` Daniel P. Berrangé
2026-08-25 15:15 ` John Snow
2026-08-25 11:26 ` Daniel P. Berrangé
2026-08-25 5:14 ` [PATCH v2 02/16] tests: update FreeBSD dependencies John Snow
2026-08-25 11:08 ` Daniel P. Berrangé
2026-08-25 15:07 ` John Snow
2026-08-25 5:14 ` [PATCH v2 03/16] tests: update netbsd dependencies John Snow
2026-08-25 6:26 ` Marc-André Lureau
2026-08-25 11:09 ` Daniel P. Berrangé
2026-08-25 15:11 ` John Snow
2026-08-25 5:14 ` [PATCH v2 04/16] tests: drop python3-devel mapping John Snow
2026-08-25 8:32 ` Daniel P. Berrangé
2026-08-25 5:14 ` [PATCH v2 05/16] tests: re-add opencv2 and numpy dependencies John Snow
2026-08-25 5:14 ` [PATCH v2 06/16] tests: add Python3.12 to centos9.docker John Snow
2026-08-25 11:12 ` Daniel P. Berrangé
2026-08-25 5:14 ` [PATCH v2 07/16] tests: update emsdk-wasm64-cross John Snow
2026-08-25 5:14 ` [PATCH v2 08/16] qapi: update type hint for objects_seen John Snow
2026-08-25 5:14 ` [PATCH v2 09/16] python: upgrade to Python3.12+ John Snow
2026-08-25 11:14 ` Daniel P. Berrangé
2026-08-25 5:14 ` [PATCH v2 10/16] python: fix license configuration John Snow
2026-08-25 5:14 ` [PATCH v2 11/16] python: allow mypy to run as the current python version John Snow
2026-08-25 5:14 ` [PATCH v2 12/16] python: remove distutils workarounds John Snow
2026-08-25 5:14 ` [PATCH v2 13/16] python: remove stale setup.cfg options John Snow
2026-08-25 5:14 ` [PATCH v2 14/16] sphinx: require sphinx 7.2.6 John Snow
2026-08-25 5:14 ` [PATCH v2 15/16] sphinx: drop fakedbusdoc John Snow
2026-08-25 5:14 ` [PATCH v2 16/16] sphinx: drop qapidoc back-compat overboiled spaghetti dinner John Snow
2026-08-25 6:54 ` Markus Armbruster [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87pkz6pu4o.fsf@pond.sub.org \
--to=armbru@redhat.com \
--cc=alex.bennee@linaro.org \
--cc=crosa@redhat.com \
--cc=imp@bsdimp.com \
--cc=jsnow@redhat.com \
--cc=kevans@freebsd.org \
--cc=ktokunaga.mail@gmail.com \
--cc=marcandre.lureau@redhat.com \
--cc=mchehab+huawei@kernel.org \
--cc=michael.roth@amd.com \
--cc=pbonzini@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=philmd@mailo.com \
--cc=pierrick.bouvier@oss.qualcomm.com \
--cc=qemu-devel@nongnu.org \
--cc=reinoud@netbsd.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.