Re: [PATCH v2 01/16] tests: update vm tests to prefer locally-built QEMU

["Daniel P. Berrangé" <berrange@redhat.com>]

On Tue, Aug 25, 2026 at 08:41:53AM +0200, Markus Armbruster wrote:
> John Snow <jsnow@redhat.com> writes:
> 
> > In 05e4982, we updated our QMP tests to prefer `-object monitor-qmp`,
> > but this requires a sufficiently recent and modern version of QEMU to
> > run correctly.
> 
> So, some tests run incorrectly, and this patch fixes them.  Which ones
> and how?  What broke them?  Commit 05e4982?  Is it worth a Fixes: tag?

tests/vm/*  because they don't use QEMU from the build tree and so
can't be assumed to have 'monitor-qmp' available, unlike the iotests /
functional tests. Yes commit 05e4982, and yes add a Fixes.

> 
> > Update the "make vm-run-xxx" targets to use the runscript that will
> > naturally prefer the locally built version of QEMU so that these tests
> > launch successfully once more.
> >
> > Signed-off-by: John Snow <jsnow@redhat.com>
> > ---
> >  tests/vm/Makefile.include | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/tests/vm/Makefile.include b/tests/vm/Makefile.include
> > index 0a53dc9fdd6..0ec1b47e63e 100644
> > --- a/tests/vm/Makefile.include
> > +++ b/tests/vm/Makefile.include
> > @@ -5,7 +5,7 @@ ifeq ($(realpath $(SRC_PATH)),$(realpath .))
> >  VM_PYTHON = $(SRC_PATH)/vm-venv/bin/python3
> >  VM_VENV = vm-venv
> >  else
> > -VM_PYTHON = $(PYTHON)
> > +VM_PYTHON = $(BUILD_DIR)/run $(PYTHON)
> >  VM_VENV =
> >  endif
> 
> 

With regards,
Daniel
-- 
|: https://berrange.com       ~~        https://hachyderm.io/@berrange :|
|: https://libvirt.org          ~~          https://entangle-photo.org :|
|: https://pixelfed.art/berrange   ~~    https://fstop138.berrange.com :|