All of lore.kernel.org
 help / color / mirror / Atom feed
From: Miquel Raynal <miquel.raynal@bootlin.com>
To: Aleksandr Mineev <sanderrrs@gmail.com>
Cc: Richard Weinberger <richard@nod.at>,
	 Vignesh Raghavendra <vigneshr@ti.com>,
	 linux-mtd@lists.infradead.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] mtd: spinand: fmsh: fix FM25G01B/FM25G02B Quad I/O read dummy cycles
Date: Fri, 17 Jul 2026 15:10:26 +0200	[thread overview]
Message-ID: <87pl0liwxp.fsf@bootlin.com> (raw)
In-Reply-To: <20260715203602.1462-1-sanderrrs@gmail.com> (Aleksandr Mineev's message of "Wed, 15 Jul 2026 23:36:02 +0300")

Hi Aleksandr,

On 15/07/2026 at 23:36:02 +03, Aleksandr Mineev <sanderrrs@gmail.com> wrote:

> The FM25G01B/FM25G02B datasheets specify a single dummy byte for the
> 0xEB Quad I/O read-from-cache operation, but the generic
> read_cache_variants set uses two dummy bytes for the 1S-4S-4S variant.
> The extra dummy byte shifts the data phase and returns corrupted data
> with no ECC error, breaking boot on boards using these chips.
>
> Use a dedicated read-from-cache variant set with ndummy=1 for the
> 1S-4S-4S (0xEB) operation.
>
> FM25G01B datasheet: https://www.fmsh.com/nvm/FM25G01B_ds_eng.pdf
> FM25G02B datasheet: https://www.fmsh.com/nvm/FM25G02B_ds_eng.pdf
>
> Fixes: d5a5c9eb2ee9 ("mtd: spinand: fmsh: add support for FM25G{01,02}B")

Missing Cc: stable tag.

> Signed-off-by: Aleksandr Mineev <sanderrrs@gmail.com>

Otherwise LGTM.

Thanks,
Miquèl

______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/

WARNING: multiple messages have this Message-ID (diff)
From: Miquel Raynal <miquel.raynal@bootlin.com>
To: Aleksandr Mineev <sanderrrs@gmail.com>
Cc: Richard Weinberger <richard@nod.at>,
	 Vignesh Raghavendra <vigneshr@ti.com>,
	 linux-mtd@lists.infradead.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] mtd: spinand: fmsh: fix FM25G01B/FM25G02B Quad I/O read dummy cycles
Date: Fri, 17 Jul 2026 15:10:26 +0200	[thread overview]
Message-ID: <87pl0liwxp.fsf@bootlin.com> (raw)
In-Reply-To: <20260715203602.1462-1-sanderrrs@gmail.com> (Aleksandr Mineev's message of "Wed, 15 Jul 2026 23:36:02 +0300")

Hi Aleksandr,

On 15/07/2026 at 23:36:02 +03, Aleksandr Mineev <sanderrrs@gmail.com> wrote:

> The FM25G01B/FM25G02B datasheets specify a single dummy byte for the
> 0xEB Quad I/O read-from-cache operation, but the generic
> read_cache_variants set uses two dummy bytes for the 1S-4S-4S variant.
> The extra dummy byte shifts the data phase and returns corrupted data
> with no ECC error, breaking boot on boards using these chips.
>
> Use a dedicated read-from-cache variant set with ndummy=1 for the
> 1S-4S-4S (0xEB) operation.
>
> FM25G01B datasheet: https://www.fmsh.com/nvm/FM25G01B_ds_eng.pdf
> FM25G02B datasheet: https://www.fmsh.com/nvm/FM25G02B_ds_eng.pdf
>
> Fixes: d5a5c9eb2ee9 ("mtd: spinand: fmsh: add support for FM25G{01,02}B")

Missing Cc: stable tag.

> Signed-off-by: Aleksandr Mineev <sanderrrs@gmail.com>

Otherwise LGTM.

Thanks,
Miquèl

  reply	other threads:[~2026-07-17 13:10 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-07-15 20:36 [PATCH] mtd: spinand: fmsh: fix FM25G01B/FM25G02B Quad I/O read dummy cycles Aleksandr Mineev
2026-07-15 20:36 ` Aleksandr Mineev
2026-07-17 13:10 ` Miquel Raynal [this message]
2026-07-17 13:10   ` Miquel Raynal

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87pl0liwxp.fsf@bootlin.com \
    --to=miquel.raynal@bootlin.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mtd@lists.infradead.org \
    --cc=richard@nod.at \
    --cc=sanderrrs@gmail.com \
    --cc=vigneshr@ti.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.