All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Dixit, Ashutosh" <ashutosh.dixit@intel.com>
To: Kamil Konieczny <kamil.konieczny@linux.intel.com>,
	"Dixit, Ashutosh" <ashutosh.dixit@intel.com>,
	 Shekhar Chauhan <shekhar.chauhan@intel.com>,
	igt-dev@lists.freedesktop.org
Subject: Re: [PATCH v2] tools/xe-perf-recorder: Add mmio-trigger support
Date: Wed, 15 Jul 2026 13:33:58 -0700	[thread overview]
Message-ID: <87pl0ogfgp.wl-ashutosh.dixit@intel.com> (raw)
In-Reply-To: <20260714112304.rtb5vtsuamsz62sp@kamilkon-DESK.igk.intel.com>

On Tue, 14 Jul 2026 04:23:04 -0700, Kamil Konieczny wrote:
>

Hi Kamil,

> > On second thoughts, let us leave check_mmio_trigger_report() in (as is) for
> > now, so we will at least have some indication and my guess is we will
> > occasionally see the second mmio triggered report missing.
> >
> > So let us leave it in for now and later fix it by a future patch.
> >
>
> imho function should be renamed. As Jani wrote: "Please don't
> add functions named "check something". It's one of the most
> ambiguous verbs you could use in a function name."

Would you have a reference to this, so we can see what Jani means? Or what
would you think is a better name for the function?

Thanks.
--
Ashutosh

      reply	other threads:[~2026-07-15 20:34 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-07-02  5:23 [PATCH v2] tools/xe-perf-recorder: Add mmio-trigger support Shekhar Chauhan
2026-07-02  6:16 ` ✓ Xe.CI.BAT: success for tools/xe-perf-recorder: Add mmio-trigger support (rev2) Patchwork
2026-07-02  6:40 ` ✓ i915.CI.BAT: " Patchwork
2026-07-02 23:10 ` ✗ i915.CI.Full: failure " Patchwork
2026-07-02 23:58 ` ✓ Xe.CI.FULL: success " Patchwork
2026-07-10 23:34 ` [PATCH v2] tools/xe-perf-recorder: Add mmio-trigger support Dixit, Ashutosh
2026-07-10 23:39   ` Dixit, Ashutosh
2026-07-14 11:23     ` Kamil Konieczny
2026-07-15 20:33       ` Dixit, Ashutosh [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87pl0ogfgp.wl-ashutosh.dixit@intel.com \
    --to=ashutosh.dixit@intel.com \
    --cc=igt-dev@lists.freedesktop.org \
    --cc=kamil.konieczny@linux.intel.com \
    --cc=shekhar.chauhan@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.