Re: [PATCH] meson: add missing semicolon in pthread_condattr_setclock test

["Alex Bennée" <alex.bennee@linaro.org>]

Stepan Popov <Stepan.Popov@kaspersky.com> writes:

> The test code was missing a semicolon after the pthread_condattr_t
> variable declaration.
>
> Signed-off-by: Stepan Popov <Stepan.Popov@kaspersky.com>
> ---
>  meson.build | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/meson.build b/meson.build
> index d7c4095b39..5447504ea8 100644
> --- a/meson.build
> +++ b/meson.build
> @@ -2882,7 +2882,7 @@ config_host_data.set('CONFIG_PTHREAD_CONDATTR_SETCLOCK', cc.links(osdep_prefix +
>  
>    int main(void)
>    {
> -    pthread_condattr_t attr
> +    pthread_condattr_t attr;
>      pthread_condattr_init(&attr);
>      pthread_condattr_setclock(&attr, CLOCK_MONOTONIC);
>      return 0;

Good catch:

Reviewed-by: Alex Bennée <alex.bennee@linaro.org>

I guess we've just been silently failing that test since it was
introduced then?

  Cached compiler stderr:
   /home/alex/lsrc/qemu.git/builds/all/meson-private/tmpy5s2fh25/testfile.c: In function 'main':
  /home/alex/lsrc/qemu.git/builds/all/meson-private/tmpy5s2fh25/testfile.c:23:5: error: expected '=', ',', ';', 'asm' or '__attribute__' before 'pthread_condattr_init'
     23 |     pthread_condattr_init(&attr);
        |     ^~~~~~~~~~~~~~~~~~~~~
  /home/alex/lsrc/qemu.git/builds/all/meson-private/tmpy5s2fh25/testfile.c:23:28: error: 'attr' undeclared (first use in this function)
     23 |     pthread_condattr_init(&attr);
        |                            ^~~~
  /home/alex/lsrc/qemu.git/builds/all/meson-private/tmpy5s2fh25/testfile.c:23:28: note: each undeclared identifier is reported only once for each function it appears in

  Using cached compile:
  Cached command line:  cc -m64 /home/alex/lsrc/qemu.git/builds/all/meson-private/tmppx1fde_i/testfile.c -o /home/alex/lsrc/qemu.git/builds/all/meson-private/tmppx1fde_i/output.exe -pthread -D_FILE_OFFSET_BITS=64 -O0 -std=gnu11 

So maybe:

Fixes: 657ac98b58c (thread-posix: use monotonic clock for QemuCond and QemuSemaphore)

-- 
Alex Bennée
Virtualisation Tech Lead @ Linaro