Re: [PATCH] meson: add missing semicolon in pthread_condattr_setclock test

["Daniel P. Berrangé" <berrange@redhat.com>]

On Mon, Mar 30, 2026 at 03:19:40PM +0100, Peter Maydell wrote:
> On Mon, 30 Mar 2026 at 14:36, Daniel P. Berrangé <berrange@redhat.com> wrote:
> >
> > On Mon, Mar 30, 2026 at 05:32:33PM +0400, Marc-André Lureau wrote:
> > > Hi
> > >
> > > On Mon, Mar 30, 2026 at 5:21 PM Stepan Popov <Stepan.Popov@kaspersky.com> wrote:
> > > >
> > > > The test code was missing a semicolon after the pthread_condattr_t
> > > > variable declaration.
> > > >
> > > > Signed-off-by: Stepan Popov <Stepan.Popov@kaspersky.com>
> > >
> > > Fixes: 657ac98b58 ("thread-posix: use monotonic clock for QemuCond and
> > > QemuSemaphore")
> >
> > IOW, that commit has been dead code since it was first added years ago,
> > we've never used the monotonic clock
> 
> Yes. So are we confident enough in that never-tested feature to want to
> enable it at this point in the release cycle, or should we hold off on
> this bugfix until 11.1 ?

IMHO waiting until 11.1 is the prudent approach. This is not a
regression fix and clearly no one noticed it wasn't doing anything
for 3 years since it was introduced, so fixing it can't be that
urgent ?


With regards,
Daniel
-- 
|: https://berrange.com       ~~        https://hachyderm.io/@berrange :|
|: https://libvirt.org          ~~          https://entangle-photo.org :|
|: https://pixelfed.art/berrange   ~~    https://fstop138.berrange.com :|