Re: [PATCH RESEND v2 3/4] mtd: spinand: repeat reading in regular mode if continuous reading fails

From: Miquel Raynal <miquel.raynal@bootlin.com>
To: Mikhail Kshevetskiy <mikhail.kshevetskiy@iopsys.eu>
Cc: Richard Weinberger <richard@nod.at>,
	 Vignesh Raghavendra <vigneshr@ti.com>,
	 Lorenzo Bianconi <lorenzo@kernel.org>,
	 Ray Liu <ray.liu@airoha.com>,  Mark Brown <broonie@kernel.org>,
	 Tudor Ambarus <tudor.ambarus@linaro.org>,
	 Martin Kurbanov <mmkurbanov@salutedevices.com>,
	 Takahiro Kuwano <Takahiro.Kuwano@infineon.com>,
	 Cheng Ming Lin <chengminglin@mxic.com.tw>,
	 linux-mtd@lists.infradead.org, linux-kernel@vger.kernel.org,
	 linux-arm-kernel@lists.infradead.org, linux-spi@vger.kernel.org
Subject: Re: [PATCH RESEND v2 3/4] mtd: spinand: repeat reading in regular mode if continuous reading fails
Date: Sun, 24 Aug 2025 18:24:00 +0200	[thread overview]
Message-ID: <87plckit7j.fsf@bootlin.com> (raw)
In-Reply-To: <20250814065423.3980305-4-mikhail.kshevetskiy@iopsys.eu> (Mikhail Kshevetskiy's message of "Thu, 14 Aug 2025 09:54:22 +0300")

Hello,

> +		if (controller_is_buggy) {
> +			/*
> +			 * Some spi controllers may not support reading up to
> +			 * erase block size. They will read less data than
> +			 * expected. If this happen disable continuous mode
> +			 * and repeat reading in normal mode.
> +			 */
> +			spinand->cont_read_possible = false;

I am fine with the idea, but could we avoid this little dance and drop
the extra controller_is_buggy boolean, and just let
spinand_mtd_continuous_page_read() do the fixup and return -EAGAIN?

> +			ret = spinand_mtd_regular_page_read(mtd, from, ops,
> +							    &max_bitflips);
> +		}
> +	} else {
> +		ret = spinand_mtd_regular_page_read(mtd, from, ops,
> +						    &max_bitflips);
> +	}
>  
>  	if (ops->stats) {
>  		ops->stats->uncorrectable_errors +=

Thanks,
Miquèl