From: Fabiano Rosas <farosas@suse.de>
To: Markus Armbruster <armbru@redhat.com>, qemu-devel@nongnu.org
Cc: peterx@redhat.com
Subject: Re: [PATCH] migration: Fix latent bug in migrate_params_test_apply()
Date: Mon, 07 Apr 2025 09:08:21 -0300 [thread overview]
Message-ID: <87plhojhsa.fsf@suse.de> (raw)
In-Reply-To: <20250407072833.2118928-1-armbru@redhat.com>
Markus Armbruster <armbru@redhat.com> writes:
> migrate_params_test_apply() neglects to apply tls_authz. Currently
> harmless, because migrate_params_check() doesn't care. Fix it anyway.
>
> Signed-off-by: Markus Armbruster <armbru@redhat.com>
> ---
> migration/options.c | 5 +++++
> 1 file changed, 5 insertions(+)
>
> diff --git a/migration/options.c b/migration/options.c
> index b0ac2ea408..cb8eec218f 100644
> --- a/migration/options.c
> +++ b/migration/options.c
> @@ -1193,6 +1193,11 @@ static void migrate_params_test_apply(MigrateSetParameters *params,
> dest->tls_hostname = params->tls_hostname->u.s;
> }
>
> + if (params->tls_authz) {
> + assert(params->tls_authz->type == QTYPE_QSTRING);
> + dest->tls_authz = params->tls_authz->u.s;
> + }
> +
> if (params->has_max_bandwidth) {
> dest->max_bandwidth = params->max_bandwidth;
> }
Reviewed-by: Fabiano Rosas <farosas@suse.de>
prev parent reply other threads:[~2025-04-07 12:09 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-04-07 7:28 [PATCH] migration: Fix latent bug in migrate_params_test_apply() Markus Armbruster
2025-04-07 12:08 ` Fabiano Rosas [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87plhojhsa.fsf@suse.de \
--to=farosas@suse.de \
--cc=armbru@redhat.com \
--cc=peterx@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.