* [PATCH] migration: Fix latent bug in migrate_params_test_apply()
@ 2025-04-07 7:28 Markus Armbruster
2025-04-07 12:08 ` Fabiano Rosas
0 siblings, 1 reply; 2+ messages in thread
From: Markus Armbruster @ 2025-04-07 7:28 UTC (permalink / raw)
To: qemu-devel; +Cc: peterx, farosas
migrate_params_test_apply() neglects to apply tls_authz. Currently
harmless, because migrate_params_check() doesn't care. Fix it anyway.
Signed-off-by: Markus Armbruster <armbru@redhat.com>
---
migration/options.c | 5 +++++
1 file changed, 5 insertions(+)
diff --git a/migration/options.c b/migration/options.c
index b0ac2ea408..cb8eec218f 100644
--- a/migration/options.c
+++ b/migration/options.c
@@ -1193,6 +1193,11 @@ static void migrate_params_test_apply(MigrateSetParameters *params,
dest->tls_hostname = params->tls_hostname->u.s;
}
+ if (params->tls_authz) {
+ assert(params->tls_authz->type == QTYPE_QSTRING);
+ dest->tls_authz = params->tls_authz->u.s;
+ }
+
if (params->has_max_bandwidth) {
dest->max_bandwidth = params->max_bandwidth;
}
--
2.48.1
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH] migration: Fix latent bug in migrate_params_test_apply()
2025-04-07 7:28 [PATCH] migration: Fix latent bug in migrate_params_test_apply() Markus Armbruster
@ 2025-04-07 12:08 ` Fabiano Rosas
0 siblings, 0 replies; 2+ messages in thread
From: Fabiano Rosas @ 2025-04-07 12:08 UTC (permalink / raw)
To: Markus Armbruster, qemu-devel; +Cc: peterx
Markus Armbruster <armbru@redhat.com> writes:
> migrate_params_test_apply() neglects to apply tls_authz. Currently
> harmless, because migrate_params_check() doesn't care. Fix it anyway.
>
> Signed-off-by: Markus Armbruster <armbru@redhat.com>
> ---
> migration/options.c | 5 +++++
> 1 file changed, 5 insertions(+)
>
> diff --git a/migration/options.c b/migration/options.c
> index b0ac2ea408..cb8eec218f 100644
> --- a/migration/options.c
> +++ b/migration/options.c
> @@ -1193,6 +1193,11 @@ static void migrate_params_test_apply(MigrateSetParameters *params,
> dest->tls_hostname = params->tls_hostname->u.s;
> }
>
> + if (params->tls_authz) {
> + assert(params->tls_authz->type == QTYPE_QSTRING);
> + dest->tls_authz = params->tls_authz->u.s;
> + }
> +
> if (params->has_max_bandwidth) {
> dest->max_bandwidth = params->max_bandwidth;
> }
Reviewed-by: Fabiano Rosas <farosas@suse.de>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2025-04-07 12:09 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-04-07 7:28 [PATCH] migration: Fix latent bug in migrate_params_test_apply() Markus Armbruster
2025-04-07 12:08 ` Fabiano Rosas
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.