From: Kalle Valo <kvalo@kernel.org>
To: Arend Van Spriel <aspriel@gmail.com>
Cc: Jacobe Zang <jacobe.zang@wesion.com>,
arend.vanspriel@broadcom.com, duoming@zju.edu.cn,
bhelgaas@google.com, minipli@grsecurity.net,
linux-wireless@vger.kernel.org, brcm80211@lists.linux.dev,
brcm80211-dev-list.pdl@broadcom.com, megi@xff.cz,
robh@kernel.org, efectn@protonmail.com, krzk+dt@kernel.org,
conor+dt@kernel.org, heiko@sntech.de, nick@khadas.com,
jagan@edgeble.ai, dsimic@manjaro.org,
devicetree@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-rockchip@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 5/5] dt-bindings: net: wireless: brcm4329-fmac: add pci14e4,449d
Date: Wed, 26 Jun 2024 09:28:28 +0300 [thread overview]
Message-ID: <87pls4gqur.fsf@kernel.org> (raw)
In-Reply-To: <89f2564f-788e-495d-97ce-f1fa8a921d50@gmail.com> (Arend Van Spriel's message of "Tue, 25 Jun 2024 20:23:09 +0200")
Arend Van Spriel <aspriel@gmail.com> writes:
> On 6/24/2024 10:19 AM, Jacobe Zang wrote:
>> AP6275P Wi-Fi module connected via the PCIe interface.
>
> Repeating my remark from v1 series although I gained some knowledge
> what chip it should be now ;-)
>
>> Signed-off-by: Jacobe Zang <jacobe.zang@wesion.com>
>> ---
>> .../devicetree/bindings/net/wireless/brcm,bcm4329-fmac.yaml | 1 +
>> 1 file changed, 1 insertion(+)
>> diff --git
>> a/Documentation/devicetree/bindings/net/wireless/brcm,bcm4329-fmac.yaml
>> b/Documentation/devicetree/bindings/net/wireless/brcm,bcm4329-fmac.yaml
>> index b9e39a62c3b32..fd22ade92210c 100644
>> --- a/Documentation/devicetree/bindings/net/wireless/brcm,bcm4329-fmac.yaml
>> +++ b/Documentation/devicetree/bindings/net/wireless/brcm,bcm4329-fmac.yaml
>> @@ -53,6 +53,7 @@ properties:
>> - pci14e4,4488 # BCM4377
>> - pci14e4,4425 # BCM4378
>> - pci14e4,4433 # BCM4387
>> + - pci14e4,449d # BCM4329
>
> This should BCM43752 iso BCM4329.
My simple english parser threw an exception here ;)
--
https://patchwork.kernel.org/project/linux-wireless/list/
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
WARNING: multiple messages have this Message-ID (diff)
From: Kalle Valo <kvalo@kernel.org>
To: Arend Van Spriel <aspriel@gmail.com>
Cc: Jacobe Zang <jacobe.zang@wesion.com>,
arend.vanspriel@broadcom.com, duoming@zju.edu.cn,
bhelgaas@google.com, minipli@grsecurity.net,
linux-wireless@vger.kernel.org, brcm80211@lists.linux.dev,
brcm80211-dev-list.pdl@broadcom.com, megi@xff.cz,
robh@kernel.org, efectn@protonmail.com, krzk+dt@kernel.org,
conor+dt@kernel.org, heiko@sntech.de, nick@khadas.com,
jagan@edgeble.ai, dsimic@manjaro.org,
devicetree@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-rockchip@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 5/5] dt-bindings: net: wireless: brcm4329-fmac: add pci14e4,449d
Date: Wed, 26 Jun 2024 09:28:28 +0300 [thread overview]
Message-ID: <87pls4gqur.fsf@kernel.org> (raw)
In-Reply-To: <89f2564f-788e-495d-97ce-f1fa8a921d50@gmail.com> (Arend Van Spriel's message of "Tue, 25 Jun 2024 20:23:09 +0200")
Arend Van Spriel <aspriel@gmail.com> writes:
> On 6/24/2024 10:19 AM, Jacobe Zang wrote:
>> AP6275P Wi-Fi module connected via the PCIe interface.
>
> Repeating my remark from v1 series although I gained some knowledge
> what chip it should be now ;-)
>
>> Signed-off-by: Jacobe Zang <jacobe.zang@wesion.com>
>> ---
>> .../devicetree/bindings/net/wireless/brcm,bcm4329-fmac.yaml | 1 +
>> 1 file changed, 1 insertion(+)
>> diff --git
>> a/Documentation/devicetree/bindings/net/wireless/brcm,bcm4329-fmac.yaml
>> b/Documentation/devicetree/bindings/net/wireless/brcm,bcm4329-fmac.yaml
>> index b9e39a62c3b32..fd22ade92210c 100644
>> --- a/Documentation/devicetree/bindings/net/wireless/brcm,bcm4329-fmac.yaml
>> +++ b/Documentation/devicetree/bindings/net/wireless/brcm,bcm4329-fmac.yaml
>> @@ -53,6 +53,7 @@ properties:
>> - pci14e4,4488 # BCM4377
>> - pci14e4,4425 # BCM4378
>> - pci14e4,4433 # BCM4387
>> + - pci14e4,449d # BCM4329
>
> This should BCM43752 iso BCM4329.
My simple english parser threw an exception here ;)
--
https://patchwork.kernel.org/project/linux-wireless/list/
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
_______________________________________________
Linux-rockchip mailing list
Linux-rockchip@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-rockchip
next prev parent reply other threads:[~2024-06-26 6:28 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-24 8:19 [PATCH v2 0/5] Add AP6275P wireless support Jacobe Zang
2024-06-24 8:19 ` Jacobe Zang
2024-06-24 8:19 ` [PATCH v2 1/5] arm64: dts: rockchip: Add AP6275P wireless support to Khadas Edge 2 Jacobe Zang
2024-06-24 8:19 ` Jacobe Zang
2024-06-24 11:52 ` Krzysztof Kozlowski
2024-06-24 11:52 ` Krzysztof Kozlowski
2024-06-25 8:04 ` Jacobe Zang
2024-06-25 8:04 ` Jacobe Zang
2024-07-01 8:41 ` Krzysztof Kozlowski
2024-07-01 8:41 ` Krzysztof Kozlowski
2024-06-24 8:19 ` [PATCH v2 2/5] net: wireless: brcmfmac: Add optional 32k clock enable support Jacobe Zang
2024-06-24 8:19 ` Jacobe Zang
2024-06-24 12:31 ` Kalle Valo
2024-06-24 12:31 ` Kalle Valo
2024-06-24 8:19 ` [PATCH v2 3/5] net: wireless: brcmfmac: Add support for AP6275P Jacobe Zang
2024-06-24 8:19 ` Jacobe Zang
2024-06-24 8:19 ` [PATCH v2 4/5] dt-bindings: net: wireless: brcm4329-fmac: add clock description Jacobe Zang
2024-06-24 8:19 ` Jacobe Zang
2024-06-24 8:59 ` Arend van Spriel
2024-06-24 8:59 ` Arend van Spriel
2024-06-24 9:04 ` Jacobe Zang
2024-06-24 9:04 ` Jacobe Zang
2024-06-24 11:45 ` Krzysztof Kozlowski
2024-06-24 11:45 ` Krzysztof Kozlowski
2024-06-24 8:19 ` [PATCH v2 5/5] dt-bindings: net: wireless: brcm4329-fmac: add pci14e4,449d Jacobe Zang
2024-06-24 8:19 ` Jacobe Zang
2024-06-25 18:23 ` Arend Van Spriel
2024-06-25 18:23 ` Arend Van Spriel
2024-06-26 6:28 ` Kalle Valo [this message]
2024-06-26 6:28 ` Kalle Valo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87pls4gqur.fsf@kernel.org \
--to=kvalo@kernel.org \
--cc=arend.vanspriel@broadcom.com \
--cc=aspriel@gmail.com \
--cc=bhelgaas@google.com \
--cc=brcm80211-dev-list.pdl@broadcom.com \
--cc=brcm80211@lists.linux.dev \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dsimic@manjaro.org \
--cc=duoming@zju.edu.cn \
--cc=efectn@protonmail.com \
--cc=heiko@sntech.de \
--cc=jacobe.zang@wesion.com \
--cc=jagan@edgeble.ai \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=linux-wireless@vger.kernel.org \
--cc=megi@xff.cz \
--cc=minipli@grsecurity.net \
--cc=nick@khadas.com \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.