All of lore.kernel.org
 help / color / mirror / Atom feed
From: Kalle Valo <kvalo@kernel.org>
To: Breno Leitao <leitao@debian.org>
Cc: aleksander.lobakin@intel.com,  kuba@kernel.org,
	 davem@davemloft.net, pabeni@redhat.com,  edumazet@google.com,
	 elder@kernel.org, linux-arm-kernel@lists.infradead.org,
	linux-mediatek@lists.infradead.org,  nbd@nbd.name,
	sean.wang@mediatek.com,  Mark-MC.Lee@mediatek.com,
	 lorenzo@kernel.org, taras.chornyi@plvision.eu,
	 Matthias Brugger <matthias.bgg@gmail.com>,
	AngeloGioacchino Del Regno
	<angelogioacchino.delregno@collabora.com>,
	quic_jjohnson@quicinc.com,  leon@kernel.org,
	dennis.dalessandro@cornelisnetworks.com,
	 linux-kernel@vger.kernel.org, netdev@vger.kernel.org,
	 bpf@vger.kernel.org
Subject: Re: [PATCH net-next v3 0/5] allocate dummy device dynamically
Date: Thu, 04 Apr 2024 14:59:59 +0300	[thread overview]
Message-ID: <87plv549ts.fsf@kernel.org> (raw)
In-Reply-To: <20240404114854.2498663-1-leitao@debian.org> (Breno Leitao's message of "Thu, 4 Apr 2024 04:48:40 -0700")

Breno Leitao <leitao@debian.org> writes:

> struct net_device shouldn't be embedded into any structure, instead,
> the owner should use the private space to embed their state into
> net_device.
>
> But, in some cases the net_device is embedded inside the private
> structure, which blocks the usage of zero-length arrays inside
> net_device.
>
> Create a helper to allocate a dummy device at dynamically runtime, and
> move the Ethernet devices to use it, instead of embedding the dummy
> device inside the private structure.
>
> This fixes all the network cases except for wireless drivers.
>
> PS: Due to lack of hardware, unfortunately all these patches are
> compiled tested only.

BTW if it helps, and if you have an ath10k or ath11k patch already, I
can run a quick test on real hardware.

-- 
https://patchwork.kernel.org/project/linux-wireless/list/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches

WARNING: multiple messages have this Message-ID (diff)
From: Kalle Valo <kvalo@kernel.org>
To: Breno Leitao <leitao@debian.org>
Cc: aleksander.lobakin@intel.com,  kuba@kernel.org,
	 davem@davemloft.net, pabeni@redhat.com,  edumazet@google.com,
	 elder@kernel.org, linux-arm-kernel@lists.infradead.org,
	linux-mediatek@lists.infradead.org,  nbd@nbd.name,
	sean.wang@mediatek.com,  Mark-MC.Lee@mediatek.com,
	 lorenzo@kernel.org, taras.chornyi@plvision.eu,
	 Matthias Brugger <matthias.bgg@gmail.com>,
	AngeloGioacchino Del Regno
	<angelogioacchino.delregno@collabora.com>,
	quic_jjohnson@quicinc.com,  leon@kernel.org,
	dennis.dalessandro@cornelisnetworks.com,
	 linux-kernel@vger.kernel.org, netdev@vger.kernel.org,
	 bpf@vger.kernel.org
Subject: Re: [PATCH net-next v3 0/5] allocate dummy device dynamically
Date: Thu, 04 Apr 2024 14:59:59 +0300	[thread overview]
Message-ID: <87plv549ts.fsf@kernel.org> (raw)
In-Reply-To: <20240404114854.2498663-1-leitao@debian.org> (Breno Leitao's message of "Thu, 4 Apr 2024 04:48:40 -0700")

Breno Leitao <leitao@debian.org> writes:

> struct net_device shouldn't be embedded into any structure, instead,
> the owner should use the private space to embed their state into
> net_device.
>
> But, in some cases the net_device is embedded inside the private
> structure, which blocks the usage of zero-length arrays inside
> net_device.
>
> Create a helper to allocate a dummy device at dynamically runtime, and
> move the Ethernet devices to use it, instead of embedding the dummy
> device inside the private structure.
>
> This fixes all the network cases except for wireless drivers.
>
> PS: Due to lack of hardware, unfortunately all these patches are
> compiled tested only.

BTW if it helps, and if you have an ath10k or ath11k patch already, I
can run a quick test on real hardware.

-- 
https://patchwork.kernel.org/project/linux-wireless/list/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

  parent reply	other threads:[~2024-04-04 12:00 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-04-04 11:48 [PATCH net-next v3 0/5] allocate dummy device dynamically Breno Leitao
2024-04-04 11:48 ` Breno Leitao
2024-04-04 11:48 ` [PATCH net-next v3 1/5] net: create a dummy net_device allocator Breno Leitao
2024-04-04 11:48   ` Breno Leitao
2024-04-04 16:40   ` Alexander Lobakin
2024-04-04 16:40     ` Alexander Lobakin
2024-04-04 19:03     ` Breno Leitao
2024-04-04 19:03       ` Breno Leitao
2024-04-04 11:48 ` [PATCH net-next v3 2/5] net: marvell: prestera: allocate dummy net_device dynamically Breno Leitao
2024-04-04 11:48   ` Breno Leitao
2024-04-04 11:59   ` [EXTERNAL] " Elad Nachman
2024-04-04 11:59     ` Elad Nachman
2024-04-04 11:48 ` [PATCH net-next v3 3/5] net: mediatek: mtk_eth_sock: " Breno Leitao
2024-04-04 11:48   ` Breno Leitao
2024-04-04 11:48 ` [PATCH net-next v3 4/5] net: ipa: " Breno Leitao
2024-04-04 11:48   ` Breno Leitao
2024-04-04 11:48 ` [PATCH net-next v3 5/5] net: ibm/emac: " Breno Leitao
2024-04-04 11:48   ` Breno Leitao
2024-04-04 11:59 ` Kalle Valo [this message]
2024-04-04 11:59   ` [PATCH net-next v3 0/5] allocate dummy device dynamically Kalle Valo
2024-04-04 14:22   ` Breno Leitao
2024-04-04 14:22     ` Breno Leitao
2024-04-04 15:01     ` Kalle Valo
2024-04-04 15:01       ` Kalle Valo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87plv549ts.fsf@kernel.org \
    --to=kvalo@kernel.org \
    --cc=Mark-MC.Lee@mediatek.com \
    --cc=aleksander.lobakin@intel.com \
    --cc=angelogioacchino.delregno@collabora.com \
    --cc=bpf@vger.kernel.org \
    --cc=davem@davemloft.net \
    --cc=dennis.dalessandro@cornelisnetworks.com \
    --cc=edumazet@google.com \
    --cc=elder@kernel.org \
    --cc=kuba@kernel.org \
    --cc=leitao@debian.org \
    --cc=leon@kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mediatek@lists.infradead.org \
    --cc=lorenzo@kernel.org \
    --cc=matthias.bgg@gmail.com \
    --cc=nbd@nbd.name \
    --cc=netdev@vger.kernel.org \
    --cc=pabeni@redhat.com \
    --cc=quic_jjohnson@quicinc.com \
    --cc=sean.wang@mediatek.com \
    --cc=taras.chornyi@plvision.eu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.