From: Gabriel Krisman Bertazi <krisman@suse.de>
To: Eugen Hristev <eugen.hristev@collabora.com>
Cc: tytso@mit.edu, adilger.kernel@dilger.ca, jaegeuk@kernel.org,
chao@kernel.org, viro@zeniv.linux.org.uk, brauner@kernel.org,
linux-ext4@vger.kernel.org,
linux-f2fs-devel@lists.sourceforge.net, jack@suse.cz,
linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org,
kernel@collabora.com,
Gabriel Krisman Bertazi <krisman@collabora.com>,
Eric Biggers <ebiggers@google.com>
Subject: Re: [RESEND PATCH v9 1/3] libfs: Introduce case-insensitive string comparison helper
Date: Fri, 09 Feb 2024 09:40:51 -0500 [thread overview]
Message-ID: <87plx5u2do.fsf@mailhost.krisman.be> (raw)
In-Reply-To: <ff492e0f-3760-430e-968a-8b2adab13f3f@collabora.com> (Eugen Hristev's message of "Fri, 9 Feb 2024 12:30:47 +0200")
Eugen Hristev <eugen.hristev@collabora.com> writes:
> On 2/8/24 20:38, Gabriel Krisman Bertazi wrote:
>> (untested)
>
> I implemented your suggestion, but any idea about testing ? I ran smoke on xfstests
> and it appears to be fine, but maybe some specific test case might try the
> different paths here ?
Other than running the fstests quick group for each affected filesystems
looking for regressions, the way I'd do it is create a few files and
look them up with exact and inexact name matches. While doing that,
observe through bpftrace which functions got called and what they
returned.
Here, since you are testing the uncached lookup, you want to make sure
to drop the cached version prior to each lookup.
--
Gabriel Krisman Bertazi
WARNING: multiple messages have this Message-ID (diff)
From: Gabriel Krisman Bertazi <krisman@suse.de>
To: Eugen Hristev <eugen.hristev@collabora.com>
Cc: brauner@kernel.org, kernel@collabora.com, tytso@mit.edu,
Eric Biggers <ebiggers@google.com>,
jack@suse.cz, linux-kernel@vger.kernel.org,
linux-f2fs-devel@lists.sourceforge.net, adilger.kernel@dilger.ca,
viro@zeniv.linux.org.uk, linux-fsdevel@vger.kernel.org,
jaegeuk@kernel.org, linux-ext4@vger.kernel.org,
Gabriel Krisman Bertazi <krisman@collabora.com>
Subject: Re: [f2fs-dev] [RESEND PATCH v9 1/3] libfs: Introduce case-insensitive string comparison helper
Date: Fri, 09 Feb 2024 09:40:51 -0500 [thread overview]
Message-ID: <87plx5u2do.fsf@mailhost.krisman.be> (raw)
In-Reply-To: <ff492e0f-3760-430e-968a-8b2adab13f3f@collabora.com> (Eugen Hristev's message of "Fri, 9 Feb 2024 12:30:47 +0200")
Eugen Hristev <eugen.hristev@collabora.com> writes:
> On 2/8/24 20:38, Gabriel Krisman Bertazi wrote:
>> (untested)
>
> I implemented your suggestion, but any idea about testing ? I ran smoke on xfstests
> and it appears to be fine, but maybe some specific test case might try the
> different paths here ?
Other than running the fstests quick group for each affected filesystems
looking for regressions, the way I'd do it is create a few files and
look them up with exact and inexact name matches. While doing that,
observe through bpftrace which functions got called and what they
returned.
Here, since you are testing the uncached lookup, you want to make sure
to drop the cached version prior to each lookup.
--
Gabriel Krisman Bertazi
_______________________________________________
Linux-f2fs-devel mailing list
Linux-f2fs-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel
next prev parent reply other threads:[~2024-02-09 14:40 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-08 6:43 [RESEND PATCH v9 0/3] Introduce case-insensitive string comparison helper Eugen Hristev
2024-02-08 6:43 ` [f2fs-dev] " Eugen Hristev via Linux-f2fs-devel
2024-02-08 6:43 ` [RESEND PATCH v9 1/3] libfs: " Eugen Hristev
2024-02-08 6:43 ` [f2fs-dev] " Eugen Hristev via Linux-f2fs-devel
2024-02-08 18:38 ` Gabriel Krisman Bertazi
2024-02-08 18:38 ` [f2fs-dev] " Gabriel Krisman Bertazi
2024-02-09 10:30 ` Eugen Hristev
2024-02-09 10:30 ` [f2fs-dev] " Eugen Hristev via Linux-f2fs-devel
2024-02-09 14:40 ` Gabriel Krisman Bertazi [this message]
2024-02-09 14:40 ` Gabriel Krisman Bertazi
2024-02-13 4:44 ` Eugen Hristev
2024-02-13 4:44 ` [f2fs-dev] " Eugen Hristev via Linux-f2fs-devel
2024-02-13 16:09 ` Gabriel Krisman Bertazi
2024-02-13 16:09 ` [f2fs-dev] " Gabriel Krisman Bertazi
2024-02-08 6:43 ` [RESEND PATCH v9 2/3] ext4: Reuse generic_ci_match for ci comparisons Eugen Hristev
2024-02-08 6:43 ` [f2fs-dev] " Eugen Hristev via Linux-f2fs-devel
2024-02-08 18:42 ` Gabriel Krisman Bertazi
2024-02-08 18:42 ` [f2fs-dev] " Gabriel Krisman Bertazi
2024-02-08 6:43 ` [RESEND PATCH v9 3/3] f2fs: " Eugen Hristev
2024-02-08 6:43 ` [f2fs-dev] " Eugen Hristev via Linux-f2fs-devel
2024-07-24 2:16 ` [f2fs-dev] [RESEND PATCH v9 0/3] Introduce case-insensitive string comparison helper patchwork-bot+f2fs
2024-07-24 2:16 ` patchwork-bot+f2fs
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87plx5u2do.fsf@mailhost.krisman.be \
--to=krisman@suse.de \
--cc=adilger.kernel@dilger.ca \
--cc=brauner@kernel.org \
--cc=chao@kernel.org \
--cc=ebiggers@google.com \
--cc=eugen.hristev@collabora.com \
--cc=jack@suse.cz \
--cc=jaegeuk@kernel.org \
--cc=kernel@collabora.com \
--cc=krisman@collabora.com \
--cc=linux-ext4@vger.kernel.org \
--cc=linux-f2fs-devel@lists.sourceforge.net \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=tytso@mit.edu \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.