* [PATCH] include: env: ti: ti_common: Run main_cpsw0_qsgmii_phyinit conditionally
@ 2023-12-11 10:42 Siddharth Vadapalli
2023-12-11 19:15 ` Tom Rini
` (2 more replies)
0 siblings, 3 replies; 5+ messages in thread
From: Siddharth Vadapalli @ 2023-12-11 10:42 UTC (permalink / raw)
To: trini, m-chawdhry, bmeng.cn, sjg, afd, mkorpershoek, n-francis,
nm
Cc: u-boot, vigneshr, srk, s-vadapalli
From: Manorit Chawdhry <m-chawdhry@ti.com>
The main_cpsw0_qsgmii_phyinit command is defined only for certain TI
SoCs which have the do_main_cpsw0_qsgmii_phyinit variable set.
Add a check to ensure that the main_cpsw0_qsgmii_phyinit command is run
only for such SoCs.
Signed-off-by: Manorit Chawdhry <m-chawdhry@ti.com>
Signed-off-by: Siddharth Vadapalli <s-vadapalli@ti.com>
---
Hello,
This patch is based on commit
65eed68772 test/py: Disable error E0611 in two cases for pylint
Regards,
Siddharth.
include/env/ti/ti_common.env | 5 ++++-
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/include/env/ti/ti_common.env b/include/env/ti/ti_common.env
index f5d84216e3..f0f89a2287 100644
--- a/include/env/ti/ti_common.env
+++ b/include/env/ti/ti_common.env
@@ -25,7 +25,10 @@ run_fit=run get_fit_config; bootm ${addr_fit}#${name_fit_config}${overlaystring}
bootcmd_ti_mmc=
run findfdt; run init_${boot};
#if CONFIG_CMD_REMOTEPROC
- run main_cpsw0_qsgmii_phyinit; run boot_rprocs;
+ if test ${do_main_cpsw0_qsgmii_phyinit} -eq 1;
+ then run main_cpsw0_qsgmii_phyinit;
+ fi
+ run boot_rprocs;
#endif
if test ${boot_fit} -eq 1;
then run get_fit_${boot}; run get_fit_overlaystring; run run_fit;
--
2.34.1
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH] include: env: ti: ti_common: Run main_cpsw0_qsgmii_phyinit conditionally
2023-12-11 10:42 [PATCH] include: env: ti: ti_common: Run main_cpsw0_qsgmii_phyinit conditionally Siddharth Vadapalli
@ 2023-12-11 19:15 ` Tom Rini
2023-12-20 17:06 ` Mattijs Korpershoek
2023-12-21 21:06 ` Tom Rini
2 siblings, 0 replies; 5+ messages in thread
From: Tom Rini @ 2023-12-11 19:15 UTC (permalink / raw)
To: Siddharth Vadapalli
Cc: m-chawdhry, bmeng.cn, sjg, afd, mkorpershoek, n-francis, nm,
u-boot, vigneshr, srk
[-- Attachment #1: Type: text/plain, Size: 538 bytes --]
On Mon, Dec 11, 2023 at 04:12:09PM +0530, Siddharth Vadapalli wrote:
> From: Manorit Chawdhry <m-chawdhry@ti.com>
>
> The main_cpsw0_qsgmii_phyinit command is defined only for certain TI
> SoCs which have the do_main_cpsw0_qsgmii_phyinit variable set.
>
> Add a check to ensure that the main_cpsw0_qsgmii_phyinit command is run
> only for such SoCs.
>
> Signed-off-by: Manorit Chawdhry <m-chawdhry@ti.com>
> Signed-off-by: Siddharth Vadapalli <s-vadapalli@ti.com>
Reviewed-by: Tom Rini <trini@konsulko.com>
--
Tom
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 659 bytes --]
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] include: env: ti: ti_common: Run main_cpsw0_qsgmii_phyinit conditionally
2023-12-11 10:42 [PATCH] include: env: ti: ti_common: Run main_cpsw0_qsgmii_phyinit conditionally Siddharth Vadapalli
2023-12-11 19:15 ` Tom Rini
@ 2023-12-20 17:06 ` Mattijs Korpershoek
2023-12-21 21:06 ` Tom Rini
2 siblings, 0 replies; 5+ messages in thread
From: Mattijs Korpershoek @ 2023-12-20 17:06 UTC (permalink / raw)
To: Siddharth Vadapalli, trini, m-chawdhry, bmeng.cn, sjg, afd,
n-francis, nm
Cc: u-boot, vigneshr, srk, s-vadapalli
On Mon, Dec 11, 2023 at 16:12, Siddharth Vadapalli <s-vadapalli@ti.com> wrote:
> From: Manorit Chawdhry <m-chawdhry@ti.com>
>
> The main_cpsw0_qsgmii_phyinit command is defined only for certain TI
> SoCs which have the do_main_cpsw0_qsgmii_phyinit variable set.
>
> Add a check to ensure that the main_cpsw0_qsgmii_phyinit command is run
> only for such SoCs.
>
> Signed-off-by: Manorit Chawdhry <m-chawdhry@ti.com>
> Signed-off-by: Siddharth Vadapalli <s-vadapalli@ti.com>
Reviewed-by: Mattijs Korpershoek <mkorpershoek@baylibre.com>
> ---
>
> Hello,
>
> This patch is based on commit
> 65eed68772 test/py: Disable error E0611 in two cases for pylint
>
> Regards,
> Siddharth.
>
> include/env/ti/ti_common.env | 5 ++++-
> 1 file changed, 4 insertions(+), 1 deletion(-)
>
> diff --git a/include/env/ti/ti_common.env b/include/env/ti/ti_common.env
> index f5d84216e3..f0f89a2287 100644
> --- a/include/env/ti/ti_common.env
> +++ b/include/env/ti/ti_common.env
> @@ -25,7 +25,10 @@ run_fit=run get_fit_config; bootm ${addr_fit}#${name_fit_config}${overlaystring}
> bootcmd_ti_mmc=
> run findfdt; run init_${boot};
> #if CONFIG_CMD_REMOTEPROC
> - run main_cpsw0_qsgmii_phyinit; run boot_rprocs;
> + if test ${do_main_cpsw0_qsgmii_phyinit} -eq 1;
> + then run main_cpsw0_qsgmii_phyinit;
> + fi
> + run boot_rprocs;
> #endif
> if test ${boot_fit} -eq 1;
> then run get_fit_${boot}; run get_fit_overlaystring; run run_fit;
> --
> 2.34.1
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] include: env: ti: ti_common: Run main_cpsw0_qsgmii_phyinit conditionally
2023-12-11 10:42 [PATCH] include: env: ti: ti_common: Run main_cpsw0_qsgmii_phyinit conditionally Siddharth Vadapalli
2023-12-11 19:15 ` Tom Rini
2023-12-20 17:06 ` Mattijs Korpershoek
@ 2023-12-21 21:06 ` Tom Rini
2023-12-27 13:06 ` Nishanth Menon
2 siblings, 1 reply; 5+ messages in thread
From: Tom Rini @ 2023-12-21 21:06 UTC (permalink / raw)
To: Siddharth Vadapalli
Cc: m-chawdhry, bmeng.cn, sjg, afd, mkorpershoek, n-francis, nm,
u-boot, vigneshr, srk
[-- Attachment #1: Type: text/plain, Size: 637 bytes --]
On Mon, Dec 11, 2023 at 04:12:09PM +0530, Siddharth Vadapalli wrote:
> From: Manorit Chawdhry <m-chawdhry@ti.com>
>
> The main_cpsw0_qsgmii_phyinit command is defined only for certain TI
> SoCs which have the do_main_cpsw0_qsgmii_phyinit variable set.
>
> Add a check to ensure that the main_cpsw0_qsgmii_phyinit command is run
> only for such SoCs.
>
> Signed-off-by: Manorit Chawdhry <m-chawdhry@ti.com>
> Signed-off-by: Siddharth Vadapalli <s-vadapalli@ti.com>
> Reviewed-by: Tom Rini <trini@konsulko.com>
> Reviewed-by: Mattijs Korpershoek <mkorpershoek@baylibre.com>
Applied to u-boot/next, thanks!
--
Tom
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 659 bytes --]
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] include: env: ti: ti_common: Run main_cpsw0_qsgmii_phyinit conditionally
2023-12-21 21:06 ` Tom Rini
@ 2023-12-27 13:06 ` Nishanth Menon
0 siblings, 0 replies; 5+ messages in thread
From: Nishanth Menon @ 2023-12-27 13:06 UTC (permalink / raw)
To: Tom Rini
Cc: Siddharth Vadapalli, m-chawdhry, bmeng.cn, sjg, afd, mkorpershoek,
n-francis, u-boot, vigneshr, srk
On 16:06-20231221, Tom Rini wrote:
> On Mon, Dec 11, 2023 at 04:12:09PM +0530, Siddharth Vadapalli wrote:
>
> > From: Manorit Chawdhry <m-chawdhry@ti.com>
> >
> > The main_cpsw0_qsgmii_phyinit command is defined only for certain TI
> > SoCs which have the do_main_cpsw0_qsgmii_phyinit variable set.
> >
> > Add a check to ensure that the main_cpsw0_qsgmii_phyinit command is run
> > only for such SoCs.
> >
> > Signed-off-by: Manorit Chawdhry <m-chawdhry@ti.com>
> > Signed-off-by: Siddharth Vadapalli <s-vadapalli@ti.com>
> > Reviewed-by: Tom Rini <trini@konsulko.com>
> > Reviewed-by: Mattijs Korpershoek <mkorpershoek@baylibre.com>
>
> Applied to u-boot/next, thanks!
Shouldn't main_cpsw0_qsgmii_phyinit be part of the driver?? why are we
scripting up driver initialization?
--
Regards,
Nishanth Menon
Key (0xDDB5849D1736249D) / Fingerprint: F8A2 8693 54EB 8232 17A3 1A34 DDB5 849D 1736 249D
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2023-12-27 13:06 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-12-11 10:42 [PATCH] include: env: ti: ti_common: Run main_cpsw0_qsgmii_phyinit conditionally Siddharth Vadapalli
2023-12-11 19:15 ` Tom Rini
2023-12-20 17:06 ` Mattijs Korpershoek
2023-12-21 21:06 ` Tom Rini
2023-12-27 13:06 ` Nishanth Menon
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.