From: Kalle Valo <kvalo@kernel.org>
To: Jeff Johnson <quic_jjohnson@quicinc.com>
Cc: James Prestwood <prestwoj@gmail.com>, <linux-wireless@vger.kernel.org>
Subject: Re: [PATCH 1/2] wifi: ath11k: use select for CRYPTO_MICHAEL_MIC
Date: Mon, 20 Nov 2023 11:14:10 +0200 [thread overview]
Message-ID: <87pm04947x.fsf@kernel.org> (raw)
In-Reply-To: <343af05d-eab9-4411-a016-8d7d96f78379@quicinc.com> (Jeff Johnson's message of "Thu, 16 Nov 2023 11:24:56 -0800")
Jeff Johnson <quic_jjohnson@quicinc.com> writes:
> On 11/13/2023 7:35 AM, James Prestwood wrote:
>> Let ath11k select this option automatically which makes building
>> more intuitive if the user enables this driver (rather than the
>> driver not building unless CRYPTO_MICAEL_MIC is explicitly enabled)
>
> s/MICAEL/MICHAEL/
>
> add hard stop
>
> Also suggest you include (or summarize) the information that Kalle
> shared that ath is the outlier here:
>
> Further investigation shows that ath11k and ath12k are the only who use
> 'depends on' with CRYPTO_MICHAEL_MIC:
>
> ./drivers/net/wireless/intel/ipw2x00/Kconfig: select CRYPTO_MICHAEL_MIC
> ./drivers/net/wireless/intersil/hostap/Kconfig: select CRYPTO_MICHAEL_MIC
> ./drivers/net/wireless/intersil/orinoco/Kconfig: select CRYPTO_MICHAEL_MIC
> ./drivers/net/wireless/ath/ath11k/Kconfig: depends on CRYPTO_MICHAEL_MIC
> ./drivers/net/wireless/ath/ath12k/Kconfig: depends on CRYPTO_MICHAEL_MIC
> ./drivers/staging/rtl8192e/Kconfig: select CRYPTO_MICHAEL_MIC
> ./drivers/staging/ks7010/Kconfig: select CRYPTO_MICHAEL_MIC
>
> consider these comments apply to ath12k change as well :)
BTW I can add these changes in the pending branch, no need to resend
because of this.
--
https://patchwork.kernel.org/project/linux-wireless/list/
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
next prev parent reply other threads:[~2023-11-20 9:14 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-13 15:35 [PATCH 1/2] wifi: ath11k: use select for CRYPTO_MICHAEL_MIC James Prestwood
2023-11-13 15:35 ` [PATCH 2/2] wifi: ath12k: " James Prestwood
2023-11-16 19:24 ` [PATCH 1/2] wifi: ath11k: " Jeff Johnson
2023-11-20 9:14 ` Kalle Valo [this message]
2023-11-20 12:27 ` James Prestwood
2023-11-29 11:25 ` Kalle Valo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87pm04947x.fsf@kernel.org \
--to=kvalo@kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=prestwoj@gmail.com \
--cc=quic_jjohnson@quicinc.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.