* [PATCH 1/2] wifi: ath11k: use select for CRYPTO_MICHAEL_MIC
@ 2023-11-13 15:35 James Prestwood
2023-11-13 15:35 ` [PATCH 2/2] wifi: ath12k: " James Prestwood
` (2 more replies)
0 siblings, 3 replies; 6+ messages in thread
From: James Prestwood @ 2023-11-13 15:35 UTC (permalink / raw)
To: linux-wireless; +Cc: James Prestwood
Let ath11k select this option automatically which makes building
more intuitive if the user enables this driver (rather than the
driver not building unless CRYPTO_MICAEL_MIC is explicitly enabled)
Signed-off-by: James Prestwood <prestwoj@gmail.com>
---
drivers/net/wireless/ath/ath11k/Kconfig | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/wireless/ath/ath11k/Kconfig b/drivers/net/wireless/ath/ath11k/Kconfig
index ad5cc6cac05b..27f0523bf967 100644
--- a/drivers/net/wireless/ath/ath11k/Kconfig
+++ b/drivers/net/wireless/ath/ath11k/Kconfig
@@ -2,7 +2,7 @@
config ATH11K
tristate "Qualcomm Technologies 802.11ax chipset support"
depends on MAC80211 && HAS_DMA
- depends on CRYPTO_MICHAEL_MIC
+ select CRYPTO_MICHAEL_MIC
select ATH_COMMON
select QCOM_QMI_HELPERS
help
--
2.25.1
^ permalink raw reply related [flat|nested] 6+ messages in thread* [PATCH 2/2] wifi: ath12k: use select for CRYPTO_MICHAEL_MIC
2023-11-13 15:35 [PATCH 1/2] wifi: ath11k: use select for CRYPTO_MICHAEL_MIC James Prestwood
@ 2023-11-13 15:35 ` James Prestwood
2023-11-16 19:24 ` [PATCH 1/2] wifi: ath11k: " Jeff Johnson
2023-11-29 11:25 ` Kalle Valo
2 siblings, 0 replies; 6+ messages in thread
From: James Prestwood @ 2023-11-13 15:35 UTC (permalink / raw)
To: linux-wireless; +Cc: James Prestwood
Let ath12k select this option automatically which makes building
more intuitive if the user enables this driver (rather than the
driver not building unless CRYPTO_MICAEL_MIC is explicitly enabled)
Signed-off-by: James Prestwood <prestwoj@gmail.com>
---
drivers/net/wireless/ath/ath12k/Kconfig | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/wireless/ath/ath12k/Kconfig b/drivers/net/wireless/ath/ath12k/Kconfig
index 4f9c514c13e7..e135d2b1b61d 100644
--- a/drivers/net/wireless/ath/ath12k/Kconfig
+++ b/drivers/net/wireless/ath/ath12k/Kconfig
@@ -2,7 +2,7 @@
config ATH12K
tristate "Qualcomm Technologies Wi-Fi 7 support (ath12k)"
depends on MAC80211 && HAS_DMA && PCI
- depends on CRYPTO_MICHAEL_MIC
+ select CRYPTO_MICHAEL_MIC
select QCOM_QMI_HELPERS
select MHI_BUS
select QRTR
--
2.25.1
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH 1/2] wifi: ath11k: use select for CRYPTO_MICHAEL_MIC
2023-11-13 15:35 [PATCH 1/2] wifi: ath11k: use select for CRYPTO_MICHAEL_MIC James Prestwood
2023-11-13 15:35 ` [PATCH 2/2] wifi: ath12k: " James Prestwood
@ 2023-11-16 19:24 ` Jeff Johnson
2023-11-20 9:14 ` Kalle Valo
2023-11-29 11:25 ` Kalle Valo
2 siblings, 1 reply; 6+ messages in thread
From: Jeff Johnson @ 2023-11-16 19:24 UTC (permalink / raw)
To: James Prestwood, linux-wireless
On 11/13/2023 7:35 AM, James Prestwood wrote:
> Let ath11k select this option automatically which makes building
> more intuitive if the user enables this driver (rather than the
> driver not building unless CRYPTO_MICAEL_MIC is explicitly enabled)
s/MICAEL/MICHAEL/
add hard stop
Also suggest you include (or summarize) the information that Kalle
shared that ath is the outlier here:
Further investigation shows that ath11k and ath12k are the only who use
'depends on' with CRYPTO_MICHAEL_MIC:
./drivers/net/wireless/intel/ipw2x00/Kconfig: select CRYPTO_MICHAEL_MIC
./drivers/net/wireless/intersil/hostap/Kconfig: select CRYPTO_MICHAEL_MIC
./drivers/net/wireless/intersil/orinoco/Kconfig: select CRYPTO_MICHAEL_MIC
./drivers/net/wireless/ath/ath11k/Kconfig: depends on CRYPTO_MICHAEL_MIC
./drivers/net/wireless/ath/ath12k/Kconfig: depends on CRYPTO_MICHAEL_MIC
./drivers/staging/rtl8192e/Kconfig: select CRYPTO_MICHAEL_MIC
./drivers/staging/ks7010/Kconfig: select CRYPTO_MICHAEL_MIC
consider these comments apply to ath12k change as well :)
>
> Signed-off-by: James Prestwood <prestwoj@gmail.com>
> ---
> drivers/net/wireless/ath/ath11k/Kconfig | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/net/wireless/ath/ath11k/Kconfig b/drivers/net/wireless/ath/ath11k/Kconfig
> index ad5cc6cac05b..27f0523bf967 100644
> --- a/drivers/net/wireless/ath/ath11k/Kconfig
> +++ b/drivers/net/wireless/ath/ath11k/Kconfig
> @@ -2,7 +2,7 @@
> config ATH11K
> tristate "Qualcomm Technologies 802.11ax chipset support"
> depends on MAC80211 && HAS_DMA
> - depends on CRYPTO_MICHAEL_MIC
> + select CRYPTO_MICHAEL_MIC
> select ATH_COMMON
> select QCOM_QMI_HELPERS
> help
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH 1/2] wifi: ath11k: use select for CRYPTO_MICHAEL_MIC
2023-11-16 19:24 ` [PATCH 1/2] wifi: ath11k: " Jeff Johnson
@ 2023-11-20 9:14 ` Kalle Valo
2023-11-20 12:27 ` James Prestwood
0 siblings, 1 reply; 6+ messages in thread
From: Kalle Valo @ 2023-11-20 9:14 UTC (permalink / raw)
To: Jeff Johnson; +Cc: James Prestwood, linux-wireless
Jeff Johnson <quic_jjohnson@quicinc.com> writes:
> On 11/13/2023 7:35 AM, James Prestwood wrote:
>> Let ath11k select this option automatically which makes building
>> more intuitive if the user enables this driver (rather than the
>> driver not building unless CRYPTO_MICAEL_MIC is explicitly enabled)
>
> s/MICAEL/MICHAEL/
>
> add hard stop
>
> Also suggest you include (or summarize) the information that Kalle
> shared that ath is the outlier here:
>
> Further investigation shows that ath11k and ath12k are the only who use
> 'depends on' with CRYPTO_MICHAEL_MIC:
>
> ./drivers/net/wireless/intel/ipw2x00/Kconfig: select CRYPTO_MICHAEL_MIC
> ./drivers/net/wireless/intersil/hostap/Kconfig: select CRYPTO_MICHAEL_MIC
> ./drivers/net/wireless/intersil/orinoco/Kconfig: select CRYPTO_MICHAEL_MIC
> ./drivers/net/wireless/ath/ath11k/Kconfig: depends on CRYPTO_MICHAEL_MIC
> ./drivers/net/wireless/ath/ath12k/Kconfig: depends on CRYPTO_MICHAEL_MIC
> ./drivers/staging/rtl8192e/Kconfig: select CRYPTO_MICHAEL_MIC
> ./drivers/staging/ks7010/Kconfig: select CRYPTO_MICHAEL_MIC
>
> consider these comments apply to ath12k change as well :)
BTW I can add these changes in the pending branch, no need to resend
because of this.
--
https://patchwork.kernel.org/project/linux-wireless/list/
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH 1/2] wifi: ath11k: use select for CRYPTO_MICHAEL_MIC
2023-11-20 9:14 ` Kalle Valo
@ 2023-11-20 12:27 ` James Prestwood
0 siblings, 0 replies; 6+ messages in thread
From: James Prestwood @ 2023-11-20 12:27 UTC (permalink / raw)
To: Kalle Valo, Jeff Johnson; +Cc: linux-wireless
On 11/20/23 01:14, Kalle Valo wrote:
> Jeff Johnson <quic_jjohnson@quicinc.com> writes:
>
>> On 11/13/2023 7:35 AM, James Prestwood wrote:
>>> Let ath11k select this option automatically which makes building
>>> more intuitive if the user enables this driver (rather than the
>>> driver not building unless CRYPTO_MICAEL_MIC is explicitly enabled)
>> s/MICAEL/MICHAEL/
>>
>> add hard stop
>>
>> Also suggest you include (or summarize) the information that Kalle
>> shared that ath is the outlier here:
>>
>> Further investigation shows that ath11k and ath12k are the only who use
>> 'depends on' with CRYPTO_MICHAEL_MIC:
>>
>> ./drivers/net/wireless/intel/ipw2x00/Kconfig: select CRYPTO_MICHAEL_MIC
>> ./drivers/net/wireless/intersil/hostap/Kconfig: select CRYPTO_MICHAEL_MIC
>> ./drivers/net/wireless/intersil/orinoco/Kconfig: select CRYPTO_MICHAEL_MIC
>> ./drivers/net/wireless/ath/ath11k/Kconfig: depends on CRYPTO_MICHAEL_MIC
>> ./drivers/net/wireless/ath/ath12k/Kconfig: depends on CRYPTO_MICHAEL_MIC
>> ./drivers/staging/rtl8192e/Kconfig: select CRYPTO_MICHAEL_MIC
>> ./drivers/staging/ks7010/Kconfig: select CRYPTO_MICHAEL_MIC
>>
>> consider these comments apply to ath12k change as well :)
> BTW I can add these changes in the pending branch, no need to resend
> because of this.
Works for me. Had a few things come up and hadn't circled back here yet.
Thanks,
James
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH 1/2] wifi: ath11k: use select for CRYPTO_MICHAEL_MIC
2023-11-13 15:35 [PATCH 1/2] wifi: ath11k: use select for CRYPTO_MICHAEL_MIC James Prestwood
2023-11-13 15:35 ` [PATCH 2/2] wifi: ath12k: " James Prestwood
2023-11-16 19:24 ` [PATCH 1/2] wifi: ath11k: " Jeff Johnson
@ 2023-11-29 11:25 ` Kalle Valo
2 siblings, 0 replies; 6+ messages in thread
From: Kalle Valo @ 2023-11-29 11:25 UTC (permalink / raw)
To: James Prestwood; +Cc: linux-wireless, James Prestwood
James Prestwood <prestwoj@gmail.com> wrote:
> Let ath11k select this option automatically which makes building
> more intuitive if the user enables this driver (rather than the
> driver not building unless CRYPTO_MICHAEL_MIC is explicitly enabled).
>
> Further investigation shows that ath11k and ath12k are the only who use
> 'depends on' with CRYPTO_MICHAEL_MIC:
>
> ./drivers/net/wireless/intel/ipw2x00/Kconfig: select CRYPTO_MICHAEL_MIC
> ./drivers/net/wireless/intersil/hostap/Kconfig: select CRYPTO_MICHAEL_MIC
> ./drivers/net/wireless/intersil/orinoco/Kconfig: select CRYPTO_MICHAEL_MIC
> ./drivers/net/wireless/ath/ath11k/Kconfig: depends on CRYPTO_MICHAEL_MIC
> ./drivers/net/wireless/ath/ath12k/Kconfig: depends on CRYPTO_MICHAEL_MIC
> ./drivers/staging/rtl8192e/Kconfig: select CRYPTO_MICHAEL_MIC
> ./drivers/staging/ks7010/Kconfig: select CRYPTO_MICHAEL_MIC
>
> Signed-off-by: James Prestwood <prestwoj@gmail.com>
> Signed-off-by: Kalle Valo <quic_kvalo@quicinc.com>
2 patches applied to ath-next branch of ath.git, thanks.
a466027abe4a wifi: ath11k: use select for CRYPTO_MICHAEL_MIC
c7b4f54112e1 wifi: ath12k: use select for CRYPTO_MICHAEL_MIC
--
https://patchwork.kernel.org/project/linux-wireless/patch/20231113153544.282461-1-prestwoj@gmail.com/
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2023-11-29 11:25 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-11-13 15:35 [PATCH 1/2] wifi: ath11k: use select for CRYPTO_MICHAEL_MIC James Prestwood
2023-11-13 15:35 ` [PATCH 2/2] wifi: ath12k: " James Prestwood
2023-11-16 19:24 ` [PATCH 1/2] wifi: ath11k: " Jeff Johnson
2023-11-20 9:14 ` Kalle Valo
2023-11-20 12:27 ` James Prestwood
2023-11-29 11:25 ` Kalle Valo
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.