From: Jonathan Corbet <corbet@lwn.net>
To: Mauro Carvalho Chehab <mchehab@kernel.org>,
Linux Doc Mailing List <linux-doc@vger.kernel.org>
Cc: Mauro Carvalho Chehab <mchehab@kernel.org>,
Mauro Carvalho Chehab <mchehab+huawei@kernel.org>,
linux-kernel@vger.kernel.org, Daniel Vetter <daniel@ffwll.ch>,
David Airlie <airlied@gmail.com>,
dri-devel@lists.freedesktop.org
Subject: Re: [PATCH 0/2] Add support for inlined documentation for kunit and kselftests
Date: Tue, 03 Oct 2023 11:00:20 -0600 [thread overview]
Message-ID: <87pm1vd4kb.fsf@meer.lwn.net> (raw)
In-Reply-To: <cover.1693550658.git.mchehab@kernel.org>
Mauro Carvalho Chehab <mchehab@kernel.org> writes:
> This is a follow-up of the discussions taken here:
>
> https://lore.kernel.org/linux-doc/20230704132812.02ba97ba@maurocar-mobl2/T/#t
>
> I sent a previous version as RFC. This is basically what we had there, with some
> improvements at test_list.py.
>
> It adds a new extension that allows documenting tests using the same tool we're
> using for DRM unit tests at IGT GPU tools: https://gitlab.freedesktop.org/drm/igt-gpu-tools.
>
> While kernel-doc has provided documentation for in-lined functions/struct comments,
> it was not meant to document tests.
>
> Tests need to be grouped by the test functions. It should also be possible to produce
> other outputs from the documentation, to integrate it with test suites. For instance,
> Internally at Intel, we use the comments to generate DOT files hierarchically grouped
> per feature categories.
>
> This is meant to be an initial series to start documenting kunit.
I've played with this a bit...a couple of quick impressions:
- That's quite a chunk of Python code to be adding. I've not yet had
the chance to read it through properly, will hopefully be able to do
so soon. A bit more commenting would not have gone amiss here...
- I kind of think that this should go under dev-tools rather than being
a new top-level directory. Is there a reason not to put it there?
Thanks,
jon
WARNING: multiple messages have this Message-ID (diff)
From: Jonathan Corbet <corbet@lwn.net>
To: Mauro Carvalho Chehab <mchehab@kernel.org>,
Linux Doc Mailing List <linux-doc@vger.kernel.org>
Cc: Mauro Carvalho Chehab <mchehab+huawei@kernel.org>,
linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org,
Mauro Carvalho Chehab <mchehab@kernel.org>
Subject: Re: [PATCH 0/2] Add support for inlined documentation for kunit and kselftests
Date: Tue, 03 Oct 2023 11:00:20 -0600 [thread overview]
Message-ID: <87pm1vd4kb.fsf@meer.lwn.net> (raw)
In-Reply-To: <cover.1693550658.git.mchehab@kernel.org>
Mauro Carvalho Chehab <mchehab@kernel.org> writes:
> This is a follow-up of the discussions taken here:
>
> https://lore.kernel.org/linux-doc/20230704132812.02ba97ba@maurocar-mobl2/T/#t
>
> I sent a previous version as RFC. This is basically what we had there, with some
> improvements at test_list.py.
>
> It adds a new extension that allows documenting tests using the same tool we're
> using for DRM unit tests at IGT GPU tools: https://gitlab.freedesktop.org/drm/igt-gpu-tools.
>
> While kernel-doc has provided documentation for in-lined functions/struct comments,
> it was not meant to document tests.
>
> Tests need to be grouped by the test functions. It should also be possible to produce
> other outputs from the documentation, to integrate it with test suites. For instance,
> Internally at Intel, we use the comments to generate DOT files hierarchically grouped
> per feature categories.
>
> This is meant to be an initial series to start documenting kunit.
I've played with this a bit...a couple of quick impressions:
- That's quite a chunk of Python code to be adding. I've not yet had
the chance to read it through properly, will hopefully be able to do
so soon. A bit more commenting would not have gone amiss here...
- I kind of think that this should go under dev-tools rather than being
a new top-level directory. Is there a reason not to put it there?
Thanks,
jon
next prev parent reply other threads:[~2023-10-03 17:00 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-01 6:51 [PATCH 0/2] Add support for inlined documentation for kunit and kselftests Mauro Carvalho Chehab
2023-09-01 6:51 ` Mauro Carvalho Chehab
2023-09-01 6:51 ` [PATCH 1/2] docs: add support for documenting kUnit and kSelftests Mauro Carvalho Chehab
2023-09-01 6:51 ` [PATCH 2/2] drm: add documentation for drm_buddy_test kUnit test Mauro Carvalho Chehab
2023-09-01 6:51 ` Mauro Carvalho Chehab
2023-10-03 17:04 ` Jonathan Corbet
2023-10-03 17:04 ` Jonathan Corbet
2023-10-03 17:00 ` Jonathan Corbet [this message]
2023-10-03 17:00 ` [PATCH 0/2] Add support for inlined documentation for kunit and kselftests Jonathan Corbet
2023-10-07 8:09 ` Mauro Carvalho Chehab
2023-10-07 8:09 ` Mauro Carvalho Chehab
2023-10-07 12:52 ` Jonathan Corbet
2023-10-07 12:52 ` Jonathan Corbet
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87pm1vd4kb.fsf@meer.lwn.net \
--to=corbet@lwn.net \
--cc=airlied@gmail.com \
--cc=daniel@ffwll.ch \
--cc=dri-devel@lists.freedesktop.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mchehab+huawei@kernel.org \
--cc=mchehab@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.