All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Eric W. Biederman" <ebiederm@gmail.com>
To: Taylor Blau <me@ttaylorr.com>
Cc: Junio C Hamano <gitster@pobox.com>,
	"brian m. carlson" <sandals@crustytoothpaste.net>,
	git@vger.kernel.org
Subject: Re: [PATCH v3] bulk-checkin: only support blobs in index_bulk_checkin
Date: Wed, 27 Sep 2023 15:13:33 -0500	[thread overview]
Message-ID: <87pm23idci.fsf@gmail.froward.int.ebiederm.org> (raw)
In-Reply-To: <ZROHrSmmZOIE6bl9@nand.local> (Taylor Blau's message of "Tue, 26 Sep 2023 21:38:53 -0400")

Taylor Blau <me@ttaylorr.com> writes:

> On Tue, Sep 26, 2023 at 02:48:31PM -0700, Junio C Hamano wrote:
>> > Avoid all of those future complications by limiting index_bulk_checkin
>> > to only work on blobs.
>>
>> Thanks.  Will queue.
>
> Hmm. I wonder if retaining some flexibility in the bulk-checkin
> mechanism may be worthwhile. We discussed at the Contributor's
> Summit[^1] today that the bulk-checkin system may be a good fit for
> packing any blobs/trees created by `merge-tree` or `replay` instead of
> writing them out as loose objects.
>
> Being able to write trees in addition to blobs is definitely important
> there, so we may want to wait on merging this down until that direction
> solidifies a bit more. (FWIW, I started working on that today and hope
> to have patches on the list in the next day or two).
>
> Alternatively, if there is an urgency to merge these down, we can always
> come back to it in the future and revert it if need be. Either way
> :-).

There are two things that index_bulk_checkin does.
- Handle objects that are too large to fit into a memory
- Place objects immediately in a pack.

Do I read things correctly that you want to take an object that is small
enough to fit into memory, and to immediately into a pack?

If so you essentially want write_object_file that directly writes to a
pack?

A version of write_object_file that that directly writes to a pack is
much easier than the chunking that index_bulk_checkin does.

Perhaps your version could be called index_pack_checkin?

Eric

  parent reply	other threads:[~2023-09-27 20:13 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-09-20  3:52 [PATCH v2] bulk-checkin: only support blobs in index_bulk_checkin Eric W. Biederman
2023-09-20  6:59 ` Junio C Hamano
2023-09-20 12:24   ` Eric W. Biederman
2023-09-26 15:58     ` [PATCH v3] " Eric W. Biederman
2023-09-26 21:48       ` Junio C Hamano
2023-09-27  1:38         ` Taylor Blau
2023-09-27  4:08           ` Junio C Hamano
2023-09-27 14:34             ` Taylor Blau
2023-09-27 16:26               ` Junio C Hamano
2023-09-27 20:06                 ` Eric W. Biederman
2023-09-27 20:13           ` Eric W. Biederman [this message]
2023-09-28  9:39       ` Oswald Buddenhagen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87pm23idci.fsf@gmail.froward.int.ebiederm.org \
    --to=ebiederm@gmail.com \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    --cc=me@ttaylorr.com \
    --cc=sandals@crustytoothpaste.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.