From: Oswald Buddenhagen <oswald.buddenhagen@gmx.de>
To: "Eric W. Biederman" <ebiederm@gmail.com>
Cc: Junio C Hamano <gitster@pobox.com>,
"brian m. carlson" <sandals@crustytoothpaste.net>,
git@vger.kernel.org
Subject: Re: [PATCH v3] bulk-checkin: only support blobs in index_bulk_checkin
Date: Thu, 28 Sep 2023 11:39:58 +0200 [thread overview]
Message-ID: <ZRVJ7pjQ35Stw9X4@ugly> (raw)
In-Reply-To: <87msx99b9o.fsf_-_@gmail.froward.int.ebiederm.org>
just language nits on the commit message:
On Tue, Sep 26, 2023 at 10:58:43AM -0500, Eric W. Biederman wrote:
>Not supporting commits, tags, or trees has no downside as it is not
>currently supported now, and commits, tags, and trees being smaller by
>design do not have the problem that the problem that index_bulk_checkin
^^^^^^^^^^^^^^^^
duplicated!
>was built to solve.
>A version of index_bulk_checkin that supports more than just blobs when
>computing both the SHA-1 and the SHA-256 of every object added would
>need a different, and more expensive structure. The structure is more
>expensive because it would be required to temporarily buffering the
^^^
no 'ing' here.
>equivalent object the compatibility hash needs to be computed over.
>A temporary object is needed, because before a hash over an object can
>computed it's
>
"be computed, its"
>object header needs to be computed. One of the members of
regards
prev parent reply other threads:[~2023-09-28 9:40 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-20 3:52 [PATCH v2] bulk-checkin: only support blobs in index_bulk_checkin Eric W. Biederman
2023-09-20 6:59 ` Junio C Hamano
2023-09-20 12:24 ` Eric W. Biederman
2023-09-26 15:58 ` [PATCH v3] " Eric W. Biederman
2023-09-26 21:48 ` Junio C Hamano
2023-09-27 1:38 ` Taylor Blau
2023-09-27 4:08 ` Junio C Hamano
2023-09-27 14:34 ` Taylor Blau
2023-09-27 16:26 ` Junio C Hamano
2023-09-27 20:06 ` Eric W. Biederman
2023-09-27 20:13 ` Eric W. Biederman
2023-09-28 9:39 ` Oswald Buddenhagen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZRVJ7pjQ35Stw9X4@ugly \
--to=oswald.buddenhagen@gmx.de \
--cc=ebiederm@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=sandals@crustytoothpaste.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.