All of lore.kernel.org
 help / color / mirror / Atom feed
From: Kalle Valo <kvalo@kernel.org>
To: Aloka Dixit <quic_alokad@quicinc.com>
Cc: <ath12k@lists.infradead.org>,  <linux-wireless@vger.kernel.org>,
	 Pradeep Kumar Chitrapu <quic_pradeepc@quicinc.com>
Subject: Re: [PATCH v4 04/11] wifi: ath12k: propagate EHT capabilities to userspace
Date: Thu, 15 Jun 2023 14:51:47 +0300	[thread overview]
Message-ID: <87pm5xaqp8.fsf@kernel.org> (raw)
In-Reply-To: <20230602235820.23912-5-quic_alokad@quicinc.com> (Aloka Dixit's message of "Fri, 2 Jun 2023 16:58:13 -0700")

Aloka Dixit <quic_alokad@quicinc.com> writes:

> Propagate EHT capabilities to the userspace using a new member
> 'eht_cap' in structure ieee80211_sband_iftype_data.
>
> MCS-NSS capabilities are copied depending on the supported bandwidths
> for the given band.
>
> Tested-on: QCN9274 hw2.0 PCI WLAN.WBE.1.0.1-00029-QCAHKSWPL_SILICONZ-1
> Signed-off-by: Aloka Dixit <quic_alokad@quicinc.com>
> Signed-off-by: Pradeep Kumar Chitrapu<quic_pradeepc@quicinc.com>

[...]

> +static void ath12k_mac_copy_eht_ppet_ru(u32 ppet, u8 ppe_thres[], int ru)
> +{
> +	int i;
> +	u32 val = 0;
> +	u8 ppet_size_ru = IEEE80211_EHT_PPE_THRES_INFO_PPET_SIZE * 2;
> +	u8 bit = IEEE80211_EHT_PPE_THRES_INFO_HEADER_SIZE;
> +
> +	u32p_replace_bits(&val, ppet >> (ru * ppet_size_ru),
> +			  GENMASK(ppet_size_ru - 1, 0));
> +
> +	val = ((val >> IEEE80211_EHT_PPE_THRES_INFO_PPET_SIZE) & GENMASK(2, 0)) |
> +	      ((val & GENMASK(2, 0)) << IEEE80211_EHT_PPE_THRES_INFO_PPET_SIZE);

This shifting of val looks weird. I didn't check the spec, what does it
do? Is there any cleaner way to do this? And should have a define for
GENMASK(2, 0)?

-- 
https://patchwork.kernel.org/project/linux-wireless/list/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches

-- 
ath12k mailing list
ath12k@lists.infradead.org
https://lists.infradead.org/mailman/listinfo/ath12k

WARNING: multiple messages have this Message-ID (diff)
From: Kalle Valo <kvalo@kernel.org>
To: Aloka Dixit <quic_alokad@quicinc.com>
Cc: <ath12k@lists.infradead.org>, <linux-wireless@vger.kernel.org>,
	Pradeep Kumar Chitrapu <quic_pradeepc@quicinc.com>
Subject: Re: [PATCH v4 04/11] wifi: ath12k: propagate EHT capabilities to userspace
Date: Thu, 15 Jun 2023 14:51:47 +0300	[thread overview]
Message-ID: <87pm5xaqp8.fsf@kernel.org> (raw)
In-Reply-To: <20230602235820.23912-5-quic_alokad@quicinc.com> (Aloka Dixit's message of "Fri, 2 Jun 2023 16:58:13 -0700")

Aloka Dixit <quic_alokad@quicinc.com> writes:

> Propagate EHT capabilities to the userspace using a new member
> 'eht_cap' in structure ieee80211_sband_iftype_data.
>
> MCS-NSS capabilities are copied depending on the supported bandwidths
> for the given band.
>
> Tested-on: QCN9274 hw2.0 PCI WLAN.WBE.1.0.1-00029-QCAHKSWPL_SILICONZ-1
> Signed-off-by: Aloka Dixit <quic_alokad@quicinc.com>
> Signed-off-by: Pradeep Kumar Chitrapu<quic_pradeepc@quicinc.com>

[...]

> +static void ath12k_mac_copy_eht_ppet_ru(u32 ppet, u8 ppe_thres[], int ru)
> +{
> +	int i;
> +	u32 val = 0;
> +	u8 ppet_size_ru = IEEE80211_EHT_PPE_THRES_INFO_PPET_SIZE * 2;
> +	u8 bit = IEEE80211_EHT_PPE_THRES_INFO_HEADER_SIZE;
> +
> +	u32p_replace_bits(&val, ppet >> (ru * ppet_size_ru),
> +			  GENMASK(ppet_size_ru - 1, 0));
> +
> +	val = ((val >> IEEE80211_EHT_PPE_THRES_INFO_PPET_SIZE) & GENMASK(2, 0)) |
> +	      ((val & GENMASK(2, 0)) << IEEE80211_EHT_PPE_THRES_INFO_PPET_SIZE);

This shifting of val looks weird. I didn't check the spec, what does it
do? Is there any cleaner way to do this? And should have a define for
GENMASK(2, 0)?

-- 
https://patchwork.kernel.org/project/linux-wireless/list/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches

  reply	other threads:[~2023-06-15 11:51 UTC|newest]

Thread overview: 50+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-06-02 23:58 [PATCH v4 00/11] wifi: ath12k: (v4) EHT support Aloka Dixit
2023-06-02 23:58 ` Aloka Dixit
2023-06-02 23:58 ` [PATCH v4 01/11] wifi: ath12k: rename HE capabilities setup/copy functions Aloka Dixit
2023-06-02 23:58   ` Aloka Dixit
2023-06-02 23:58 ` [PATCH v4 02/11] wifi: ath12k: move HE capabilities processing to a new function Aloka Dixit
2023-06-02 23:58   ` Aloka Dixit
2023-06-02 23:58 ` [PATCH v4 03/11] wifi: ath12k: WMI support to process EHT capabilities Aloka Dixit
2023-06-02 23:58   ` Aloka Dixit
2023-06-15 11:49   ` Kalle Valo
2023-06-15 11:49     ` Kalle Valo
2023-06-16 10:50     ` Wen Gong
2023-06-16 10:50       ` Wen Gong
2023-07-24 17:42       ` Aloka Dixit
2023-07-24 17:42         ` Aloka Dixit
2023-07-25 10:51     ` Wen Gong
2023-07-25 10:51       ` Wen Gong
2023-07-25 19:44       ` Aloka Dixit
2023-07-25 19:44         ` Aloka Dixit
2023-06-02 23:58 ` [PATCH v4 04/11] wifi: ath12k: propagate EHT capabilities to userspace Aloka Dixit
2023-06-02 23:58   ` Aloka Dixit
2023-06-15 11:51   ` Kalle Valo [this message]
2023-06-15 11:51     ` Kalle Valo
2023-07-24 18:11     ` Aloka Dixit
2023-07-24 18:11       ` Aloka Dixit
2023-06-02 23:58 ` [PATCH v4 05/11] wifi: ath12k: add EHT PHY modes Aloka Dixit
2023-06-02 23:58   ` Aloka Dixit
2023-06-02 23:58 ` [PATCH v4 06/11] wifi: ath12k: prepare EHT peer assoc parameters Aloka Dixit
2023-06-02 23:58   ` Aloka Dixit
2023-07-24 10:16   ` Wen Gong
2023-07-24 10:16     ` Wen Gong
2023-07-24 18:24     ` Aloka Dixit
2023-07-24 18:24       ` Aloka Dixit
2023-07-25 10:07       ` Wen Gong
2023-07-25 10:07         ` Wen Gong
2023-07-25 22:44         ` Aloka Dixit
2023-07-25 22:44           ` Aloka Dixit
2023-06-02 23:58 ` [PATCH v4 07/11] wifi: ath12k: add WMI support for EHT peer Aloka Dixit
2023-06-02 23:58   ` Aloka Dixit
2023-06-02 23:58 ` [PATCH v4 08/11] wifi: ath12k: peer assoc for 320 MHz Aloka Dixit
2023-06-02 23:58   ` Aloka Dixit
2023-06-02 23:58 ` [PATCH v4 09/11] wifi: ath12k: add MLO header in peer association Aloka Dixit
2023-06-02 23:58   ` Aloka Dixit
2023-06-02 23:58 ` [PATCH v4 10/11] wifi: ath12k: parse WMI service ready ext2 event Aloka Dixit
2023-06-02 23:58   ` Aloka Dixit
2023-06-02 23:58 ` [PATCH v4 11/11] wifi: ath12k: configure puncturing bitmap Aloka Dixit
2023-06-02 23:58   ` Aloka Dixit
2023-06-15 11:47 ` [PATCH v4 00/11] wifi: ath12k: (v4) EHT support Kalle Valo
2023-06-15 11:47   ` Kalle Valo
2023-07-24 17:43   ` Aloka Dixit
2023-07-24 17:43     ` Aloka Dixit

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87pm5xaqp8.fsf@kernel.org \
    --to=kvalo@kernel.org \
    --cc=ath12k@lists.infradead.org \
    --cc=linux-wireless@vger.kernel.org \
    --cc=quic_alokad@quicinc.com \
    --cc=quic_pradeepc@quicinc.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.