From: Gregory CLEMENT <gregory.clement@bootlin.com>
To: "Pali Rohár" <pali@kernel.org>, "Andrew Lunn" <andrew@lunn.ch>,
devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH V2] arm64: dts: marvell: add DTS for GL.iNet GL-MV1000
Date: Fri, 07 Apr 2023 17:24:27 +0200 [thread overview]
Message-ID: <87pm8f3ec4.fsf@BL-laptop> (raw)
In-Reply-To: <20230203174618.arqh2gqspoh3rlt6@pali>
Pali Rohár <pali@kernel.org> writes:
> On Thursday 02 February 2023 10:37:06 Enrico Mioso wrote:
>> The GL-MV1000 (Brume) is a small form-factor gateway router.
>> It is based on the Marvell Armada 88F3720 SOC (1GHz), has 3 gigabit ethernet ports, 1 GB RAM, 16M SPI flash, 8GB eMMC and an uSD slot, as well as an USB 2.0 type A and an USB 3.0 type C port.
>>
>> Signed-off-by: Enrico Mioso <mrkiko.rs@gmail.com>
>> CC: Pali <pali@kernel.org>
>
> Looks good,
>
> Reviewed-by: Pali Rohár <pali@kernel.org>
Applied on mvebu/dt64
Thanks,
Gregory
>
>> ---
>> arch/arm64/boot/dts/marvell/Makefile | 1 +
>> .../dts/marvell/armada-3720-gl-mv1000.dts | 239 ++++++++++++++++++
>> 2 files changed, 240 insertions(+)
>> create mode 100644 arch/arm64/boot/dts/marvell/armada-3720-gl-mv1000.dts
>>
>> diff --git a/arch/arm64/boot/dts/marvell/Makefile b/arch/arm64/boot/dts/marvell/Makefile
>> index 058237681fe5..79ac09b58a89 100644
>> --- a/arch/arm64/boot/dts/marvell/Makefile
>> +++ b/arch/arm64/boot/dts/marvell/Makefile
>> @@ -7,6 +7,7 @@ dtb-$(CONFIG_ARCH_MVEBU) += armada-3720-espressobin-emmc.dtb
>> dtb-$(CONFIG_ARCH_MVEBU) += armada-3720-espressobin-ultra.dtb
>> dtb-$(CONFIG_ARCH_MVEBU) += armada-3720-espressobin-v7.dtb
>> dtb-$(CONFIG_ARCH_MVEBU) += armada-3720-espressobin-v7-emmc.dtb
>> +dtb-$(CONFIG_ARCH_MVEBU) += armada-3720-gl-mv1000.dtb
>> dtb-$(CONFIG_ARCH_MVEBU) += armada-3720-turris-mox.dtb
>> dtb-$(CONFIG_ARCH_MVEBU) += armada-3720-uDPU.dtb
>> dtb-$(CONFIG_ARCH_MVEBU) += armada-7040-db.dtb
>> diff --git a/arch/arm64/boot/dts/marvell/armada-3720-gl-mv1000.dts b/arch/arm64/boot/dts/marvell/armada-3720-gl-mv1000.dts
>> new file mode 100644
>> index 000000000000..b1b45b4fa9d4
>> --- /dev/null
>> +++ b/arch/arm64/boot/dts/marvell/armada-3720-gl-mv1000.dts
>> @@ -0,0 +1,239 @@
>> +// SPDX-License-Identifier: (GPL-2.0-or-later OR MIT)
>> +
>> +/dts-v1/;
>> +#include <dt-bindings/gpio/gpio.h>
>> +#include <dt-bindings/input/input.h>
>> +#include "armada-372x.dtsi"
>> +
>> +/ {
>> + model = "GL.iNet GL-MV1000";
>> + compatible = "glinet,gl-mv1000", "marvell,armada3720";
>> +
>> + aliases {
>> + led-boot = &led_power;
>> + led-failsafe = &led_power;
>> + led-running = &led_power;
>> + led-upgrade = &led_power;
>> + };
>> +
>> + chosen {
>> + stdout-path = "serial0:115200n8";
>> + };
>> +
>> + memory@0 {
>> + device_type = "memory";
>> + reg = <0x00000000 0x00000000 0x00000000 0x20000000>;
>> + };
>> +
>> + vcc_sd_reg1: regulator {
>> + compatible = "regulator-gpio";
>> + regulator-name = "vcc_sd1";
>> + regulator-min-microvolt = <1800000>;
>> + regulator-max-microvolt = <3300000>;
>> + regulator-boot-on;
>> +
>> + gpios-states = <0>;
>> + states = <1800000 0x1
>> + 3300000 0x0>;
>> + enable-active-high;
>> + };
>> +
>> + keys {
>> + compatible = "gpio-keys";
>> +
>> + reset {
>> + label = "reset";
>> + linux,code = <KEY_RESTART>;
>> + gpios = <&gpionb 14 GPIO_ACTIVE_LOW>;
>> + };
>> +
>> + switch {
>> + label = "switch";
>> + linux,code = <BTN_0>;
>> + gpios = <&gpiosb 22 GPIO_ACTIVE_LOW>;
>> + };
>> + };
>> +
>> + leds {
>> + compatible = "gpio-leds";
>> +
>> + vpn {
>> + label = "green:vpn";
>> + gpios = <&gpionb 11 GPIO_ACTIVE_LOW>;
>> + };
>> +
>> + wan {
>> + label = "green:wan";
>> + gpios = <&gpionb 12 GPIO_ACTIVE_LOW>;
>> + };
>> +
>> + led_power: power {
>> + label = "green:power";
>> + gpios = <&gpionb 13 GPIO_ACTIVE_LOW>;
>> + default-state = "on";
>> + };
>> + };
>> +};
>> +
>> +&spi0 {
>> + status = "okay";
>> +
>> + flash@0 {
>> + reg = <0>;
>> + compatible = "jedec,spi-nor";
>> + spi-max-frequency = <104000000>;
>> + m25p,fast-read;
>> + partitions {
>> + compatible = "fixed-partitions";
>> + #address-cells = <1>;
>> + #size-cells = <1>;
>> +
>> + partition@0 {
>> + label = "firmware";
>> + reg = <0 0xf0000>;
>> + };
>> +
>> + partition@f0000 {
>> + label = "u-boot-env";
>> + reg = <0xf0000 0x8000>;
>> + };
>> +
>> + factory: partition@f8000 {
>> + label = "factory";
>> + reg = <0xf8000 0x8000>;
>> + read-only;
>> + };
>> +
>> + partition@100000 {
>> + label = "dtb";
>> + reg = <0x100000 0x10000>;
>> + read-only;
>> + };
>> +
>> + partition@110000 {
>> + label = "rescue";
>> + reg = <0x110000 0x1000000>;
>> + };
>> + };
>> + };
>> +};
>> +
>> +&sdhci1 {
>> + wp-inverted;
>> + bus-width = <4>;
>> + cd-gpios = <&gpionb 17 GPIO_ACTIVE_LOW>;
>> + marvell,pad-type = "sd";
>> + no-1-8-v;
>> + vqmmc-supply = <&vcc_sd_reg1>;
>> + status = "okay";
>> +};
>> +
>> +&sdhci0 {
>> + bus-width = <8>;
>> + mmc-ddr-1_8v;
>> + mmc-hs400-1_8v;
>> + non-removable;
>> + no-sd;
>> + no-sdio;
>> + marvell,pad-type = "fixed-1-8v";
>> + status = "okay";
>> +};
>> +
>> +&usb3 {
>> + status = "okay";
>> +};
>> +
>> +&usb2 {
>> + status = "okay";
>> +};
>> +
>> +&uart0 {
>> + status = "okay";
>> +};
>> +
>> +&mdio {
>> + switch0: switch0@1 {
>> + compatible = "marvell,mv88e6085";
>> + #address-cells = <1>;
>> + #size-cells = <0>;
>> + reg = <1>;
>> +
>> + dsa,member = <0 0>;
>> +
>> + ports: ports {
>> + #address-cells = <1>;
>> + #size-cells = <0>;
>> +
>> + port@0 {
>> + reg = <0>;
>> + label = "cpu";
>> + ethernet = <ð0>;
>> + };
>> +
>> + port@1 {
>> + reg = <1>;
>> + label = "wan";
>> + phy-handle = <&switch0phy0>;
>> + };
>> +
>> + port@2 {
>> + reg = <2>;
>> + label = "lan0";
>> + phy-handle = <&switch0phy1>;
>> +
>> + nvmem-cells = <&macaddr_factory_6>;
>> + nvmem-cell-names = "mac-address";
>> + };
>> +
>> + port@3 {
>> + reg = <3>;
>> + label = "lan1";
>> + phy-handle = <&switch0phy2>;
>> +
>> + nvmem-cells = <&macaddr_factory_6>;
>> + nvmem-cell-names = "mac-address";
>> + };
>> + };
>> +
>> + mdio {
>> + #address-cells = <1>;
>> + #size-cells = <0>;
>> +
>> + switch0phy0: switch0phy0@11 {
>> + reg = <0x11>;
>> + };
>> + switch0phy1: switch0phy1@12 {
>> + reg = <0x12>;
>> + };
>> + switch0phy2: switch0phy2@13 {
>> + reg = <0x13>;
>> + };
>> + };
>> + };
>> +};
>> +
>> +ð0 {
>> + nvmem-cells = <&macaddr_factory_0>;
>> + nvmem-cell-names = "mac-address";
>> + phy-mode = "rgmii-id";
>> + status = "okay";
>> +
>> + fixed-link {
>> + speed = <1000>;
>> + full-duplex;
>> + };
>> +};
>> +
>> +&factory {
>> + compatible = "nvmem-cells";
>> + #address-cells = <1>;
>> + #size-cells = <1>;
>> +
>> + macaddr_factory_0: macaddr@0 {
>> + reg = <0x0 0x6>;
>> + };
>> +
>> + macaddr_factory_6: macaddr@6 {
>> + reg = <0x6 0x6>;
>> + };
>> +};
>> --
>> 2.39.1
>>
--
Gregory Clement, Bootlin
Embedded Linux and Kernel engineering
http://bootlin.com
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
WARNING: multiple messages have this Message-ID (diff)
From: Gregory CLEMENT <gregory.clement@bootlin.com>
To: "Pali Rohár" <pali@kernel.org>, "Andrew Lunn" <andrew@lunn.ch>,
devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH V2] arm64: dts: marvell: add DTS for GL.iNet GL-MV1000
Date: Fri, 07 Apr 2023 17:24:27 +0200 [thread overview]
Message-ID: <87pm8f3ec4.fsf@BL-laptop> (raw)
In-Reply-To: <20230203174618.arqh2gqspoh3rlt6@pali>
Pali Rohár <pali@kernel.org> writes:
> On Thursday 02 February 2023 10:37:06 Enrico Mioso wrote:
>> The GL-MV1000 (Brume) is a small form-factor gateway router.
>> It is based on the Marvell Armada 88F3720 SOC (1GHz), has 3 gigabit ethernet ports, 1 GB RAM, 16M SPI flash, 8GB eMMC and an uSD slot, as well as an USB 2.0 type A and an USB 3.0 type C port.
>>
>> Signed-off-by: Enrico Mioso <mrkiko.rs@gmail.com>
>> CC: Pali <pali@kernel.org>
>
> Looks good,
>
> Reviewed-by: Pali Rohár <pali@kernel.org>
Applied on mvebu/dt64
Thanks,
Gregory
>
>> ---
>> arch/arm64/boot/dts/marvell/Makefile | 1 +
>> .../dts/marvell/armada-3720-gl-mv1000.dts | 239 ++++++++++++++++++
>> 2 files changed, 240 insertions(+)
>> create mode 100644 arch/arm64/boot/dts/marvell/armada-3720-gl-mv1000.dts
>>
>> diff --git a/arch/arm64/boot/dts/marvell/Makefile b/arch/arm64/boot/dts/marvell/Makefile
>> index 058237681fe5..79ac09b58a89 100644
>> --- a/arch/arm64/boot/dts/marvell/Makefile
>> +++ b/arch/arm64/boot/dts/marvell/Makefile
>> @@ -7,6 +7,7 @@ dtb-$(CONFIG_ARCH_MVEBU) += armada-3720-espressobin-emmc.dtb
>> dtb-$(CONFIG_ARCH_MVEBU) += armada-3720-espressobin-ultra.dtb
>> dtb-$(CONFIG_ARCH_MVEBU) += armada-3720-espressobin-v7.dtb
>> dtb-$(CONFIG_ARCH_MVEBU) += armada-3720-espressobin-v7-emmc.dtb
>> +dtb-$(CONFIG_ARCH_MVEBU) += armada-3720-gl-mv1000.dtb
>> dtb-$(CONFIG_ARCH_MVEBU) += armada-3720-turris-mox.dtb
>> dtb-$(CONFIG_ARCH_MVEBU) += armada-3720-uDPU.dtb
>> dtb-$(CONFIG_ARCH_MVEBU) += armada-7040-db.dtb
>> diff --git a/arch/arm64/boot/dts/marvell/armada-3720-gl-mv1000.dts b/arch/arm64/boot/dts/marvell/armada-3720-gl-mv1000.dts
>> new file mode 100644
>> index 000000000000..b1b45b4fa9d4
>> --- /dev/null
>> +++ b/arch/arm64/boot/dts/marvell/armada-3720-gl-mv1000.dts
>> @@ -0,0 +1,239 @@
>> +// SPDX-License-Identifier: (GPL-2.0-or-later OR MIT)
>> +
>> +/dts-v1/;
>> +#include <dt-bindings/gpio/gpio.h>
>> +#include <dt-bindings/input/input.h>
>> +#include "armada-372x.dtsi"
>> +
>> +/ {
>> + model = "GL.iNet GL-MV1000";
>> + compatible = "glinet,gl-mv1000", "marvell,armada3720";
>> +
>> + aliases {
>> + led-boot = &led_power;
>> + led-failsafe = &led_power;
>> + led-running = &led_power;
>> + led-upgrade = &led_power;
>> + };
>> +
>> + chosen {
>> + stdout-path = "serial0:115200n8";
>> + };
>> +
>> + memory@0 {
>> + device_type = "memory";
>> + reg = <0x00000000 0x00000000 0x00000000 0x20000000>;
>> + };
>> +
>> + vcc_sd_reg1: regulator {
>> + compatible = "regulator-gpio";
>> + regulator-name = "vcc_sd1";
>> + regulator-min-microvolt = <1800000>;
>> + regulator-max-microvolt = <3300000>;
>> + regulator-boot-on;
>> +
>> + gpios-states = <0>;
>> + states = <1800000 0x1
>> + 3300000 0x0>;
>> + enable-active-high;
>> + };
>> +
>> + keys {
>> + compatible = "gpio-keys";
>> +
>> + reset {
>> + label = "reset";
>> + linux,code = <KEY_RESTART>;
>> + gpios = <&gpionb 14 GPIO_ACTIVE_LOW>;
>> + };
>> +
>> + switch {
>> + label = "switch";
>> + linux,code = <BTN_0>;
>> + gpios = <&gpiosb 22 GPIO_ACTIVE_LOW>;
>> + };
>> + };
>> +
>> + leds {
>> + compatible = "gpio-leds";
>> +
>> + vpn {
>> + label = "green:vpn";
>> + gpios = <&gpionb 11 GPIO_ACTIVE_LOW>;
>> + };
>> +
>> + wan {
>> + label = "green:wan";
>> + gpios = <&gpionb 12 GPIO_ACTIVE_LOW>;
>> + };
>> +
>> + led_power: power {
>> + label = "green:power";
>> + gpios = <&gpionb 13 GPIO_ACTIVE_LOW>;
>> + default-state = "on";
>> + };
>> + };
>> +};
>> +
>> +&spi0 {
>> + status = "okay";
>> +
>> + flash@0 {
>> + reg = <0>;
>> + compatible = "jedec,spi-nor";
>> + spi-max-frequency = <104000000>;
>> + m25p,fast-read;
>> + partitions {
>> + compatible = "fixed-partitions";
>> + #address-cells = <1>;
>> + #size-cells = <1>;
>> +
>> + partition@0 {
>> + label = "firmware";
>> + reg = <0 0xf0000>;
>> + };
>> +
>> + partition@f0000 {
>> + label = "u-boot-env";
>> + reg = <0xf0000 0x8000>;
>> + };
>> +
>> + factory: partition@f8000 {
>> + label = "factory";
>> + reg = <0xf8000 0x8000>;
>> + read-only;
>> + };
>> +
>> + partition@100000 {
>> + label = "dtb";
>> + reg = <0x100000 0x10000>;
>> + read-only;
>> + };
>> +
>> + partition@110000 {
>> + label = "rescue";
>> + reg = <0x110000 0x1000000>;
>> + };
>> + };
>> + };
>> +};
>> +
>> +&sdhci1 {
>> + wp-inverted;
>> + bus-width = <4>;
>> + cd-gpios = <&gpionb 17 GPIO_ACTIVE_LOW>;
>> + marvell,pad-type = "sd";
>> + no-1-8-v;
>> + vqmmc-supply = <&vcc_sd_reg1>;
>> + status = "okay";
>> +};
>> +
>> +&sdhci0 {
>> + bus-width = <8>;
>> + mmc-ddr-1_8v;
>> + mmc-hs400-1_8v;
>> + non-removable;
>> + no-sd;
>> + no-sdio;
>> + marvell,pad-type = "fixed-1-8v";
>> + status = "okay";
>> +};
>> +
>> +&usb3 {
>> + status = "okay";
>> +};
>> +
>> +&usb2 {
>> + status = "okay";
>> +};
>> +
>> +&uart0 {
>> + status = "okay";
>> +};
>> +
>> +&mdio {
>> + switch0: switch0@1 {
>> + compatible = "marvell,mv88e6085";
>> + #address-cells = <1>;
>> + #size-cells = <0>;
>> + reg = <1>;
>> +
>> + dsa,member = <0 0>;
>> +
>> + ports: ports {
>> + #address-cells = <1>;
>> + #size-cells = <0>;
>> +
>> + port@0 {
>> + reg = <0>;
>> + label = "cpu";
>> + ethernet = <ð0>;
>> + };
>> +
>> + port@1 {
>> + reg = <1>;
>> + label = "wan";
>> + phy-handle = <&switch0phy0>;
>> + };
>> +
>> + port@2 {
>> + reg = <2>;
>> + label = "lan0";
>> + phy-handle = <&switch0phy1>;
>> +
>> + nvmem-cells = <&macaddr_factory_6>;
>> + nvmem-cell-names = "mac-address";
>> + };
>> +
>> + port@3 {
>> + reg = <3>;
>> + label = "lan1";
>> + phy-handle = <&switch0phy2>;
>> +
>> + nvmem-cells = <&macaddr_factory_6>;
>> + nvmem-cell-names = "mac-address";
>> + };
>> + };
>> +
>> + mdio {
>> + #address-cells = <1>;
>> + #size-cells = <0>;
>> +
>> + switch0phy0: switch0phy0@11 {
>> + reg = <0x11>;
>> + };
>> + switch0phy1: switch0phy1@12 {
>> + reg = <0x12>;
>> + };
>> + switch0phy2: switch0phy2@13 {
>> + reg = <0x13>;
>> + };
>> + };
>> + };
>> +};
>> +
>> +ð0 {
>> + nvmem-cells = <&macaddr_factory_0>;
>> + nvmem-cell-names = "mac-address";
>> + phy-mode = "rgmii-id";
>> + status = "okay";
>> +
>> + fixed-link {
>> + speed = <1000>;
>> + full-duplex;
>> + };
>> +};
>> +
>> +&factory {
>> + compatible = "nvmem-cells";
>> + #address-cells = <1>;
>> + #size-cells = <1>;
>> +
>> + macaddr_factory_0: macaddr@0 {
>> + reg = <0x0 0x6>;
>> + };
>> +
>> + macaddr_factory_6: macaddr@6 {
>> + reg = <0x6 0x6>;
>> + };
>> +};
>> --
>> 2.39.1
>>
--
Gregory Clement, Bootlin
Embedded Linux and Kernel engineering
http://bootlin.com
next prev parent reply other threads:[~2023-04-07 15:25 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-02 9:37 [PATCH V2] arm64: dts: marvell: add DTS for GL.iNet GL-MV1000 Enrico Mioso
2023-02-03 17:46 ` Pali Rohár
2023-02-03 17:46 ` Pali Rohár
2023-03-29 19:39 ` Pali Rohár
2023-03-29 19:39 ` Pali Rohár
2023-04-07 15:24 ` Gregory CLEMENT [this message]
2023-04-07 15:24 ` Gregory CLEMENT
2023-03-29 20:09 ` Andrew Lunn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87pm8f3ec4.fsf@BL-laptop \
--to=gregory.clement@bootlin.com \
--cc=andrew@lunn.ch \
--cc=devicetree@vger.kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=pali@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.